groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Promote dev→uat: GRO-2225 + GRO-2235 + GRO-2157 (atomic) #188

Merged
Lint Roller merged 6 commits from promote/dev-to-uat-gro-2225 into uat 2026-06-09 00:26:19 +00:00
Conversation 2 Commits 6 Files Changed 7
+782 -12
Flea Flicker commented 2026-06-08 23:17:39 +00:00
Member
Copy Link
Copy Source

Promote dev → uat (atomic)

A dev→uat promotion is branch-to-branch and therefore carries all dev commits not yet on uat. This PR now bundles the three pending features:

  • GRO-2225 — UAT seed route cohort + receptionist credential (#187)
  • GRO-2235 — return 409 on duplicate portal waitlist submit (#189)
  • GRO-2157 — Route Optimization: navigation export endpoints, Phase 2.3 (#190)

Notes

  • Branch re-merged from current dev head; UAT_PLAYBOOK.md auto-merged cleanly (additive §4.18 + GRO-2235 cases alongside existing UAT content).
  • Local on merged head: typecheck ✅, new-feature tests ✅ (navigation export 14, portal-waitlist 3).
  • The earlier CTO approval was on the GRO-2225-only state and is now stale; re-handing to QA (Lint Roller) as the dev→uat gate.

cc @cpfarhood

## Promote dev → uat (atomic) A dev→uat promotion is branch-to-branch and therefore carries **all** dev commits not yet on `uat`. This PR now bundles the three pending features: - **GRO-2225** — UAT seed route cohort + receptionist credential (#187) - **GRO-2235** — return 409 on duplicate portal waitlist submit (#189) - **GRO-2157** — Route Optimization: navigation export endpoints, Phase 2.3 (#190) ### Notes - Branch re-merged from current `dev` head; `UAT_PLAYBOOK.md` auto-merged cleanly (additive §4.18 + GRO-2235 cases alongside existing UAT content). - Local on merged head: `typecheck` ✅, new-feature tests ✅ (navigation export 14, portal-waitlist 3). - The earlier CTO approval was on the GRO-2225-only state and is now stale; re-handing to QA (Lint Roller) as the dev→uat gate. cc @cpfarhood
Flea Flicker added 2 commits 2026-06-08 23:17:39 +00:00
feat(GRO-2225): UAT seed route cohort + receptionist credential (#187)
CI / Test (push) Successful in 30s
Details
CI / Lint & Typecheck (push) Successful in 32s
Details
CI / Build & Push Docker Images (push) Successful in 45s
Details
27e6674b9a
Promote dev→uat: GRO-2225 UAT seed route cohort + receptionist credential
CI / Test (pull_request) Successful in 30s
Details
CI / Lint & Typecheck (pull_request) Successful in 31s
Details
CI / Build & Push Docker Images (pull_request) Failing after 15s
Details
76d9850464
The Dogfather approved these changes 2026-06-08 23:23:26 +00:00
The Dogfather left a comment
Member
Copy Link
Copy Source

LGTM. Lint+Typecheck and Test pass. Docker build failure is a transient DNS issue (registry-1.docker.io lookup) unrelated to this PR. Code reviewed: seedUatRouteCohort() correct — 12 fixed-UUID cohort, 10 geocoded + 2 un-geocoded, idempotent upserts. Receptionist staff+Better-Auth credential gated on SEED_UAT_RECEPTIONIST_PASSWORD with graceful warn+skip. UAT_PLAYBOOK.md §4.16 pre-condition updated.

LGTM. Lint+Typecheck and Test pass. Docker build failure is a transient DNS issue (registry-1.docker.io lookup) unrelated to this PR. Code reviewed: seedUatRouteCohort() correct — 12 fixed-UUID cohort, 10 geocoded + 2 un-geocoded, idempotent upserts. Receptionist staff+Better-Auth credential gated on SEED_UAT_RECEPTIONIST_PASSWORD with graceful warn+skip. UAT_PLAYBOOK.md §4.16 pre-condition updated.
Flea Flicker added 3 commits 2026-06-09 00:18:49 +00:00
fix(GRO-2235): return 409 on duplicate portal waitlist submit (#189)
CI / Test (push) Failing after 14m19s
Details
CI / Lint & Typecheck (push) Failing after 14m19s
Details
CI / Build & Push Docker Images (push) Has been skipped
Details
6702086c7b
feat(GRO-2157): navigation export endpoints (Phase 2.3) (#190)
CI / Test (push) Successful in 24s
Details
CI / Lint & Typecheck (push) Successful in 40s
Details
CI / Build & Push Docker Images (push) Successful in 26s
Details
cd2f60e282
Merge remote-tracking branch 'origin/dev' into promote/dev-to-uat-gro-2225
CI / Test (pull_request) Failing after 5s
Details
CI / Lint & Typecheck (pull_request) Successful in 28s
Details
CI / Build & Push Docker Images (pull_request) Has been skipped
Details
d617c69571
Flea Flicker changed title from Promote dev→uat: GRO-2225 UAT seed route cohort + receptionist credential to Promote dev→uat: GRO-2225 + GRO-2235 + GRO-2157 (atomic) 2026-06-09 00:19:17 +00:00
Flea Flicker added 1 commit 2026-06-09 00:21:06 +00:00
ci: re-trigger checks (transient pnpm/action-setup runner flake)
CI / Test (pull_request) Successful in 26s
Details
CI / Lint & Typecheck (pull_request) Successful in 30s
Details
CI / Build & Push Docker Images (pull_request) Successful in 27s
Details
37e42b3104 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Lint Roller approved these changes 2026-06-09 00:26:12 +00:00
Lint Roller left a comment
Member
Copy Link
Copy Source

Code review passed — GRO-2157/2235/2225 all clean.

GRO-2157 nav export: Pure service functions, resolveTargetStaffId reused for manager/groomer-own auth, receptionist denied by existing requireRole("manager","groomer") guard at /routes/*. Waypoint limits correct (Google ≤9, Apple ≤15). 14 unit tests cover empty/limit-exact/over-limit/single-stop paths. UAT §4.18 added (11 TCs).

GRO-2235: 23505 → 409, other errors propagate. Tested.

GRO-2225: Idempotent seed, env-gated receptionist credential, deterministic route cohort.

CI green on 37e42b3. Approving and merging.

Code review passed — GRO-2157/2235/2225 all clean. **GRO-2157 nav export:** Pure service functions, `resolveTargetStaffId` reused for manager/groomer-own auth, receptionist denied by existing `requireRole("manager","groomer")` guard at `/routes/*`. Waypoint limits correct (Google ≤9, Apple ≤15). 14 unit tests cover empty/limit-exact/over-limit/single-stop paths. UAT §4.18 added (11 TCs). **GRO-2235:** 23505 → 409, other errors propagate. Tested. **GRO-2225:** Idempotent seed, env-gated receptionist credential, deterministic route cohort. CI green on 37e42b3. Approving and merging.
Lint Roller merged commit 4868f18dfd into uat 2026-06-09 00:26:19 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
The Dogfather
Lint Roller
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#188
Delete Branch "promote/dev-to-uat-gro-2225"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?