groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-1272): auto-provision staff record on first OIDC login #19

Merged
groombook-engineer[bot] merged 4 commits from fleaflicker/gro-1272-auto-provision-staff-dev into dev 2026-05-21 14:16:42 +00:00
Conversation 9 Commits 4 Files Changed 3
+8 -5
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ea825dfdda - Show all commits
apps/api/src/__tests__/rbac.test.ts
+8 -5
View File
@@ -46,7 +46,7 @@ const GROOMER: StaffRow = {
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
let staffLookupResult: StaffRow | null = null;
let managerFallbackResult: StaffRow | null = MANAGER;
let userLookupResult: { id: string; name: string | null; email: string | null } | null = null;
let insertedStaff: StaffRow | null = null;
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
let _insertedStaff: StaffRow | null = null;
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
vi.mock("../db", () => {
const makeTableProxy = (name: string) =>
@@ -88,7 +88,7 @@ vi.mock("../db", () => {
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
),
}),
}),
insert: (table: unknown) => ({
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
insert: (_table: unknown) => ({
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
values: (vals: Record<string, unknown>) => ({
returning: () => {
const newStaff: StaffRow = {
@@ -104,7 +104,7 @@ vi.mock("../db", () => {
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
createdAt: new Date(),
updatedAt: new Date(),
};
insertedStaff = newStaff;
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
_insertedStaff = newStaff;
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
return [newStaff];
},
}),
@@ -124,7 +124,7 @@ function resetMocks() {
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
staffLookupResult = null;
managerFallbackResult = MANAGER;
userLookupResult = null;
insertedStaff = null;
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
_insertedStaff = null;
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
}
/** Build a minimal Hono app with jwtPayload pre-set, then apply a middleware. */
@@ -134,7 +134,10 @@ function buildApp(
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
) {
const app = new Hono<AppEnv>();
app.use("*", async (c, next) => {
c.set("jwtPayload", { sub: staffLookupResult?.userId ?? "unknown-sub" });
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
c.set("jwtPayload", {
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
sub: userLookupResult?.id ?? staffLookupResult?.userId ?? "unknown-sub",
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
email: userLookupResult?.email,
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
});
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
await next();
});
app.use("*", middleware);
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.