groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-1272): auto-provision staff record on first OIDC login #19

Merged
groombook-engineer[bot] merged 4 commits from fleaflicker/gro-1272-auto-provision-staff-dev into dev 2026-05-21 14:16:42 +00:00
Conversation 9 Commits 4 Files Changed 3
+14 -7
2 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f9b68eb932 - Show all commits
apps/api/src/__tests__/rbac.test.ts
+11 -7
View File
@@ -65,13 +65,17 @@ vi.mock("../db", () => {
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
const user = makeTableProxy("user");
const buildQuery = (result: unknown, fallback: unknown) => ({
limit: () => ({
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
[Symbol.iterator]: function* () {
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
if (result) yield result;
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
},
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
0: result,
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
length: result ? 1 : 0,
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
}),
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
[Symbol.iterator]: function* () {
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
if (result) yield result;
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
},
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
limit: (_n: number) => {
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
const item = result ?? fallback;
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
return {
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
[Symbol.iterator]: function* () { if (item) yield item; },
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
0: item,
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
length: item ? 1 : 0,
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
};
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
},
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
});
return {
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.

returns with no . All non-limit WHERE queries throw TypeError → 500. Add to the returned object, and make fall back to when is null.
apps/api/src/middleware/rbac.ts
+3
View File
@@ -130,6 +130,9 @@ export const resolveStaffMiddleware: MiddlewareHandler<AppEnv> = async (
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

TS2769: is — add a guard before to avoid passing .

TS2769: is — add a guard before to avoid passing .
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

TS2769: is — add a guard before to avoid passing .

TS2769: is — add a guard before to avoid passing .
active: true,
})
.returning();
if (!newStaff) {
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

TS2769: is — add a guard before to avoid passing .

TS2769: is — add a guard before to avoid passing .
return c.json({ error: "Internal error: staff record creation failed" }, 500);
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

TS2769: is — add a guard before to avoid passing .

TS2769: is — add a guard before to avoid passing .
}
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

TS2769: is — add a guard before to avoid passing .

TS2769: is — add a guard before to avoid passing .
c.set("staff", newStaff);
await next();
return;
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

TS2769: is — add a guard before to avoid passing .

TS2769: is — add a guard before to avoid passing .
Lint Roller commented 2026-05-20 13:10:06 +00:00
Review
Copy Link
Copy Source

TS2769: is — add a guard before to avoid passing .

TS2769: is — add a guard before to avoid passing .