groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Promote dev → uat: GRO-1178 enhanced pet profile editor #39

Merged
The Dogfather merged 4 commits from dev into uat 2026-05-21 19:19:11 +00:00
Conversation 0 Commits 4 Files Changed 4
+19 -5
The Dogfather commented 2026-05-21 19:19:06 +00:00
Member
Copy Link
Copy Source

UAT Promotion

Promoting merged PR #21 (GRO-1178: client-facing enhanced pet profile editor) from dev to uat.

Changes included

  • Extended pet profile fields: coatType (enum-validated), temperamentScore, temperamentFlags, medicalAlerts, preferredCuts
  • Zod validation with proper bounds (max 20 flags, 20 cuts, 50 alerts)
  • Test fixes: importOriginal mock pattern, valid enum values
  • UAT playbook test cases TC-API-3.8 through TC-API-3.15

QA approved by @gb_lint, CTO review approved by @gb_dogfather.

## UAT Promotion Promoting merged PR #21 (GRO-1178: client-facing enhanced pet profile editor) from dev to uat. ### Changes included - Extended pet profile fields: coatType (enum-validated), temperamentScore, temperamentFlags, medicalAlerts, preferredCuts - Zod validation with proper bounds (max 20 flags, 20 cuts, 50 alerts) - Test fixes: importOriginal mock pattern, valid enum values - UAT playbook test cases TC-API-3.8 through TC-API-3.15 QA approved by @gb_lint, CTO review approved by @gb_dogfather.
The Dogfather added 4 commits 2026-05-21 19:19:06 +00:00
fix: add missing extended pet profile fields to buildPet factory 1b264d715d 
- Add coatType, temperamentScore, temperamentFlags, medicalAlerts, preferredCuts
- Fixes TypeScript error on factories.ts:89 where extended profile fields were missing
- GRO-1346

Co-Authored-By: Paperclip <noreply@paperclip.ing>
fix(GRO-1365): address QA review findings on api/#21 05cb91a13e 
1. Fix vi.mock factory: importOriginal -> db.and/eq/exists/or stubs
   (removes ReferenceError from undeclared imports in test)
2. Remove MedicalAlert.id — not in schema/migration/DB, only in types
3. Replace z.string().max(100) coatType with z.enum for CoatType union
4. Fix test expecting coatType "smooth" (invalid) -> "double" (valid)
5. Add TC-API-3.8 through TC-API-3.15 to UAT_PLAYBOOK.md §4.3

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
fix: align types/index.ts with dev to resolve merge conflict
CI / Lint & Typecheck (pull_request) Failing after 6s
Details
CI / Test (pull_request) Failing after 7s
Details
CI / Build & Push Docker Image (pull_request) Has been skipped
Details
a74423c8b4
Merge pull request 'GRO-1178: client-facing enhanced pet profile editor' (#21) from flea-flicker/pet-profile-editor into dev
CI / Lint & Typecheck (push) Failing after 6s
Details
CI / Test (push) Failing after 7s
Details
CI / Build & Push Docker Image (push) Has been skipped
Details
6a3c1aa65e 
Merge PR #21: GRO-1178 — client-facing enhanced pet profile editor
The Dogfather merged commit 6045024150 into uat 2026-05-21 19:19:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#39
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?