groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-1742): add portal PATCH /portal/pets/:id endpoint #68

Closed
The Dogfather wants to merge 2 commits from fix/gro-1480-portal-pets-patch into dev
pull from: fix/gro-1480-portal-pets-patch
merge into: groombook:dev
Conversation 1 Commits 2 Files Changed 3
+209 -12
The Dogfather commented 2026-05-25 15:25:37 +00:00
Member
Copy Link
Copy Source

Summary

  • Add portalRouter.patch("/pets/:id", ...) in src/routes/portal.ts
  • Ownership validation: return 403 if pet's clientId != portalClientId from session
  • Uses same update schema as staff PATCH /api/pets/:id minus staff-only fields
  • Returns pet in portal shape matching GET /portal/pets response
  • 5 test cases: success, 401 missing/expired session, 403 wrong owner, 404 not found

Test plan

  • Unit tests pass (pnpm test -- --run src/__tests__/portal.test.ts)
  • All 57 portal tests pass

cc @cpfarhood

## Summary - Add `portalRouter.patch("/pets/:id", ...)` in `src/routes/portal.ts` - Ownership validation: return 403 if pet's `clientId` != `portalClientId` from session - Uses same update schema as staff `PATCH /api/pets/:id` minus staff-only fields - Returns pet in portal shape matching `GET /portal/pets` response - 5 test cases: success, 401 missing/expired session, 403 wrong owner, 404 not found ## Test plan - [x] Unit tests pass (`pnpm test -- --run src/__tests__/portal.test.ts`) - [x] All 57 portal tests pass cc @cpfarhood
The Dogfather added 1 commit 2026-05-25 15:25:37 +00:00
fix(GRO-1742): add portal PATCH /portal/pets/:id endpoint
CI / Test (pull_request) Successful in 9s
Details
CI / Lint & Typecheck (pull_request) Successful in 10s
Details
CI / Build & Push Docker Images (pull_request) Successful in 47s
Details
59cc1742cc 
- Add portalRouter.patch("/pets/:id", ...) handler in src/routes/portal.ts
- Ownership validation: return 403 if pet's clientId != portalClientId
- Uses same update schema as staff PATCH /api/pets/:id minus staff-only fields
- Returns pet in portal shape matching GET /portal/pets response
- Add 5 test cases covering: success, 401 missing/expired session, 403 wrong owner, 404 not found
- Fix mock to support pets table + insert for impersonationAuditLogs

Co-Authored-By: Paperclip <noreply@paperclip.ing>
The Dogfather added 1 commit 2026-05-25 15:26:41 +00:00
docs(UAT_PLAYBOOK.md): add TC-API-8.8/8.9/8.10 for portal pet update
CI / Test (pull_request) Successful in 10s
Details
CI / Lint & Typecheck (pull_request) Successful in 12s
Details
CI / Build & Push Docker Images (pull_request) Successful in 18s
Details
cca83b18cf 
Updated §4.8 — new PATCH /api/portal/pets/:id test cases per GRO-1742.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
The Dogfather reviewed 2026-05-25 23:23:37 +00:00
The Dogfather left a comment
Author
Member
Copy Link
Copy Source

Closing as stale — GRO-1742 is done and the portal PATCH /portal/pets/:id endpoint already exists on dev. Branch name (fix/gro-1480-portal-pets-patch) also references the wrong issue.

Closing as stale — GRO-1742 is done and the portal PATCH /portal/pets/:id endpoint already exists on dev. Branch name (`fix/gro-1480-portal-pets-patch`) also references the wrong issue.
The Dogfather closed this pull request 2026-05-25 23:23:48 +00:00
Some checks are pending
CI / Test (pull_request) Successful in 10s
Details
CI / Lint & Typecheck (pull_request) Successful in 12s
Details
CI / Build & Push Docker Images (pull_request) Successful in 18s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
The Dogfather
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#68
Delete Branch "fix/gro-1480-portal-pets-patch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?