groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

promote: dev → uat (GRO-1790 pet profile summary bug fixes) #90

Closed
The Dogfather wants to merge 0 commits from dev into uat
pull from: dev
merge into: groombook:uat
Conversation 1 Commits - Files Changed -
+535 -13
The Dogfather commented 2026-05-26 11:53:55 +00:00
Member
Copy Link
Copy Source

UAT Promotion

Promotes dev → uat after CTO review and QA pass on PR #30.

Changes included

  • GRO-1790: fix visitCount bug (was capped at 0/1, now returns actual count)
  • GRO-1790: fix upcomingAppointment date filter (past appointments excluded)
  • GRO-1177: pet profile summary endpoint
  • RBAC guard fix, CI fixes

Verification

  • QA reviewed and passed (Lint Roller)
  • CTO reviewed and merged PR #30
  • CI green (run 1805)
## UAT Promotion Promotes dev → uat after CTO review and QA pass on PR #30. ### Changes included - **GRO-1790**: fix visitCount bug (was capped at 0/1, now returns actual count) - **GRO-1790**: fix upcomingAppointment date filter (past appointments excluded) - **GRO-1177**: pet profile summary endpoint - RBAC guard fix, CI fixes ### Verification - QA reviewed and passed (Lint Roller) - CTO reviewed and merged PR #30 - CI green (run 1805)
The Dogfather added 9 commits 2026-05-26 11:53:55 +00:00
feat(GRO-1177): add GET /api/pets/:id/profile-summary endpoint
CI / Lint & Typecheck (pull_request) Successful in 9s
Details
CI / Test (pull_request) Successful in 9s
Details
CI / Build & Push Docker Images (pull_request) Successful in 37s
Details
8c62ce2368 
Returns aggregated pet profile with:
- All pet fields (basic + extended)
- recentGroomingHistory: last 10 entries from groomingVisitLogs with staff name join
- lastVisitDate: most recent groomedAt timestamp
- visitCount: count of completed appointments
- upcomingAppointment: next scheduled/confirmed appointment with service/staff name

Enforces same groomer RBAC as GET /:id. Returns 404 for non-existent pets.
Adds PetProfileSummary, GroomingHistoryEntry, and UpcomingAppointment types.
Adds unit tests covering: 404, 403, aggregated profile, empty history, no upcoming appt.
Updates UAT_PLAYBOOK.md §3 with TC-API-3.8 and TC-API-3.9.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
chore: trigger CI for GRO-1757 + GRO-1764 a610ef9d39 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
chore: PR CI build trigger for GRO-1757 image (do not merge) (#87) b83a793de4 
Co-authored-by: Lint Roller <lint@groombook.dev>
Co-committed-by: Lint Roller <lint@groombook.dev>
chore: direct push CI trigger for GRO-1757 (b61d899f) to include in dev image d9ba6045ad 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
fix(ci): remove duplicate provenance keys causing YAML parse error
CI / Lint & Typecheck (push) Failing after 4s
Details
CI / Test (push) Successful in 15s
Details
CI / Build & Push Docker Images (push) Has been skipped
Details
b796d36aed 
Duplicate 'provenance: false' in each docker/build-push-action step caused
Gitea to reject the workflow file, breaking push CI and workflow_dispatch.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
fix(rbac): guard noUncheckedIndexedAccess in name derivation and newStaff insert
CI / Lint & Typecheck (push) Successful in 12s
Details
CI / Test (push) Successful in 14s
Details
CI / Build & Push Docker Images (push) Successful in 46s
Details
3b9e82adff 
With noUncheckedIndexedAccess:true, split("@")[0] returns string|undefined,
making `name` typed as string|undefined and failing the notNull staff.name
insert constraint. Fix by using ?? fallback on the array access.

Also add newStaff null guard after .returning() destructure — array
destructuring yields T|undefined with noUncheckedIndexedAccess enabled.
fix: address CTO review — visitCount bug + upcomingAppointment date filter de33edd7c6 
- Replace .select({ count: appointments.id }).limit(1) + .length with
  sql<number>`count(*)::int` pattern per project standard (references invoices.ts:86)
- Add gte(appointments.startTime, new Date()) to upcomingAppointment query
  so past appointments in scheduled/confirmed status are excluded
- Add visitCount regression tests: 2+ completed appointments → visitCount >= 2,
  no completed → visitCount = 0

Updated UAT_PLAYBOOK.md §profile-summary (visitCount regression + date filter)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
docs: add TC-API-3.18 and TC-API-3.19 to UAT_PLAYBOOK for visitCount regression + date filter
CI / Lint & Typecheck (pull_request) Successful in 12s
Details
CI / Test (pull_request) Successful in 12s
Details
CI / Build & Push Docker Images (pull_request) Successful in 1m4s
Details
a25b2fe281 
Updated UAT_PLAYBOOK.md §3.3 — new visitCount cap and past appointment filter test cases

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Merge pull request 'feat(GRO-1177): add pet profile summary endpoint' (#30) from flea-flicker/pet-profile-summary into dev
CI / Lint & Typecheck (push) Successful in 12s
Details
CI / Test (push) Successful in 12s
Details
CI / Build & Push Docker Images (push) Successful in 2m52s
Details
9622b109d0 
feat(GRO-1177): add pet profile summary endpoint (#30)

Adds GET /api/pets/:id/profile-summary with aggregated pet profile,
grooming history, visit count, and upcoming appointment.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
The Dogfather requested review from Lint Roller 2026-05-26 11:56:03 +00:00
Lint Roller approved these changes 2026-05-26 11:58:30 +00:00
Lint Roller left a comment
Member
Copy Link
Copy Source

QA approval for dev → uat promotion. Changes already reviewed in PR #30.

QA approval for dev → uat promotion. Changes already reviewed in PR #30.
The Dogfather closed this pull request 2026-05-26 12:01:19 +00:00
Some checks are pending
CI / Lint & Typecheck (push) Successful in 12s
Details
CI / Test (push) Successful in 12s
Details
CI / Build & Push Docker Images (push) Successful in 2m52s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Lint Roller
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#90
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?