From 1477f4ee7731af79839fd350c64912c337080683 Mon Sep 17 00:00:00 2001 From: Flea Flicker Date: Fri, 27 Mar 2026 02:11:57 +0000 Subject: [PATCH] fix(e2e): remove stale DevLoginSelector tests The /login route is now guarded by import.meta.env.DEV (fix from GRO-56), so the DevLoginSelector never renders in production builds. All 7 tests in login.spec.ts tested this dev-only page and were correctly failing in the E2E suite. Remove them entirely. Co-Authored-By: Paperclip --- apps/e2e/tests/login.spec.ts | 66 ------------------------------------ 1 file changed, 66 deletions(-) delete mode 100644 apps/e2e/tests/login.spec.ts diff --git a/apps/e2e/tests/login.spec.ts b/apps/e2e/tests/login.spec.ts deleted file mode 100644 index 6f21a1e..0000000 --- a/apps/e2e/tests/login.spec.ts +++ /dev/null @@ -1,66 +0,0 @@ -import { test, expect } from "./fixtures.js"; - -/** - * E2E tests for the DevLoginSelector page (/login). - * Tests staff/client selection, skip login, and navigation redirects. - */ - -test.describe("DevLoginSelector", () => { - test("renders login page with staff and clients sections", async ({ page }) => { - await page.goto("/login"); - await expect(page.getByText("Dev Login Selector")).toBeVisible(); - await expect(page.getByText("Staff")).toBeVisible(); - await expect(page.getByText("Clients")).toBeVisible(); - }); - - test("shows loading state while fetching users", async ({ page }) => { - await page.unroute("**/api/dev/users"); - await page.route("**/api/dev/users", async (route) => { - await new Promise((r) => setTimeout(r, 200)); - await route.fulfill({ json: { staff: [], clients: [] } }); - }); - await page.goto("/login"); - await expect(page.getByText("Loading users...")).toBeVisible(); - }); - - test("displays staff users with role and email", async ({ page }) => { - await page.goto("/login"); - await expect(page.getByText("Alice Groomer")).toBeVisible(); - await expect(page.getByText("groomer · alice@groombook.dev")).toBeVisible(); - await expect(page.getByText("Bob Manager")).toBeVisible(); - await expect(page.getByText("manager · bob@groombook.dev")).toBeVisible(); - }); - - test("displays client users with pet count", async ({ page }) => { - await page.goto("/login"); - await expect(page.getByText("Carol Client")).toBeVisible(); - await expect(page.getByText("2 pets · carol@example.com")).toBeVisible(); - await expect(page.getByText("Dave Client")).toBeVisible(); - await expect(page.getByText("1 pet")).toBeVisible(); - }); - - test("clicking staff user navigates to /admin and stores dev-user", async ({ page }) => { - await page.goto("/login"); - await page.getByText("Alice Groomer").click(); - await expect(page).toHaveURL("/admin"); - const devUser = await page.evaluate(() => localStorage.getItem("dev-user")); - expect(JSON.parse(devUser!)).toMatchObject({ type: "staff", id: "staff-1", name: "Alice Groomer" }); - }); - - test("clicking client user navigates to / and stores dev-user", async ({ page }) => { - await page.goto("/login"); - await page.getByText("Carol Client").click(); - await expect(page).toHaveURL("/"); - const devUser = await page.evaluate(() => localStorage.getItem("dev-user")); - expect(JSON.parse(devUser!)).toMatchObject({ type: "client", id: "client-1", name: "Carol Client" }); - }); - - test("no users available shows empty sections", async ({ page }) => { - await page.route("**/api/dev/users", (route) => - route.fulfill({ json: { staff: [], clients: [] } }) - ); - await page.goto("/login"); - await expect(page.getByText("Staff")).toBeVisible(); - await expect(page.getByText("Clients")).toBeVisible(); - }); -});