From 20920022a63b320126e64662c6b8b54d0a98ef44 Mon Sep 17 00:00:00 2001
From: "groombook-ceo[bot]"
 <269735724+groombook-ceo[bot]@users.noreply.github.com>
Date: Sun, 29 Mar 2026 14:07:21 +0000
Subject: [PATCH] fix: increase deployment rollout timeout to 300s (GRO-147)
 (#148)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Squash merge. CTO + QA approved, all CI checks green.

- Helm progressDeadlineSeconds: 120s → 300s (api + web)
- CI kubectl rollout timeout: 120s → 300s

Fixes groombook-dev CI deploy step timing out while pods complete successfully.

cc @cpfarhood
---
 .github/workflows/ci.yml                       | 4 ++--
 charts/groombook/templates/api-deployment.yaml | 1 +
 charts/groombook/templates/web-deployment.yaml | 1 +
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 27aea8f..ee2f56c 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -246,8 +246,8 @@ jobs:
           kubectl set image deployment/web web=ghcr.io/groombook/web:$TAG -n groombook-dev
 
           # Wait for rollout
-          kubectl rollout status deployment/api -n groombook-dev --timeout=120s
-          kubectl rollout status deployment/web -n groombook-dev --timeout=120s
+          kubectl rollout status deployment/api -n groombook-dev --timeout=300s
+          kubectl rollout status deployment/web -n groombook-dev --timeout=300s
 
           echo "Deployment complete."
 
diff --git a/charts/groombook/templates/api-deployment.yaml b/charts/groombook/templates/api-deployment.yaml
index 8e118d4..aaee7b0 100644
--- a/charts/groombook/templates/api-deployment.yaml
+++ b/charts/groombook/templates/api-deployment.yaml
@@ -7,6 +7,7 @@ metadata:
     app.kubernetes.io/component: api
 spec:
   replicas: {{ .Values.api.replicas }}
+  progressDeadlineSeconds: 300
   selector:
     matchLabels:
       {{- include "groombook.selectorLabels" . | nindent 6 }}
diff --git a/charts/groombook/templates/web-deployment.yaml b/charts/groombook/templates/web-deployment.yaml
index 9652811..f757dcc 100644
--- a/charts/groombook/templates/web-deployment.yaml
+++ b/charts/groombook/templates/web-deployment.yaml
@@ -7,6 +7,7 @@ metadata:
     app.kubernetes.io/component: web
 spec:
   replicas: {{ .Values.web.replicas }}
+  progressDeadlineSeconds: 300
   selector:
     matchLabels:
       {{- include "groombook.selectorLabels" . | nindent 6 }}