groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(gro-609): fix two bugs found by CTO review

Browse Source 
1. Refund stats now sum actual refund amounts from refunds table
   instead of incorrectly summing tip_cents from invoices table.

2. Stripe payment_intents.retrieve now expands payment_method
   so card.last4 is correctly available instead of null.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Test User
2026-04-19 01:55:32 +00:00
parent 50e9e70935
commit 560d33edf8
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/api/src/routes/invoices.ts
+3 -3
View File
@@ -495,9 +495,9 @@ invoicesRouter.get("/stats/summary", async (c) => {
.where(eq(invoices.status, "pending")); .where(eq(invoices.status, "pending"));
const [refundsResult] = await db const [refundsResult] = await db
.select({ total: sql<number>`coalesce(sum(tip_cents), 0)` }) .select({ total: sql<number>`coalesce(sum(amount_cents), 0)` })
.from(invoices) .from(refunds)
.where(and(eq(invoices.status, "paid"), sql`${invoices.paidAt} >= ${startOfMonth}`)); .where(sql`${refunds.createdAt} >= ${startOfMonth}`);
const methodBreakdown = await db const methodBreakdown = await db
.select({ .select({
apps/api/src/services/payment.ts
+1 -1
View File
@@ -169,7 +169,7 @@ export async function getPaymentIntentDetails(
const stripe = getStripeClient(); const stripe = getStripeClient();
if (!stripe) return null; if (!stripe) return null;
const pi = await stripe.paymentIntents.retrieve(paymentIntentId); const pi = await stripe.paymentIntents.retrieve(paymentIntentId, { expand: ["payment_method"] });
const cardLast4 = pi.payment_method const cardLast4 = pi.payment_method
? (pi.payment_method as Stripe.PaymentMethod).card?.last4 ?? null ? (pi.payment_method as Stripe.PaymentMethod).card?.last4 ?? null
: null; : null;