From 56477809c91bb9b30864eb04a9d39cbabf054329 Mon Sep 17 00:00:00 2001
From: Flea Flicker <fleaflicker@groombook.farh.net>
Date: Fri, 17 Apr 2026 18:25:04 +0000
Subject: [PATCH] feat(GRO-785): validate tip split totals before marking
 invoice paid

- PATCH /invoices/:id returns 400 when tipCents > 0 but no tip splits
  exist or splits don't sum to 100%
- POST /invoices/:id/tip-splits now returns 400 (not 422) on validation
  failure via router-level ZodError handler

Co-Authored-By: Paperclip <noreply@paperclip.ing>
---
 apps/api/src/routes/invoices.ts | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/apps/api/src/routes/invoices.ts b/apps/api/src/routes/invoices.ts
index 2714be4..f59fc58 100644
--- a/apps/api/src/routes/invoices.ts
+++ b/apps/api/src/routes/invoices.ts
@@ -18,6 +18,14 @@ import type { AppEnv } from "../middleware/rbac.js";
 
 export const invoicesRouter = new Hono<AppEnv>();
 
+// Convert Zod validation errors from 422 to 400
+invoicesRouter.onError((err, c) => {
+  if (err instanceof z.ZodError) {
+    return c.json({ error: "Validation failed", issues: err.issues }, 400);
+  }
+  throw err;
+});
+
 const createInvoiceSchema = z.object({
   appointmentId: z.string().uuid().optional(),
   clientId: z.string().uuid(),
@@ -334,6 +342,29 @@ invoicesRouter.patch(
       }
     }
 
+    // Validate tip splits when marking invoice as paid
+    if (body.status === "paid" && current.tipCents > 0) {
+      const splits = await db
+        .select()
+        .from(invoiceTipSplits)
+        .where(eq(invoiceTipSplits.invoiceId, id));
+
+      if (splits.length === 0) {
+        return c.json(
+          { error: "Tip split percentages must sum to 100%" },
+          400
+        );
+      }
+
+      const totalBps = splits.reduce((sum, s) => sum + Math.round(Number(s.sharePct) * 100), 0);
+      if (totalBps !== 10000) {
+        return c.json(
+          { error: "Tip split percentages must sum to 100%" },
+          400
+        );
+      }
+    }
+
     const update: Record<string, unknown> = { ...body, updatedAt: new Date() };
 
     // Auto-set paidAt when marking as paid