groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(waitlist): use slice instead of split to avoid TS strict null check errors

Browse Source 
TypeScript's split()[0] is typed as string | undefined in strict mode.
Using slice(0, 10) is cleaner and avoids the type issue.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Scrubs McBarkley
2026-03-25 06:37:58 +00:00
committed by Flea Flicker
parent 1f56ba98f7
commit 84ab5a00f5
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/api/src/routes/waitlist.ts
+3 -3
View File
@@ -17,7 +17,7 @@ import type { AppEnv } from "../middleware/rbac.js";
export const waitlistRouter = new Hono<AppEnv>(); export const waitlistRouter = new Hono<AppEnv>();
async function markExpiredEntries(db: ReturnType<typeof getDb>, rows: typeof waitlistEntries.$inferSelect[]) { async function markExpiredEntries(db: ReturnType<typeof getDb>, rows: typeof waitlistEntries.$inferSelect[]) {
const today = new Date().toISOString().split("T")[0]; const today = new Date().toISOString().slice(0, 10);
const expiredIds = rows const expiredIds = rows
.filter((r) => r.status === "active" && r.preferredDate < today) .filter((r) => r.status === "active" && r.preferredDate < today)
.map((r) => r.id); .map((r) => r.id);
@@ -67,7 +67,7 @@ waitlistRouter.get("/", async (c) => {
await markExpiredEntries(db, rows); await markExpiredEntries(db, rows);
const today = new Date().toISOString().split("T")[0]; const today = new Date().toISOString().slice(0, 10);
const enriched = await Promise.all( const enriched = await Promise.all(
rows.map(async (entry) => { rows.map(async (entry) => {
@@ -111,7 +111,7 @@ waitlistRouter.get("/:id", async (c) => {
if (!row) return c.json({ error: "Not found" }, 404); if (!row) return c.json({ error: "Not found" }, 404);
await markExpiredEntries(db, [row]); await markExpiredEntries(db, [row]);
const today = new Date().toISOString().split("T")[0]; const today = new Date().toISOString().slice(0, 10);
const isExpired = row.status === "active" && row.preferredDate < today; const isExpired = row.status === "active" && row.preferredDate < today;
return c.json({ return c.json({
...row, ...row,