groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-985): fix Messages test mocks and scrollIntoView guard

Browse Source 
- Wrap conversation mocks in { items, nextCursor } response shape
  (loadConversations reads json.items, bare array caused undefined.length crash)
- Guard scrollIntoView with ?. (jsdom doesn't implement it)
- Use getAllByText for text appearing in both preview and thread

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Chris Farhood
2026-05-14 16:12:31 +00:00
committed by The Dogfather [agent]
parent e605e1be74
commit 9d9d7da13d
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/src/__tests__/Messages.test.tsx
+3 -3
View File
@@ -96,7 +96,7 @@ describe("MessagesPage", () => {
vi.mocked(global.fetch).mockImplementation((input) => { vi.mocked(global.fetch).mockImplementation((input) => {
const url = String(input); const url = String(input);
if (url === "/api/conversations?limit=20") { if (url === "/api/conversations?limit=20") {
return Promise.resolve(makeResponse(mockConversations)); return Promise.resolve(makeResponse({ items: mockConversations, nextCursor: null }));
} }
if (url === "/api/conversations/conv-1/messages?limit=50") { if (url === "/api/conversations/conv-1/messages?limit=50") {
return Promise.resolve(makeResponse({ items: mockMessages, nextCursor: null })); return Promise.resolve(makeResponse({ items: mockMessages, nextCursor: null }));
@@ -110,7 +110,7 @@ describe("MessagesPage", () => {
fireEvent.click(screen.getByText("Alice Smith")); fireEvent.click(screen.getByText("Alice Smith"));
await waitFor(() => { await waitFor(() => {
expect(screen.getByText("Hello, is my dog ready?")).toBeInTheDocument(); expect(screen.getAllByText("Hello, is my dog ready?").length).toBeGreaterThanOrEqual(1);
expect(screen.getByText("Yes, she is all done!")).toBeInTheDocument(); expect(screen.getByText("Yes, she is all done!")).toBeInTheDocument();
}); });
}); });
@@ -130,7 +130,7 @@ describe("MessagesPage", () => {
sentByStaffId: "staff-1", sentByStaffId: "staff-1",
}, 201)); }, 201));
} }
return Promise.resolve(makeResponse(mockConversations)); return Promise.resolve(makeResponse({ items: mockConversations, nextCursor: null }));
}); });
render(<MessagesPage />); render(<MessagesPage />);
apps/web/src/pages/Messages.tsx
+1 -1
View File
@@ -93,7 +93,7 @@ export function MessagesPage() {
useEffect(() => { useEffect(() => {
if (messages.length > 0) { if (messages.length > 0) {
messagesEndRef.current?.scrollIntoView({ behavior: "smooth" }); messagesEndRef.current?.scrollIntoView?.({ behavior: "smooth" });
} }
}, [messages]); }, [messages]);