From b3514626a17c5e242f703856448a9f6ef8497bff Mon Sep 17 00:00:00 2001 From: Lint Roller Date: Sun, 22 Mar 2026 11:42:32 +0000 Subject: [PATCH] fix(e2e): fix test failures after CTO review - Scope STAFF VIEW locator to impersonation-banner testid - Fix loading state test: unroute before setting delayed handler Co-Authored-By: Paperclip --- apps/e2e/tests/impersonation.spec.ts | 2 +- apps/e2e/tests/login.spec.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/e2e/tests/impersonation.spec.ts b/apps/e2e/tests/impersonation.spec.ts index 63801b2..ac246d8 100644 --- a/apps/e2e/tests/impersonation.spec.ts +++ b/apps/e2e/tests/impersonation.spec.ts @@ -36,7 +36,7 @@ test.describe("ImpersonationBanner", () => { test("banner displays when session is active", async ({ page }) => { await page.goto("/?sessionId=session-1"); await expect(page.locator("[data-testid=\"impersonation-banner\"]")).toBeVisible(); - await expect(page.getByText("STAFF VIEW")).toBeVisible(); + await expect(page.getByTestId("impersonation-banner").getByText("STAFF VIEW")).toBeVisible(); }); test("banner shows reason when session has reason", async ({ page }) => { diff --git a/apps/e2e/tests/login.spec.ts b/apps/e2e/tests/login.spec.ts index 4c826c7..6081f45 100644 --- a/apps/e2e/tests/login.spec.ts +++ b/apps/e2e/tests/login.spec.ts @@ -14,9 +14,9 @@ test.describe("DevLoginSelector", () => { }); test("shows loading state while fetching users", async ({ page }) => { + await page.unroute("**/api/dev/users"); await page.route("**/api/dev/users", async (route) => { - await page.waitForResponse((res) => res.url().includes("/api/dev/users")); - await new Promise((r) => setTimeout(r, 100)); + await new Promise((r) => setTimeout(r, 200)); await route.fulfill({ json: { staff: [], clients: [] } }); }); await page.goto("/login");