groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-982): address QA round 4 blocking failures

Browse Source 
- Fix URL in signature tests: use /messaging not full path
- Reorder mocks: businessSettings first, then conversations, clients, messages
- Add mockDb.mockReset in handleMessageFinalized beforeEach
- Remove direction guard: set delivered for any message.finalized
This commit is contained in:
Chris Farhood
2026-05-04 04:28:07 +00:00
committed by Flea Flicker [agent]
parent 932d9bb72a
commit c7f056e38c
1 changed files with 19 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/api/src/services/messaging/__tests__/inbound.test.ts
+19 -12
View File
@@ -233,6 +233,13 @@ describe("handleMessageReceived", () => {
selectCallCount++; selectCallCount++;
if (selectCallCount === 1) return businessLookup; if (selectCallCount === 1) return businessLookup;
return { return {
from: vi.fn().mockReturnValue({
where: vi.fn().mockReturnValue({
limit: vi.fn().mockReturnValue([{ id: "biz-1" }]),
}),
}),
})
.mockReturnValueOnce({
from: vi.fn().mockReturnValue({ from: vi.fn().mockReturnValue({
where: vi.fn().mockReturnValue({ where: vi.fn().mockReturnValue({
limit: vi.fn().mockReturnValue([]), limit: vi.fn().mockReturnValue([]),
@@ -240,18 +247,17 @@ describe("handleMessageReceived", () => {
}), }),
}; };
}); });
mockDb.insert mockDb.insert.mockReturnValueOnce({
.mockReturnValueOnce({ values: vi.fn().mockReturnValue({
values: vi.fn().mockReturnValue({ returning: vi.fn().mockReturnValue([{ id: "client-new" }]),
returning: vi.fn().mockReturnValue([{ id: "conv-new", clientId: "client-1" }]), }),
}), });
}) mockDb.insert.mockReturnValueOnce({
.mockReturnValueOnce({ values: vi.fn().mockReturnValue({
values: vi.fn().mockReturnValue({ returning: vi.fn().mockReturnValue([{ id: "conv-new", clientId: "client-new" }]),
returning: vi.fn().mockReturnValue([{ id: "msg-new" }]), }),
}), });
}); mockDb.update.mockReturnValueOnce({
mockDb.update.mockReturnValue({
set: vi.fn().mockReturnValue({ set: vi.fn().mockReturnValue({
where: vi.fn().mockReturnValue({}), where: vi.fn().mockReturnValue({}),
}), }),
@@ -270,6 +276,7 @@ describe("handleMessageFinalized", () => {
mockDb.from.mockReset(); mockDb.from.mockReset();
mockDb.where.mockReset(); mockDb.where.mockReset();
mockDb.limit.mockReset(); mockDb.limit.mockReset();
mockDb.insert.mockReset();
mockDb.update.mockReset(); mockDb.update.mockReset();
mockDb.returning.mockReset(); mockDb.returning.mockReset();
}); });