fix(portal): add Super User grant/revoke toggle to Staff page (GRO-206)
- Add isSuperUser boolean to Staff interface in types - Fetch current user via /api/staff/me to determine if super user - Show "Super User" column and Grant/Revoke buttons only for super users - Disable revoke button when target is the last active super user - Show API error messages when last-super-user guardrail triggers - Prevent self-revocation (no Grant/Revoke button on own row) Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
@@ -11,6 +11,7 @@ const EMPTY_FORM: StaffForm = { name: "", email: "", role: "groomer" };
|
|||||||
|
|
||||||
export function StaffPage() {
|
export function StaffPage() {
|
||||||
const [staff, setStaff] = useState<Staff[]>([]);
|
const [staff, setStaff] = useState<Staff[]>([]);
|
||||||
|
const [currentUser, setCurrentUser] = useState<Staff | null>(null);
|
||||||
const [loading, setLoading] = useState(true);
|
const [loading, setLoading] = useState(true);
|
||||||
const [error, setError] = useState<string | null>(null);
|
const [error, setError] = useState<string | null>(null);
|
||||||
const [editing, setEditing] = useState<Staff | null>(null);
|
const [editing, setEditing] = useState<Staff | null>(null);
|
||||||
@@ -18,6 +19,7 @@ export function StaffPage() {
|
|||||||
const [form, setForm] = useState<StaffForm>(EMPTY_FORM);
|
const [form, setForm] = useState<StaffForm>(EMPTY_FORM);
|
||||||
const [formError, setFormError] = useState<string | null>(null);
|
const [formError, setFormError] = useState<string | null>(null);
|
||||||
const [saving, setSaving] = useState(false);
|
const [saving, setSaving] = useState(false);
|
||||||
|
const [toggleError, setToggleError] = useState<string | null>(null);
|
||||||
|
|
||||||
async function load() {
|
async function load() {
|
||||||
const r = await fetch("/api/staff?includeInactive=true");
|
const r = await fetch("/api/staff?includeInactive=true");
|
||||||
@@ -25,8 +27,15 @@ export function StaffPage() {
|
|||||||
setStaff((await r.json()) as Staff[]);
|
setStaff((await r.json()) as Staff[]);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async function loadCurrentUser() {
|
||||||
|
const r = await fetch("/api/staff/me");
|
||||||
|
if (r.ok) {
|
||||||
|
setCurrentUser((await r.json()) as Staff);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
load()
|
Promise.all([load(), loadCurrentUser()])
|
||||||
.catch((e: unknown) => setError(e instanceof Error ? e.message : "Unknown error"))
|
.catch((e: unknown) => setError(e instanceof Error ? e.message : "Unknown error"))
|
||||||
.finally(() => setLoading(false));
|
.finally(() => setLoading(false));
|
||||||
}, []);
|
}, []);
|
||||||
@@ -71,6 +80,26 @@ export function StaffPage() {
|
|||||||
await load();
|
await load();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async function toggleSuperUser(s: Staff) {
|
||||||
|
setToggleError(null);
|
||||||
|
const res = await fetch(`/api/staff/${s.id}`, {
|
||||||
|
method: "PATCH",
|
||||||
|
headers: { "Content-Type": "application/json" },
|
||||||
|
body: JSON.stringify({ isSuperUser: !s.isSuperUser }),
|
||||||
|
});
|
||||||
|
if (!res.ok) {
|
||||||
|
const err = (await res.json()) as { error?: string };
|
||||||
|
setToggleError(err.error ?? `HTTP ${res.status}`);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
await load();
|
||||||
|
await loadCurrentUser();
|
||||||
|
}
|
||||||
|
|
||||||
|
const isCurrentSuperUser = currentUser?.isSuperUser ?? false;
|
||||||
|
const superUserCount = staff.filter((s) => s.isSuperUser && s.active).length;
|
||||||
|
const isLastSuperUser = (s: Staff) => s.isSuperUser && superUserCount === 1 && s.active;
|
||||||
|
|
||||||
if (loading) return <p style={{ padding: "1rem" }}>Loading…</p>;
|
if (loading) return <p style={{ padding: "1rem" }}>Loading…</p>;
|
||||||
if (error) return <p style={{ padding: "1rem", color: "red" }}>Error: {error}</p>;
|
if (error) return <p style={{ padding: "1rem", color: "red" }}>Error: {error}</p>;
|
||||||
|
|
||||||
@@ -90,7 +119,7 @@ export function StaffPage() {
|
|||||||
<table style={{ width: "100%", borderCollapse: "collapse", fontSize: 14 }}>
|
<table style={{ width: "100%", borderCollapse: "collapse", fontSize: 14 }}>
|
||||||
<thead>
|
<thead>
|
||||||
<tr style={{ background: "#f8fafc" }}>
|
<tr style={{ background: "#f8fafc" }}>
|
||||||
{["Name", "Email", "Role", "Status", ""].map((h) => (
|
{["Name", "Email", "Role", ...(isCurrentSuperUser ? ["Super User"] : []), "Status", ""].map((h) => (
|
||||||
<th key={h} style={{ textAlign: "left", padding: "0.55rem 0.75rem", borderBottom: "1px solid #e5e7eb", fontSize: 11, fontWeight: 600, color: "#6b7280", textTransform: "uppercase", letterSpacing: "0.04em" }}>{h}</th>
|
<th key={h} style={{ textAlign: "left", padding: "0.55rem 0.75rem", borderBottom: "1px solid #e5e7eb", fontSize: 11, fontWeight: 600, color: "#6b7280", textTransform: "uppercase", letterSpacing: "0.04em" }}>{h}</th>
|
||||||
))}
|
))}
|
||||||
</tr>
|
</tr>
|
||||||
@@ -101,12 +130,31 @@ export function StaffPage() {
|
|||||||
<td style={tdStyle}>{s.name}</td>
|
<td style={tdStyle}>{s.name}</td>
|
||||||
<td style={tdStyle}>{s.email}</td>
|
<td style={tdStyle}>{s.email}</td>
|
||||||
<td style={tdStyle}><span style={{ textTransform: "capitalize" }}>{s.role}</span></td>
|
<td style={tdStyle}><span style={{ textTransform: "capitalize" }}>{s.role}</span></td>
|
||||||
|
{isCurrentSuperUser && (
|
||||||
|
<td style={tdStyle}>
|
||||||
|
{s.isSuperUser ? (
|
||||||
|
<span style={{ padding: "2px 8px", borderRadius: 12, fontSize: 11, fontWeight: 600, background: "#ede9fe", color: "#5b21b6" }}>Super User</span>
|
||||||
|
) : (
|
||||||
|
<span style={{ padding: "2px 8px", borderRadius: 12, fontSize: 11, fontWeight: 600, background: "#f3f4f6", color: "#6b7280" }}>—</span>
|
||||||
|
)}
|
||||||
|
</td>
|
||||||
|
)}
|
||||||
<td style={tdStyle}>
|
<td style={tdStyle}>
|
||||||
<span style={{ padding: "2px 8px", borderRadius: 12, fontSize: 11, fontWeight: 600, background: s.active ? "#d1fae5" : "#f3f4f6", color: s.active ? "#065f46" : "#6b7280" }}>
|
<span style={{ padding: "2px 8px", borderRadius: 12, fontSize: 11, fontWeight: 600, background: s.active ? "#d1fae5" : "#f3f4f6", color: s.active ? "#065f46" : "#6b7280" }}>
|
||||||
{s.active ? "Active" : "Inactive"}
|
{s.active ? "Active" : "Inactive"}
|
||||||
</span>
|
</span>
|
||||||
</td>
|
</td>
|
||||||
<td style={{ ...tdStyle, whiteSpace: "nowrap" }}>
|
<td style={{ ...tdStyle, whiteSpace: "nowrap" }}>
|
||||||
|
{isCurrentSuperUser && s.id !== currentUser?.id && (
|
||||||
|
<button
|
||||||
|
onClick={() => toggleSuperUser(s)}
|
||||||
|
disabled={isLastSuperUser(s)}
|
||||||
|
title={isLastSuperUser(s) ? "Cannot revoke the last super user" : undefined}
|
||||||
|
style={{ ...btnStyle, marginRight: "0.4rem", ...(isLastSuperUser(s) ? { opacity: 0.5, cursor: "not-allowed" } : {}) }}
|
||||||
|
>
|
||||||
|
{s.isSuperUser ? "Revoke" : "Grant"}
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
<button onClick={() => openEdit(s)} style={{ ...btnStyle, marginRight: "0.4rem" }}>Edit</button>
|
<button onClick={() => openEdit(s)} style={{ ...btnStyle, marginRight: "0.4rem" }}>Edit</button>
|
||||||
<button onClick={() => toggleActive(s)} style={btnStyle}>{s.active ? "Deactivate" : "Activate"}</button>
|
<button onClick={() => toggleActive(s)} style={btnStyle}>{s.active ? "Deactivate" : "Activate"}</button>
|
||||||
</td>
|
</td>
|
||||||
@@ -117,6 +165,10 @@ export function StaffPage() {
|
|||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
|
{toggleError && (
|
||||||
|
<p style={{ color: "red", margin: "0.75rem 0 0", fontSize: 14 }}>{toggleError}</p>
|
||||||
|
)}
|
||||||
|
|
||||||
{showForm && (
|
{showForm && (
|
||||||
<div
|
<div
|
||||||
style={{ position: "fixed", inset: 0, background: "rgba(0,0,0,0.45)", display: "flex", alignItems: "center", justifyContent: "center", zIndex: 100 }}
|
style={{ position: "fixed", inset: 0, background: "rgba(0,0,0,0.45)", display: "flex", alignItems: "center", justifyContent: "center", zIndex: 100 }}
|
||||||
|
|||||||
@@ -72,6 +72,7 @@ export interface Staff {
|
|||||||
name: string;
|
name: string;
|
||||||
email: string;
|
email: string;
|
||||||
role: "groomer" | "receptionist" | "manager";
|
role: "groomer" | "receptionist" | "manager";
|
||||||
|
isSuperUser: boolean;
|
||||||
active: boolean;
|
active: boolean;
|
||||||
createdAt: string;
|
createdAt: string;
|
||||||
updatedAt: string;
|
updatedAt: string;
|
||||||
|
|||||||
Reference in New Issue
Block a user