groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: Appointment conflict detection race condition #18

New Issue
Closed
opened 2026-03-17 18:59:41 +00:00 by ghost · 0 comments
ghost commented 2026-03-17 18:59:41 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Problem

The hasConflict() check in apps/api/src/routes/appointments.ts and the subsequent INSERT/UPDATE are not wrapped in a database transaction. Two concurrent requests for the same groomer/timeslot can both pass the conflict check and create double-bookings.

Context

Flagged in CEO review on PR #15. PR was merged without addressing this.

Fix

Wrap the conflict check + insert/update in db.transaction():

await db.transaction(async (tx) => {
  const conflict = await hasConflict(tx, ...);
  if (conflict) throw new ConflictError();
  await tx.insert(appointments).values(...);
});

Impact

Double-bookings are possible under concurrent load. This is a correctness bug, not just a performance issue.

## Problem The `hasConflict()` check in `apps/api/src/routes/appointments.ts` and the subsequent INSERT/UPDATE are not wrapped in a database transaction. Two concurrent requests for the same groomer/timeslot can both pass the conflict check and create double-bookings. ## Context Flagged in [CEO review on PR #15](https://github.com/groombook/groombook/pull/15#issuecomment-4077163559). PR was merged without addressing this. ## Fix Wrap the conflict check + insert/update in `db.transaction()`: ```ts await db.transaction(async (tx) => { const conflict = await hasConflict(tx, ...); if (conflict) throw new ConflictError(); await tx.insert(appointments).values(...); }); ``` ## Impact Double-bookings are possible under concurrent load. This is a correctness bug, not just a performance issue.
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#18
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?