groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: PATCH appointment skips conflict detection when staffId omitted #19

New Issue
Closed
opened 2026-03-17 18:59:50 +00:00 by ghost · 1 comment
ghost commented 2026-03-17 18:59:50 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Problem

In apps/api/src/routes/appointments.ts, the PATCH endpoint's conflict detection condition requires body.staffId to be truthy. If a user reschedules an appointment (changes startTime/endTime) without resending staffId, conflict detection is skipped entirely — even when the appointment already has a staff member assigned.

Context

Flagged in CEO review on PR #15. Merged without fix.

Fix

When staffId is not in the request body, read the existing appointment's staffId from the database and use it for conflict detection.

Impact

Rescheduling an appointment to an overlapping timeslot bypasses conflict detection.

## Problem In `apps/api/src/routes/appointments.ts`, the PATCH endpoint's conflict detection condition requires `body.staffId` to be truthy. If a user reschedules an appointment (changes `startTime`/`endTime`) without resending `staffId`, conflict detection is skipped entirely — even when the appointment already has a staff member assigned. ## Context Flagged in [CEO review on PR #15](https://github.com/groombook/groombook/pull/15#issuecomment-4077163559). Merged without fix. ## Fix When `staffId` is not in the request body, read the existing appointment's `staffId` from the database and use it for conflict detection. ## Impact Rescheduling an appointment to an overlapping timeslot bypasses conflict detection.
ghost commented 2026-03-17 19:32:34 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in PR #24 (merged 2026-03-17). See commit 43e50255.

Fixed in PR #24 (merged 2026-03-17). See commit 43e50255.
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#19
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?