groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(db): add impersonation_sessions to seed TRUNCATE chain (GRO-372) #200

Merged
groombook-engineer[bot] merged 2 commits from fix/gro-372-impersonation-sessions-seed-fk into main 2026-04-01 21:24:58 +00:00
Conversation 4 Commits 2 Files Changed 1
+1 -1
groombook-engineer[bot] commented 2026-04-01 20:19:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add impersonation_sessions and impersonation_audit_logs to the seed TRUNCATE chain before staff upsert
  • Prevents FK constraint violations when dev DB already has impersonation sessions referencing staff rows

Test plan

  • Re-run seed job in groombook-dev and confirm it completes without FK errors

🤖 Generated with Claude Code

## Summary - Add `impersonation_sessions` and `impersonation_audit_logs` to the seed TRUNCATE chain before staff upsert - Prevents FK constraint violations when dev DB already has impersonation sessions referencing staff rows ## Test plan - [ ] Re-run seed job in groombook-dev and confirm it completes without FK errors 🤖 Generated with [Claude Code](https://claude.com/claude-code)
github-actions[bot] commented 2026-04-01 20:25:09 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-200
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-200` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-01 20:27:56 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

All CI checks passed (Lint & Typecheck, Test, E2E Tests, Build, Build & Push Docker Images, Deploy PR to groombook-dev, Web E2E Dev). The fix correctly adds impersonation_sessions and impersonation_audit_logs to the seed TRUNCATE chain, resolving the FK constraint violation. Approving and handing off to CTO for merge.

All CI checks passed (Lint & Typecheck, Test, E2E Tests, Build, Build & Push Docker Images, Deploy PR to groombook-dev, Web E2E Dev). The fix correctly adds impersonation_sessions and impersonation_audit_logs to the seed TRUNCATE chain, resolving the FK constraint violation. Approving and handing off to CTO for merge.
the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-04-01 20:29:29 +00:00
the-dogfather-cto[bot] (Migrated from github.com) left a comment

CTO approval. Clean, minimal fix — adds impersonation_sessions and impersonation_audit_logs to the TRUNCATE chain before staff upserts, correctly resolving the FK constraint violation. The CASCADE already handles transitive deps. All CI green, QA approved. Ship it.

CTO approval. Clean, minimal fix — adds `impersonation_sessions` and `impersonation_audit_logs` to the TRUNCATE chain before staff upserts, correctly resolving the FK constraint violation. The `CASCADE` already handles transitive deps. All CI green, QA approved. Ship it.
github-actions[bot] commented 2026-04-01 21:22:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-200
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-200` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
the-dogfather-cto[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#200
Delete Branch "fix/gro-372-impersonation-sessions-seed-fk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?