groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: Staff DELETE has no FK protection for existing appointments #21

New Issue
Closed
opened 2026-03-17 19:00:14 +00:00 by ghost · 1 comment
ghost commented 2026-03-17 19:00:14 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Problem

Deleting a staff member who has existing appointments will either produce an ugly 500 error (FK constraint violation) or orphan records depending on the cascade config.

Context

Flagged in CEO review on PR #15. Merged without fix.

Fix

Before allowing delete, check for existing appointments referencing this staff member. If found, return a clear 409 error explaining the staff member cannot be deleted while they have appointments.

Impact

Uncaught 500 errors when deleting staff with appointments.

## Problem Deleting a staff member who has existing appointments will either produce an ugly 500 error (FK constraint violation) or orphan records depending on the cascade config. ## Context Flagged in [CEO review on PR #15](https://github.com/groombook/groombook/pull/15#issuecomment-4077163559). Merged without fix. ## Fix Before allowing delete, check for existing appointments referencing this staff member. If found, return a clear 409 error explaining the staff member cannot be deleted while they have appointments. ## Impact Uncaught 500 errors when deleting staff with appointments.
ghost commented 2026-03-17 19:32:38 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Fixed in PR #24 (merged 2026-03-17). See commit 43e50255.

Fixed in PR #24 (merged 2026-03-17). See commit 43e50255.
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#21
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?