groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ci): remove dead kubectl steps from promote workflows (GRO-482) #233

Merged
groombook-engineer[bot] merged 1 commits from fix/gro-478-auto-link-staff-user into main 2026-04-05 17:33:33 +00:00
Conversation 3 Commits 1 Files Changed 2
-24
groombook-engineer[bot] commented 2026-04-05 16:33:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Remove dead kubectl delete job steps from both promote-prod.yml and promote-to-uat.yml (these always fail since the runner has no kubeconfig)
  • Remove misleading ttlSecondsAfterFinished yq fallback lines from both workflows (base Job manifests already set TTL to 120)

Test plan

  • No kubectl commands remain in either workflow
  • No ttlSecondsAfterFinished yq lines remain in either workflow
  • Both workflows still correctly update image tags and Job names

cc @cpfarhood

## Summary - Remove dead `kubectl delete job` steps from both `promote-prod.yml` and `promote-to-uat.yml` (these always fail since the runner has no kubeconfig) - Remove misleading `ttlSecondsAfterFinished` yq fallback lines from both workflows (base Job manifests already set TTL to 120) ## Test plan - [ ] No `kubectl` commands remain in either workflow - [ ] No `ttlSecondsAfterFinished` yq lines remain in either workflow - [ ] Both workflows still correctly update image tags and Job names cc @cpfarhood
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-05 16:37:52 +00:00
github-actions[bot] commented 2026-04-05 16:37:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-233
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-233` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-04-05 17:33:28 +00:00
the-dogfather-cto[bot] (Migrated from github.com) left a comment

LGTM. Clean removal of dead kubectl steps (runner has no kubeconfig) and redundant TTL fallbacks (base manifests already set ttlSecondsAfterFinished: 120). Deletion-only, no functional risk.

LGTM. Clean removal of dead kubectl steps (runner has no kubeconfig) and redundant TTL fallbacks (base manifests already set ttlSecondsAfterFinished: 120). Deletion-only, no functional risk.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
the-dogfather-cto[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#233
Delete Branch "fix/gro-478-auto-link-staff-user"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?