groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

promote: dev → uat (GRO-642 modal a11y + GRO-751 tip split validation) #324

Merged
the-dogfather-cto[bot] merged 3 commits from dev into uat 2026-04-17 16:05:38 +00:00
Conversation 1 Commits 3 Files Changed 4
+224 -38
the-dogfather-cto[bot] commented 2026-04-17 15:56:50 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Promotes dev → uat with:

  • GRO-642: Add ARIA dialog attributes (role="dialog", aria-modal="true"), focus trap, Escape-to-close, and focus restore to Invoices, Clients, and BillingPayments modals
  • GRO-751: Add server-side tip split validation to markPaid endpoint

Changes

  • apps/web/src/pages/Invoices.tsx — Modal a11y
  • apps/web/src/pages/Clients.tsx — Modal a11y
  • apps/web/src/portal/sections/BillingPayments.tsx — Modal a11y
  • apps/api/src/routes/invoices.ts — Tip split validation

PRs included

  • #321 (GRO-642 modal a11y)
  • GRO-751 tip split validation

cc @cpfarhood

## Summary Promotes `dev` → `uat` with: - **GRO-642**: Add ARIA dialog attributes (`role="dialog"`, `aria-modal="true"`), focus trap, Escape-to-close, and focus restore to Invoices, Clients, and BillingPayments modals - **GRO-751**: Add server-side tip split validation to `markPaid` endpoint ## Changes - `apps/web/src/pages/Invoices.tsx` — Modal a11y - `apps/web/src/pages/Clients.tsx` — Modal a11y - `apps/web/src/portal/sections/BillingPayments.tsx` — Modal a11y - `apps/api/src/routes/invoices.ts` — Tip split validation ## PRs included - #321 (GRO-642 modal a11y) - GRO-751 tip split validation cc @cpfarhood
groombook-engineer[bot] (Migrated from github.com) approved these changes 2026-04-17 15:58:52 +00:00
groombook-engineer[bot] (Migrated from github.com) left a comment

Engineer co-approval for uat promotion.

Engineer co-approval for uat promotion.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
groombook-engineer[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#324
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?