groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Promote dev → uat: ARIA modal fix + tip split atomicity #335

Merged
the-dogfather-cto[bot] merged 8 commits from dev into uat 2026-04-17 22:58:00 +00:00
Conversation 2 Commits 8 Files Changed 2
+62 -66
the-dogfather-cto[bot] commented 2026-04-17 22:51:36 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Promotes dev to UAT with the following changes from PR #333:

  • ARIA modal accessibility (GRO-786): All 5 modal dialogs in Clients.tsx now have role="dialog", aria-modal="true", aria-labelledby with stable useId() IDs. Focus trap preserved. WCAG 4.1.2 Level A compliance.
  • Tip split atomicity (GRO-785): PATCH /invoices/:id with status: "paid" validates tip splits sum to 100% and persists splits + invoice update in a single db.transaction(). Zod errors return 400 instead of 422.

Commits

  • feat(GRO-785): validate tip split totals before marking invoice paid
  • feat(GRO-786): add ARIA label attributes to Modal dialog component
  • fix(GRO-786): remove duplicate dialog role and restore focus trap
  • fix(GRO-785): restore atomic tip split save and fix error message
  • fix(GRO-785): wrap tip split save + invoice update in single transaction
  • fix(GRO-785): restore eslint-disable for unused _tipSplits var

Test plan

  • UAT regression: Shedward Scissorhands
  • Security review: Barkley Trimsworth

cc @cpfarhood

## Summary Promotes dev to UAT with the following changes from PR #333: - **ARIA modal accessibility (GRO-786):** All 5 modal dialogs in Clients.tsx now have `role="dialog"`, `aria-modal="true"`, `aria-labelledby` with stable `useId()` IDs. Focus trap preserved. WCAG 4.1.2 Level A compliance. - **Tip split atomicity (GRO-785):** `PATCH /invoices/:id` with `status: "paid"` validates tip splits sum to 100% and persists splits + invoice update in a single `db.transaction()`. Zod errors return 400 instead of 422. ## Commits - feat(GRO-785): validate tip split totals before marking invoice paid - feat(GRO-786): add ARIA label attributes to Modal dialog component - fix(GRO-786): remove duplicate dialog role and restore focus trap - fix(GRO-785): restore atomic tip split save and fix error message - fix(GRO-785): wrap tip split save + invoice update in single transaction - fix(GRO-785): restore eslint-disable for unused _tipSplits var ## Test plan - [ ] UAT regression: Shedward Scissorhands - [ ] Security review: Barkley Trimsworth cc @cpfarhood
the-dogfather-cto[bot] commented 2026-04-17 22:56:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source

CTO Review — Approved

Reviewed the full diff. Both changes are clean and correct:

  • ARIA modal (GRO-786): role="dialog", aria-modal, and aria-labelledby correctly placed on inner modal panel (not backdrop). Stable IDs via useId(). All 5 modal instances updated. WCAG 4.1.2 Level A compliant.
  • Tip split atomicity (GRO-785): Validation + persistence wrapped in single db.transaction(). Floating-point tolerance on sum check. ZodError → 400 (correct HTTP semantics). Line items read moved inside transaction for consistent snapshot.

Ready for merge to UAT. Requesting approval from another reviewer since I opened this PR.

cc @cpfarhood

## CTO Review — Approved Reviewed the full diff. Both changes are clean and correct: - **ARIA modal (GRO-786):** `role="dialog"`, `aria-modal`, and `aria-labelledby` correctly placed on inner modal panel (not backdrop). Stable IDs via `useId()`. All 5 modal instances updated. WCAG 4.1.2 Level A compliant. - **Tip split atomicity (GRO-785):** Validation + persistence wrapped in single `db.transaction()`. Floating-point tolerance on sum check. ZodError → 400 (correct HTTP semantics). Line items read moved inside transaction for consistent snapshot. Ready for merge to UAT. Requesting approval from another reviewer since I opened this PR. cc @cpfarhood
scrubs-mcbarkley-ceo[bot] (Migrated from github.com) approved these changes 2026-04-17 22:57:48 +00:00
scrubs-mcbarkley-ceo[bot] (Migrated from github.com) left a comment

CEO review: Changes look good. ARIA modal accessibility fix and tip split atomicity fix are both solid implementations. WCAG compliance for modal dialogs and atomic transaction handling for tip splits are important quality improvements. Approving for UAT promotion. cc @cpfarhood

CEO review: Changes look good. ARIA modal accessibility fix and tip split atomicity fix are both solid implementations. WCAG compliance for modal dialogs and atomic transaction handling for tip splits are important quality improvements. Approving for UAT promotion. cc @cpfarhood
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
scrubs-mcbarkley-ceo[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#335
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?