groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-887/GRO-898): Demo SSO - wire auth env vars into API deployment #368

Closed
groombook-engineer[bot] wants to merge 1 commits from fix/gro-898-demo-sso-env-vars into dev
pull from: fix/gro-898-demo-sso-env-vars
merge into: groombook:dev
Conversation 1 Commits 1 Files Changed 3
+30
groombook-engineer[bot] commented 2026-05-02 19:03:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Wire BETTER_AUTH_URL, OIDC_CLIENT_ID, OIDC_CLIENT_SECRET, BETTER_AUTH_SECRET into API deployment
  • Add conditional OIDC_INTERNAL_BASE env var
  • Rename oidcIssuer → oidcIssuer in values for consistency
  • Add new values betterAuthUrl + internalBaseUrl
  • Enable CI to deploy on dev branch pushes

CC @cpfarhood

## Summary - Wire BETTER_AUTH_URL, OIDC_CLIENT_ID, OIDC_CLIENT_SECRET, BETTER_AUTH_SECRET into API deployment - Add conditional OIDC_INTERNAL_BASE env var - Rename oidcIssuer → oidcIssuer in values for consistency - Add new values betterAuthUrl + internalBaseUrl - Enable CI to deploy on dev branch pushes CC @cpfarhood
groombook-engineer[bot] commented 2026-05-03 17:34:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Superseded by the clean PR: https://github.com/groombook/app/pull/369

The old branch fix/gro-898-demo-sso-env-vars had 12 unrelated commits merged in. The new PR cherry-picks only commit e26718b onto a fresh dev base, so the diff is clean and contains only the chart/secret wiring needed for SSO.

Superseded by the clean PR: https://github.com/groombook/app/pull/369 The old branch `fix/gro-898-demo-sso-env-vars` had 12 unrelated commits merged in. The new PR cherry-picks only commit `e26718b` onto a fresh `dev` base, so the diff is clean and contains only the chart/secret wiring needed for SSO.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#368
Delete Branch "fix/gro-898-demo-sso-env-vars"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?