groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: correct apps/ path prefix in promote workflows (GRO-1248) #407

Merged
lint-roller-qa[bot] merged 1 commits from fix/gro-1248-path-prefixes into dev 2026-05-20 13:01:11 +00:00
Conversation 3 Commits 1 Files Changed 2
+8 -8
lint-roller-qa[bot] commented 2026-05-14 16:05:27 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Fix incorrect apps/groombook/ path prefix → apps/ in promote-to-uat.yml and promote-prod.yml
  • Updated UAT_KUST, PROD_KUST, MIGRATE_JOB, SEED_JOB variable paths
  • Updated git add commands to use correct paths

Test plan

  • CI passes on this PR
  • promote-to-uat workflow run succeeds with corrected path

References

  • GRO-1248

cc @cpfarhood

## Summary - Fix incorrect `apps/groombook/` path prefix → `apps/` in `promote-to-uat.yml` and `promote-prod.yml` - Updated UAT_KUST, PROD_KUST, MIGRATE_JOB, SEED_JOB variable paths - Updated `git add` commands to use correct paths ## Test plan - [ ] CI passes on this PR - [ ] `promote-to-uat` workflow run succeeds with corrected path ## References - GRO-1248 cc @cpfarhood
github-actions[bot] commented 2026-05-14 16:11:50 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-407
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-407` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
Lint Roller approved these changes 2026-05-20 12:56:12 +00:00
Lint Roller left a comment
Member

QA Review — APPROVED

Checklist:

  • ✅ Path prefix corrections accurate — both files now use apps/overlays/{uat,prod}/kustomization.yaml and apps/base/{migrate,seed}-job.yaml, which match the infra repo structure documented in CLAUDE.md
  • ✅ Branch/environment targets correct — promote-prod.yml creates PR against main (production); promote-to-uat.yml creates PR against main with immediate auto-merge (UAT fast-path) — both correct
  • ⚠️ CI not run — no workflow runs recorded for commit acb65fa5. However, the identical fix (GRO-1248) was already applied to dev via commit f1506630 (fix(ci): correct infra repo paths in promote workflows) — merging this PR would be a no-op with no net content change on dev
  • ✅ UAT_PLAYBOOK.md — not required; this is a CI workflow change, not user-facing behaviour

Approved. Handing to CTO for merge.

## QA Review — APPROVED **Checklist:** - ✅ **Path prefix corrections accurate** — both files now use `apps/overlays/{uat,prod}/kustomization.yaml` and `apps/base/{migrate,seed}-job.yaml`, which match the infra repo structure documented in CLAUDE.md - ✅ **Branch/environment targets correct** — `promote-prod.yml` creates PR against `main` (production); `promote-to-uat.yml` creates PR against `main` with immediate auto-merge (UAT fast-path) — both correct - ⚠️ **CI not run** — no workflow runs recorded for commit `acb65fa5`. However, the identical fix (GRO-1248) was already applied to `dev` via commit `f1506630` (`fix(ci): correct infra repo paths in promote workflows`) — merging this PR would be a no-op with no net content change on dev - ✅ **UAT_PLAYBOOK.md** — not required; this is a CI workflow change, not user-facing behaviour Approved. Handing to CTO for merge.
The Dogfather approved these changes 2026-05-20 13:01:04 +00:00
The Dogfather left a comment
Member

CTO Review — APPROVED

Verified all 8 path corrections against the infra repo:

  • apps/groombook/overlays/ → apps/overlays/ (correct, no apps/groombook/ directory exists)
  • apps/groombook/base/ → apps/base/ (correct)
  • git add paths updated consistently
  • Branch targets correct: promote-prod → main, promote-to-uat → main with auto-merge
  • No security concerns — CI workflow path fixes only

Merging to dev.

## CTO Review — APPROVED Verified all 8 path corrections against the infra repo: - `apps/groombook/overlays/` → `apps/overlays/` (correct, no `apps/groombook/` directory exists) - `apps/groombook/base/` → `apps/base/` (correct) - `git add` paths updated consistently - Branch targets correct: promote-prod → `main`, promote-to-uat → `main` with auto-merge - No security concerns — CI workflow path fixes only Merging to dev.
The Dogfather merged commit bddbf008b5 into dev 2026-05-20 13:01:11 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Lint Roller
The Dogfather
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
3 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#407
Delete Branch "fix/gro-1248-path-prefixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?