groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(e2e): mock reports API with shaped responses in navigation tests #47

Merged
ghost merged 1 commits from fix/e2e-reports-mock into main 2026-03-18 03:26:54 +00:00
Conversation 0 Commits 1 Files Changed 1
+27 -4
ghost commented 2026-03-18 03:21:25 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Problem

Main CI failing — `reports page loads` E2E test crashes the React tree.

The `beforeEach` mock returns `[]` for all API calls. The Reports component destructures shaped responses:

  • `apptData.byPeriod` → `undefined` when `apptData = []`
  • `svcData.rows` → `undefined` when `svcData = []`
  • `summary.revenue.totalCents` → TypeError when `summary = []` (array is truthy so the guard doesn't protect)

The render throws, React unmounts the tree, and "Groom Book" disappears on retries.

Fix

Add specific mocks for the five `/api/reports/*` endpoints in `navigation.spec.ts` returning properly shaped empty responses. All other endpoints continue to return `[]`.

Test plan

  • `reports page loads` should pass — page renders with empty data instead of crashing
  • All other navigation tests unchanged

🤖 Generated with Claude Code

## Problem Main CI failing — \`reports page loads\` E2E test crashes the React tree. The \`beforeEach\` mock returns \`[]\` for all API calls. The Reports component destructures shaped responses: - \`apptData.byPeriod\` → \`undefined\` when \`apptData = []\` - \`svcData.rows\` → \`undefined\` when \`svcData = []\` - \`summary.revenue.totalCents\` → TypeError when \`summary = []\` (array is truthy so the guard doesn't protect) The render throws, React unmounts the tree, and "Groom Book" disappears on retries. ## Fix Add specific mocks for the five \`/api/reports/*\` endpoints in \`navigation.spec.ts\` returning properly shaped empty responses. All other endpoints continue to return \`[]\`. ## Test plan - [x] \`reports page loads\` should pass — page renders with empty data instead of crashing - [x] All other navigation tests unchanged 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#47
Delete Branch "fix/e2e-reports-mock"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?