feat: client disable/deletion with soft-delete #69

Merged

ghost merged 2 commits from feature/client-soft-delete into main 2026-03-19 20:03:18 +00:00

Conversation 0 Commits 2 Files Changed 8

+212 -24

ghost commented 2026-03-19 17:15:41 +00:00 (Migrated from github.com)

Copy Link

Copy Source

Summary

Implements client soft-delete as requested in #67. Key changes:

• Schema: New client_status enum (active/disabled) and disabled_at timestamp on the clients table
• API: GET /api/clients defaults to active-only (use ?includeDisabled=true to show all); PATCH accepts status field; DELETE requires ?confirm=true
• Booking: Public booking flow skips disabled clients when looking up by email
• Frontend: "Disable client" is now the primary action (replaces "Delete"); "Show disabled clients" checkbox in sidebar; disabled clients show a badge; permanent deletion requires typing the client name to confirm; re-enable button for disabled clients

Closes #67

Test plan

• Verify migration runs cleanly on a fresh DB
• Confirm GET /api/clients returns only active clients by default
• Confirm GET /api/clients?includeDisabled=true returns all clients
• Disable a client via PATCH and verify they disappear from the default list
• Re-enable a disabled client and verify they reappear
• Attempt DELETE without ?confirm=true and verify 400 response
• Confirm disabled clients cannot book via the public booking flow
• E2E tests pass with updated mock data
• Verify disabled clients still appear in reports

🤖 Generated with Claude Code

## Summary Implements client soft-delete as requested in #67. Key changes: - **Schema**: New `client_status` enum (`active`/`disabled`) and `disabled_at` timestamp on the `clients` table - **API**: `GET /api/clients` defaults to active-only (use `?includeDisabled=true` to show all); `PATCH` accepts `status` field; `DELETE` requires `?confirm=true` - **Booking**: Public booking flow skips disabled clients when looking up by email - **Frontend**: "Disable client" is now the primary action (replaces "Delete"); "Show disabled clients" checkbox in sidebar; disabled clients show a badge; permanent deletion requires typing the client name to confirm; re-enable button for disabled clients Closes #67 ## Test plan - [ ] Verify migration runs cleanly on a fresh DB - [ ] Confirm `GET /api/clients` returns only active clients by default - [ ] Confirm `GET /api/clients?includeDisabled=true` returns all clients - [ ] Disable a client via PATCH and verify they disappear from the default list - [ ] Re-enable a disabled client and verify they reappear - [ ] Attempt DELETE without `?confirm=true` and verify 400 response - [ ] Confirm disabled clients cannot book via the public booking flow - [ ] E2E tests pass with updated mock data - [ ] Verify disabled clients still appear in reports 🤖 Generated with [Claude Code](https://claude.com/claude-code)

This repo is archived. You cannot comment on pull requests.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

feature

New feature

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)

No Assignees

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/app#69