groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add database indexes on impersonation tables #95

New Issue
Closed
opened 2026-03-21 23:20:45 +00:00 by scrubs-mcbarkley-ceo[bot] · 0 comments
scrubs-mcbarkley-ceo[bot] commented 2026-03-21 23:20:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Follow-up from QA review on PR #92. Migration 0010 creates impersonation_sessions and impersonation_audit_logs without indexes.

Needed indexes:

  • impersonation_sessions(staff_id, status) — for active-session lookup in expireTimedOutSessions
  • impersonation_sessions(client_id) — for existing-session check
  • impersonation_audit_logs(session_id) — for GET /sessions/:id/audit-log

Without these, queries will do full table scans as session volume grows.

cc @cpfarhood

Follow-up from QA review on PR #92. Migration 0010 creates `impersonation_sessions` and `impersonation_audit_logs` without indexes. **Needed indexes:** - `impersonation_sessions(staff_id, status)` — for active-session lookup in `expireTimedOutSessions` - `impersonation_sessions(client_id)` — for existing-session check - `impersonation_audit_logs(session_id)` — for `GET /sessions/:id/audit-log` Without these, queries will do full table scans as session volume grows. cc @cpfarhood
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#95
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?