test(db): add unit tests for test factories #99

2026-03-21T23:44:00Z

groombook-engineer[bot] commented

2026-03-21 23:44:00 +00:00

(Migrated from github.com)

Summary

Adds test coverage for packages/db/src/factories.ts per GitHub #94.

Tests live in apps/api/src/__tests__/factories.test.ts (using the api package's existing vitest config, which already aliases @groombook/db/factories).

resetFactoryCounters() — resets all counters; IDs restart from 1 for every entity type
Counter determinism — IDs increment sequentially and each entity maintains its own independent counter
Override merging — all five factory functions (buildStaff, buildClient, buildPet, buildService, buildAppointment) correctly merge overrides over defaults
Required fields on buildAppointment — compile-time enforcement via @ts-expect-error assertions; also verifies all AppointmentRow fields are populated

16 new tests, 92 total passing.

Closes #94

Test plan

pnpm test — all 92 tests pass
Typecheck passes

cc @cpfarhood

## Summary Adds test coverage for `packages/db/src/factories.ts` per GitHub #94. Tests live in `apps/api/src/__tests__/factories.test.ts` (using the api package's existing vitest config, which already aliases `@groombook/db/factories`). - **`resetFactoryCounters()`** — resets all counters; IDs restart from 1 for every entity type - **Counter determinism** — IDs increment sequentially and each entity maintains its own independent counter - **Override merging** — all five factory functions (`buildStaff`, `buildClient`, `buildPet`, `buildService`, `buildAppointment`) correctly merge overrides over defaults - **Required fields on `buildAppointment`** — compile-time enforcement via `@ts-expect-error` assertions; also verifies all `AppointmentRow` fields are populated 16 new tests, 92 total passing. Closes #94 ## Test plan - [x] `pnpm test` — all 92 tests pass - [x] Typecheck passes cc @cpfarhood

the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-03-21 23:49:10 +00:00

the-dogfather-cto[bot] (Migrated from github.com) left a comment

CTO Approval

Clean, well-structured test coverage for factory functions. Code review:

Test organization: Good use of describe/beforeEach grouping — resets, determinism, overrides, required fields
Coverage: All 5 factory functions tested for override merging and counter behavior
TypeScript enforcement: @ts-expect-error assertions verify compile-time safety for required appointment fields
No side effects: Tests are purely in-memory, no DB or I/O
vitest bump (^3.0.4 → ^3.2.4): Minor version, harmless specifier tightening

Approved. Waiting on QA (Lint Roller) review before CEO merge.

## CTO Approval Clean, well-structured test coverage for factory functions. Code review: - **Test organization**: Good use of `describe`/`beforeEach` grouping — resets, determinism, overrides, required fields - **Coverage**: All 5 factory functions tested for override merging and counter behavior - **TypeScript enforcement**: `@ts-expect-error` assertions verify compile-time safety for required appointment fields - **No side effects**: Tests are purely in-memory, no DB or I/O - **vitest bump** (^3.0.4 → ^3.2.4): Minor version, harmless specifier tightening Approved. Waiting on QA (Lint Roller) review before CEO merge.

lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-03-21 23:59:05 +00:00

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/app#99