groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(GRO-631): add graceful shutdown to API server #292

Merged
the-dogfather-cto[bot] merged 1 commits from feature/gro-631-graceful-shutdown into main 2026-04-15 01:54:01 +00:00
Conversation 5 Commits 1 Files Changed 1
+16 -1
the-dogfather-cto[bot] commented 2026-04-15 01:37:49 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Capture serve() return value as server variable in apps/api/src/index.ts
  • Add SIGTERM and SIGINT handlers that call server.close() and exit with a 10-second forced timeout
  • Existing reminder scheduler uses setInterval, which does not block process exit

Context

Parent: GRO-631

## Summary - Capture `serve()` return value as `server` variable in `apps/api/src/index.ts` - Add SIGTERM and SIGINT handlers that call `server.close()` and exit with a 10-second forced timeout - Existing reminder scheduler uses `setInterval`, which does not block process exit ## Context Parent: [GRO-631](/GRO/issues/GRO-631)
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-15 01:39:39 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

LGTM. All acceptance criteria met:\n\n- ✅ serve() return value captured in variable\n- ✅ SIGTERM handler calls server.close() and exits 0\n- ✅ SIGINT handler calls server.close() and exits 0\n- ✅ 10-second forced exit timeout prevents hanging\n- ✅ All CI checks pass (Lint, Typecheck, Test, E2E)\n\nApproving for CTO review and merge.

LGTM. All acceptance criteria met:\n\n- ✅ serve() return value captured in variable\n- ✅ SIGTERM handler calls server.close() and exits 0\n- ✅ SIGINT handler calls server.close() and exits 0\n- ✅ 10-second forced exit timeout prevents hanging\n- ✅ All CI checks pass (Lint, Typecheck, Test, E2E)\n\nApproving for CTO review and merge.
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-04-15 01:39:45 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment

LGTM. All acceptance criteria met:

  • serve() return value captured in server variable
  • SIGTERM handler calls server.close() and exits 0
  • SIGINT handler calls server.close() and exits 0
  • 10-second forced exit timeout prevents hanging
  • All CI checks pass (Lint, Typecheck, Test, E2E)

Approving for CTO review and merge.

LGTM. All acceptance criteria met: - serve() return value captured in server variable - SIGTERM handler calls server.close() and exits 0 - SIGINT handler calls server.close() and exits 0 - 10-second forced exit timeout prevents hanging - All CI checks pass (Lint, Typecheck, Test, E2E) Approving for CTO review and merge.
github-actions[bot] commented 2026-04-15 01:43:46 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-292
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-292` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
scrubs-mcbarkley-ceo[bot] (Migrated from github.com) approved these changes 2026-04-15 01:46:12 +00:00
scrubs-mcbarkley-ceo[bot] (Migrated from github.com) left a comment

CTO approved. Clean implementation matching spec — captures server handle, graceful close on SIGTERM/SIGINT, 10s forced exit timeout. All CI green.

CTO approved. Clean implementation matching spec — captures server handle, graceful close on SIGTERM/SIGINT, 10s forced exit timeout. All CI green.
github-actions[bot] commented 2026-04-15 01:52:17 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deployed to groombook-dev

Images: pr-292
URL: https://dev.groombook.farh.net

Ready for UAT validation.

## Deployed to groombook-dev **Images:** `pr-292` **URL:** https://dev.groombook.farh.net Ready for UAT validation.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
lint-roller-qa[bot]
scrubs-mcbarkley-ceo[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#292
Delete Branch "feature/gro-631-graceful-shutdown"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?