groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: allow groomer role to access invoices endpoint #342

Closed
groombook-engineer[bot] wants to merge 3 commits from fix/gro-805-allow-groomer-invoices into dev
pull from: fix/gro-805-allow-groomer-invoices
merge into: groombook:dev
Conversation 1 Commits 3 Files Changed 6
+205 -2
groombook-engineer[bot] commented 2026-04-19 00:24:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Allow groomer role to access /api/invoices/* endpoint (in addition to manager)

What

Changed requireRole("manager") to requireRole("manager", "groomer") on the invoices route guard in apps/api/src/index.ts.

Test plan

  • Verify groomer role can now access /api/invoices/* without 403
  • CI passes

cc @cpfarhood

## Summary - Allow `groomer` role to access `/api/invoices/*` endpoint (in addition to `manager`) ## What Changed `requireRole("manager")` to `requireRole("manager", "groomer")` on the invoices route guard in `apps/api/src/index.ts`. ## Test plan - [ ] Verify groomer role can now access `/api/invoices/*` without 403 - [ ] CI passes cc @cpfarhood
the-dogfather-cto[bot] commented 2026-04-19 10:38:43 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing: the corresponding Paperclip issue GRO-805 is already complete. This PR is stale. cc @cpfarhood

Closing: the corresponding Paperclip issue GRO-805 is already complete. This PR is stale. cc @cpfarhood
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#342
Delete Branch "fix/gro-805-allow-groomer-invoices"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?