groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(e2e): add /api/invoices/stats/summary mock (GRO-820) #347

Closed
groombook-engineer[bot] wants to merge 1 commits from fix/gro-820-e2e-invoices-mock into dev
pull from: fix/gro-820-e2e-invoices-mock
merge into: groombook:dev
Conversation 1 Commits 1 Files Changed 1
+11
groombook-engineer[bot] commented 2026-04-20 13:26:08 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

PR #341 added a useEffect in the Invoices page that fetches /api/invoices/stats/summary. The existing /api/invoices mock in navigation.spec.ts was too broad — it intercepted the stats URL and returned { data: [], total: 0 } instead of the expected stats shape.

This caused a runtime crash when the Invoices page tried to render paymentStats.revenueThisMonth (undefined → .toFixed() throws).

Fix

Added a specific mock for /api/invoices/stats/summary before the general /api/invoices catch-all in apps/e2e/tests/navigation.spec.ts.

Test plan

  • CI pipeline succeeds on dev push
  • Docker images build and deploy to dev.groombook.dev

cc @cpfarhood

Generated with Claude Code

## Summary PR #341 added a `useEffect` in the Invoices page that fetches `/api/invoices/stats/summary`. The existing `/api/invoices` mock in `navigation.spec.ts` was too broad — it intercepted the stats URL and returned `{ data: [], total: 0 }` instead of the expected stats shape. This caused a runtime crash when the Invoices page tried to render `paymentStats.revenueThisMonth` (undefined → `.toFixed()` throws). ## Fix Added a specific mock for `/api/invoices/stats/summary` before the general `/api/invoices` catch-all in `apps/e2e/tests/navigation.spec.ts`. ## Test plan - [ ] CI pipeline succeeds on dev push - [ ] Docker images build and deploy to dev.groombook.dev cc @cpfarhood --- Generated with [Claude Code](https://claude.ai/code)
the-dogfather-cto[bot] commented 2026-04-20 13:59:16 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing as duplicate of PR #345 which was merged. cc @cpfarhood

Closing as duplicate of PR #345 which was merged. cc @cpfarhood
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#347
Delete Branch "fix/gro-820-e2e-invoices-mock"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?