groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(GRO-106): STOP/HELP compliance + consent log #396

Closed
groombook-engineer[bot] wants to merge 1 commits from feat/GRO-106-stop-help into dev
pull from: feat/GRO-106-stop-help
merge into: groombook:dev
Conversation 1 Commits 1 Files Changed 3
+310 -1
groombook-engineer[bot] commented 2026-05-14 04:59:21 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add detectKeyword() — trims + uppercases message body and classifies as opt_in, opt_out, or help based on carrier-mandated keywords
  • Add handleConsentKeyword() — logs messageConsentEvents, updates clients.smsOptIn/smsOptOutDate/smsConsentDate with idempotency
  • Wire keyword detection into handleMessageReceived() so inbound STOP/START/HELP auto-reply and update consent state
  • 25-unit test suite covering all keywords, case insensitivity, whitespace tolerance, idempotency, and help state preservation

Test plan

  • npx vitest run apps/api/src/services/messaging/__tests__/consent.test.ts — 25/25 pass
  • Inbound STOP → clients.smsOptIn=false, consent event logged, auto-reply sent
  • Inbound START after opt-out → smsOptIn=true, consent event, confirmation reply
  • Existing sendMessage() still returns { suppressed: true } when smsOptIn=false (no regression)
  • HELP does not change opt-in state

🤖 Generated with Claude Code

## Summary - Add `detectKeyword()` — trims + uppercases message body and classifies as `opt_in`, `opt_out`, or `help` based on carrier-mandated keywords - Add `handleConsentKeyword()` — logs `messageConsentEvents`, updates `clients.smsOptIn`/`smsOptOutDate`/`smsConsentDate` with idempotency - Wire keyword detection into `handleMessageReceived()` so inbound STOP/START/HELP auto-reply and update consent state - 25-unit test suite covering all keywords, case insensitivity, whitespace tolerance, idempotency, and help state preservation ## Test plan - [x] `npx vitest run apps/api/src/services/messaging/__tests__/consent.test.ts` — 25/25 pass - [x] Inbound STOP → `clients.smsOptIn=false`, consent event logged, auto-reply sent - [x] Inbound START after opt-out → `smsOptIn=true`, consent event, confirmation reply - [x] Existing `sendMessage()` still returns `{ suppressed: true }` when `smsOptIn=false` (no regression) - [x] HELP does not change opt-in state 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Scrubs McBarkley commented 2026-05-20 12:10:25 +00:00
Owner
Copy Link
Copy Source

Closing as superseded by PR #410 (feat/GRO-106-stop-help-v2), which is the updated version of this STOP/HELP compliance work with a full 25-unit test suite. Closing per org-wide PR backlog cleanup (GRO-1355).

Closing as superseded by PR #410 (feat/GRO-106-stop-help-v2), which is the updated version of this STOP/HELP compliance work with a full 25-unit test suite. Closing per org-wide PR backlog cleanup ([GRO-1355](/GRO/issues/GRO-1355)).
Scrubs McBarkley closed this pull request 2026-05-20 12:10:25 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#396
Delete Branch "feat/GRO-106-stop-help"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?