groombook/app
Archived
13
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(api): correct DB mock setup for extracted groombook/api test suite #397

Closed
groombook-engineer[bot] wants to merge 2 commits from fix/GRO-1108-test-mocks into dev
pull from: fix/GRO-1108-test-mocks
merge into: groombook:dev
Conversation 1 Commits 2 Files Changed 5
+484 -2
groombook-engineer[bot] commented 2026-05-14 05:39:25 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add mocks/db.ts shared mock factory with table proxies for all 31 tables (@groombook/db exports) including all SQL helpers and enum types
  • waitlist.test.ts: portalAudit middleware now calls db.insert() as a side-effect after each request; filter inserts so only actual waitlist entry inserts (petId/serviceId present) are counted, not audit log inserts from the middleware
  • All 288 API tests pass

Test plan

  • vitest run passes all 288 API tests locally
  • CI passes

🤖 Generated with Claude Code

## Summary - Add `mocks/db.ts` shared mock factory with table proxies for all 31 tables (`@groombook/db` exports) including all SQL helpers and enum types - `waitlist.test.ts`: `portalAudit` middleware now calls `db.insert()` as a side-effect after each request; filter inserts so only actual waitlist entry inserts (petId/serviceId present) are counted, not audit log inserts from the middleware - All 288 API tests pass ## Test plan - [x] `vitest run` passes all 288 API tests locally - [ ] CI passes 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The Dogfather commented 2026-05-20 12:18:09 +00:00
Member
Copy Link
Copy Source

CTO Assessment

This PR adds apps/api/src/services/messaging/consent.ts with mocks and tests to the monorepo. However, the standalone groombook/api repo is now the target for API development — api/#12 (GRO-1172: Scheduling Engine Buffer Integration) covers related buffer/scheduling work there.

Recommendation: Close this PR and redirect the consent/messaging work to the standalone groombook/api repo. The monorepo groombook/app should not receive new API features while the extraction is in progress.

@cpfarhood — please confirm if you agree with closing this in favor of standalone api repo work.

## CTO Assessment This PR adds `apps/api/src/services/messaging/consent.ts` with mocks and tests to the monorepo. However, the standalone `groombook/api` repo is now the target for API development — `api/#12` (GRO-1172: Scheduling Engine Buffer Integration) covers related buffer/scheduling work there. **Recommendation:** Close this PR and redirect the consent/messaging work to the standalone `groombook/api` repo. The monorepo `groombook/app` should not receive new API features while the extraction is in progress. @cpfarhood — please confirm if you agree with closing this in favor of standalone api repo work.
The Dogfather closed this pull request 2026-05-21 19:32:22 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature
New feature
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/app#397
Delete Branch "fix/GRO-1108-test-mocks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?