e3c5ebb337
Backend: - GET /api/staff/me — returns current staff record (includes isSuperUser) - PATCH /api/staff/:id — accepts optional isSuperUser boolean; only super users can change this field; last-super-user guardrail prevents revoking the only active super user - PATCH /api/staff/:id (active=false) — guardrail prevents deactivating the last active super user - DELETE /api/staff/:id — guardrail prevents deleting the last active super user Frontend (Staff.tsx): - Fetches current user via GET /api/staff/me to determine isSuperUser - Shows ★ Super User badge for super user staff rows - Super user sees "+ Grant" button on non-super-user rows - Super user sees "Revoke" toggle on super-user rows (disabled if last one) - Deactivate button disabled for the last active super user - Error message displayed when backend guardrail triggers GRO-206 Co-Authored-By: Paperclip <noreply@paperclip.ing>
221 lines
6.2 KiB
TypeScript
221 lines
6.2 KiB
TypeScript
import { Hono } from "hono";
|
|
import { zValidator } from "@hono/zod-validator";
|
|
import { z } from "zod/v3";
|
|
import { randomBytes } from "node:crypto";
|
|
import { and, eq, getDb, ne, staff, appointments } from "@groombook/db";
|
|
import type { AppEnv } from "../middleware/rbac.js";
|
|
|
|
export const staffRouter = new Hono<AppEnv>();
|
|
|
|
const createStaffSchema = z.object({
|
|
name: z.string().min(1).max(200),
|
|
email: z.string().email(),
|
|
role: z.enum(["groomer", "receptionist", "manager"]).default("groomer"),
|
|
oidcSub: z.string().optional(),
|
|
active: z.boolean().default(true),
|
|
});
|
|
|
|
const updateStaffSchema = z.object({
|
|
name: z.string().min(1).max(200).optional(),
|
|
role: z.enum(["groomer", "receptionist", "manager"]).optional(),
|
|
active: z.boolean().optional(),
|
|
isSuperUser: z.boolean().optional(),
|
|
oidcSub: z.string().optional(),
|
|
});
|
|
|
|
staffRouter.get("/me", async (c) => {
|
|
const staffRow = c.get("staff");
|
|
return c.json(staffRow);
|
|
});
|
|
|
|
staffRouter.get("/", async (c) => {
|
|
const db = getDb();
|
|
const includeInactive = c.req.query("includeInactive") === "true";
|
|
const rows = includeInactive
|
|
? await db.select().from(staff).orderBy(staff.name)
|
|
: await db.select().from(staff).where(eq(staff.active, true)).orderBy(staff.name);
|
|
return c.json(rows);
|
|
});
|
|
|
|
staffRouter.get("/:id", async (c) => {
|
|
const db = getDb();
|
|
const [row] = await db
|
|
.select()
|
|
.from(staff)
|
|
.where(eq(staff.id, c.req.param("id")));
|
|
if (!row) return c.json({ error: "Not found" }, 404);
|
|
return c.json(row);
|
|
});
|
|
|
|
staffRouter.post("/", zValidator("json", createStaffSchema), async (c) => {
|
|
const db = getDb();
|
|
const body = c.req.valid("json");
|
|
const [row] = await db.insert(staff).values(body).returning();
|
|
return c.json(row, 201);
|
|
});
|
|
|
|
staffRouter.patch("/:id", zValidator("json", updateStaffSchema), async (c) => {
|
|
const db = getDb();
|
|
const currentStaff = c.get("staff");
|
|
const body = c.req.valid("json");
|
|
const targetId = c.req.param("id");
|
|
|
|
// Only super users can change isSuperUser
|
|
if (body.isSuperUser !== undefined && !currentStaff.isSuperUser) {
|
|
return c.json({ error: "Forbidden: super user privileges required to modify super user status" }, 403);
|
|
}
|
|
|
|
// Before revoking super user, check if this is the last one
|
|
if (body.isSuperUser === false) {
|
|
const superUserCount = await db
|
|
.select({ id: staff.id })
|
|
.from(staff)
|
|
.where(and(eq(staff.isSuperUser, true), eq(staff.active, true)))
|
|
.limit(2);
|
|
// If only 1 or 0 active super users and the target is one of them, block revoke
|
|
if (superUserCount.length <= 1) {
|
|
return c.json(
|
|
{ error: "Cannot revoke the last super user. Assign another super user first." },
|
|
400
|
|
);
|
|
}
|
|
}
|
|
|
|
// When deactivating a super user, also check last-super-user guardrail
|
|
if (body.active === false) {
|
|
const [target] = await db
|
|
.select({ isSuperUser: staff.isSuperUser })
|
|
.from(staff)
|
|
.where(eq(staff.id, targetId))
|
|
.limit(1);
|
|
if (target?.isSuperUser) {
|
|
const superUserCount = await db
|
|
.select({ id: staff.id })
|
|
.from(staff)
|
|
.where(and(eq(staff.isSuperUser, true), eq(staff.active, true)))
|
|
.limit(2);
|
|
if (superUserCount.length <= 1) {
|
|
return c.json(
|
|
{ error: "Cannot deactivate the last super user. Assign another super user first." },
|
|
400
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
const [row] = await db
|
|
.update(staff)
|
|
.set({ ...body, updatedAt: new Date() })
|
|
.where(eq(staff.id, targetId))
|
|
.returning();
|
|
if (!row) return c.json({ error: "Not found" }, 404);
|
|
return c.json(row);
|
|
});
|
|
|
|
staffRouter.delete("/:id", async (c) => {
|
|
const db = getDb();
|
|
const id = c.req.param("id");
|
|
|
|
// Prevent deleting staff who have existing non-cancelled appointments (fixes #21).
|
|
const activeAppointments = await db
|
|
.select({ id: appointments.id })
|
|
.from(appointments)
|
|
.where(
|
|
and(
|
|
eq(appointments.staffId, id),
|
|
ne(appointments.status, "cancelled"),
|
|
ne(appointments.status, "no_show"),
|
|
)
|
|
)
|
|
.limit(1);
|
|
if (activeAppointments.length > 0) {
|
|
return c.json(
|
|
{
|
|
error:
|
|
"Cannot delete staff member with existing appointments. Reassign or cancel their appointments first.",
|
|
},
|
|
409
|
|
);
|
|
}
|
|
|
|
// Prevent deleting the last super user
|
|
const [targetStaff] = await db
|
|
.select({ isSuperUser: staff.isSuperUser })
|
|
.from(staff)
|
|
.where(eq(staff.id, id))
|
|
.limit(1);
|
|
if (targetStaff?.isSuperUser) {
|
|
const superUserCount = await db
|
|
.select({ id: staff.id })
|
|
.from(staff)
|
|
.where(and(eq(staff.isSuperUser, true), eq(staff.active, true)))
|
|
.limit(2);
|
|
if (superUserCount.length <= 1) {
|
|
return c.json(
|
|
{ error: "Cannot delete the last super user. Assign another super user first." },
|
|
400
|
|
);
|
|
}
|
|
}
|
|
|
|
const [row] = await db
|
|
.delete(staff)
|
|
.where(eq(staff.id, id))
|
|
.returning();
|
|
if (!row) return c.json({ error: "Not found" }, 404);
|
|
return c.json({ ok: true });
|
|
});
|
|
|
|
staffRouter.post("/:id/ical-token", async (c) => {
|
|
const db = getDb();
|
|
const id = c.req.param("id");
|
|
const staffRow = c.get("staff");
|
|
|
|
if (staffRow.role !== "manager" && staffRow.id !== id) {
|
|
return c.json({ error: "Forbidden" }, 403);
|
|
}
|
|
|
|
const [member] = await db
|
|
.select()
|
|
.from(staff)
|
|
.where(eq(staff.id, id))
|
|
.limit(1);
|
|
|
|
if (!member) return c.json({ error: "Not found" }, 404);
|
|
|
|
const token = randomBytes(32).toString("hex");
|
|
const [updated] = await db
|
|
.update(staff)
|
|
.set({ icalToken: token, updatedAt: new Date() })
|
|
.where(eq(staff.id, id))
|
|
.returning();
|
|
|
|
if (!updated) return c.json({ error: "Not found" }, 404);
|
|
return c.json({ icalToken: updated.icalToken });
|
|
});
|
|
|
|
staffRouter.delete("/:id/ical-token", async (c) => {
|
|
const db = getDb();
|
|
const id = c.req.param("id");
|
|
const staffRow = c.get("staff");
|
|
|
|
if (staffRow.role !== "manager" && staffRow.id !== id) {
|
|
return c.json({ error: "Forbidden" }, 403);
|
|
}
|
|
|
|
const [member] = await db
|
|
.select()
|
|
.from(staff)
|
|
.where(eq(staff.id, id))
|
|
.limit(1);
|
|
|
|
if (!member) return c.json({ error: "Not found" }, 404);
|
|
|
|
await db
|
|
.update(staff)
|
|
.set({ icalToken: null, updatedAt: new Date() })
|
|
.where(eq(staff.id, id));
|
|
|
|
return c.json({ ok: true });
|
|
});
|