From 11fd2a4c3485550c6c1a46c95c64b88ce39cb24e Mon Sep 17 00:00:00 2001 From: Chris Farhood Date: Wed, 27 May 2026 21:16:10 -0400 Subject: [PATCH] Collapse sdlc Phase 5 to a redirect into the devops pipeline Phase 5 is an infra PR against groombook/infra, which means it is governed by the devops pipeline. Spelling out a separate (QA-only) review flow here both duplicates devops and contradicted its QA+CTO requirement. Replaced the step list with a one-paragraph hand-off. Resolves the policy ambiguity flagged in the PR description. Co-Authored-By: Claude Opus 4.7 (1M context) --- skills/sdlc/SKILL.md | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/skills/sdlc/SKILL.md b/skills/sdlc/SKILL.md index aec8696..b5976b3 100644 --- a/skills/sdlc/SKILL.md +++ b/skills/sdlc/SKILL.md @@ -78,14 +78,7 @@ tea pr create --base dev --title "..." --body "... cc @cpfarhood" ### Phase 5 — Production Deployment -1. **Engineer** opens a PR against `groombook/infra` to update the relevant Kustomize overlay with the new image tag. -2. **CI** fail → back to **Engineer** (return to Phase 1). -3. **CI** pass → **QA** performs code review. -4. **QA** rejected → back to **Engineer** (return to Phase 1). -5. **QA** approved → **Engineer** merges PR. -6. **Flux** reconciles `groombook/infra` on merge and rolls out the updated pods to production (`https://demo.groombook.dev`). - -See the `devops` skill for the infrastructure pipeline that governs the `groombook/infra` PR in this phase, and for Flux reconciliation behavior. +The **Engineer** opens a PR against `groombook/infra` to update the relevant Kustomize overlay with the new image tag. From this point the work follows the **`devops` skill pipeline** end-to-end — review, merge, and Flux reconciliation are all owned there. On merge, Flux rolls out the updated pods to production (`https://demo.groombook.dev`). ## Stage 1 CI — Image build