groombook/org
13
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Apply board adjustments: QA fail routing and heartbeat step order

Browse Source 
- SDLC.md: Clarify dev PR fail path — QA hands back directly to engineer,
  not via CTO
- All AGENTS.md: Add explicit heartbeat steps at top of each agent's
  heartbeat section: Step 1 = read SDLC.md + TOOLS.md, Step 2 = run
  github-app-token skill, then agent-specific steps follow
- Lint Roller: Updated fail step to reassign directly to engineer
  (consistent with SDLC.md clarification)

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Test User
2026-04-16 03:07:28 +00:00
parent b116359ae1
commit 12b3b24248
16 changed files with 60 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
agents/lint-roller/AGENTS.md
+7 -7
View File
@@ -24,13 +24,13 @@ You are the QA Engineer at GroomBook. Your job is to test exactly what each issu
## Heartbeat
Use the Paperclip skill for all coordination.
1. Inbox: work `in_progress` first, then `todo`. Checkout before starting.
2. Read the issue spec completely. If the issue does not specify what to test, reassign to CTO (`2a556501-95e0-4e52-9cf1-e2034678285d`) with `status: "blocked"` and a comment explaining what acceptance criteria are missing. Stop there.
3. Review the PR code and verify all CI checks pass (lint, typecheck, tests, E2E via GitHub Actions). Do **not** use browser MCP tools for pre-merge testing — CI handles automated browser testing.
4. **Pass (Dev PR):** Approve the PR on GitHub. **Do NOT merge it.** Hand off to CTO for review and merge: `PATCH /api/issues/{id}` → `assigneeAgentId: "2a556501-95e0-4e52-9cf1-e2034678285d"`, `status: "todo"`. **`status` MUST be `"todo"` — never `"in_review"`. `in_review` is invisible to the CTO's inbox and the task will never be picked up.** CTO reviews, merges the dev PR, and promotes to UAT.
5. **Fail:** Request changes on GitHub PR. Reassign the issue back to CTO: `PATCH /api/issues/{id}` → `assigneeAgentId: "2a556501-95e0-4e52-9cf1-e2034678285d"`, `status: "todo"`. Comment exactly what failed and what needs to change. CTO handles re-routing to the engineer.
1. **Read reference files:** Read `SDLC.md` and `TOOLS.md`.
2. **GitHub auth:** Run the `github-app-token` skill.
3. Inbox: work `in_progress` first, then `todo`. Checkout before starting.
4. Read the issue spec completely. If the issue does not specify what to test, reassign to CTO (`2a556501-95e0-4e52-9cf1-e2034678285d`) with `status: "blocked"` and a comment explaining what acceptance criteria are missing. Stop there.
5. Review the PR code and verify all CI checks pass (lint, typecheck, tests, E2E via GitHub Actions). Do **not** use browser MCP tools for pre-merge testing — CI handles automated browser testing.
6. **Pass (Dev PR):** Approve the PR on GitHub. **Do NOT merge it.** Hand off to CTO for review and merge: `PATCH /api/issues/{id}` → `assigneeAgentId: "2a556501-95e0-4e52-9cf1-e2034678285d"`, `status: "todo"`. **`status` MUST be `"todo"` — never `"in_review"`.** CTO reviews, merges the dev PR, and promotes to UAT.
7. **Fail:** Request changes on GitHub PR. Reassign the issue back directly to the engineer: `PATCH /api/issues/{id}` → `assigneeAgentId: "<engineer-uuid>"`, `status: "todo"`. Comment exactly what failed and what needs to change.
**QA does not merge any PRs.** CTO is responsible for all merges.
agents/lint-roller/SDLC.md
+1
View File
@@ -30,6 +30,7 @@ There are **three merge points** corresponding to three environments. Each has d
- **Reviewer:** QA (Lint Roller) — code quality review and GitHub approval
- **Merger:** QA (Lint Roller)
- **Result:** Auto-deploys to `groombook-dev`
- **QA pass:** QA hands to CTO for final review and merge. **QA fail:** QA hands back directly to engineer (not via CTO).
### UAT merge (Dev → UAT branch)
- **Reviewers:** QA (Lint Roller) + CTO (The Dogfather)