Commit Graph

17 Commits

Author SHA1 Message Date
Flea Flicker 152c52f47c docs(skills): loosen uat→main merge gate; CTO Approve only for novel auth, infra/prod, and risk-flagged
The 2026-06-11 merge-whitelist fix (GRO-2348) added a required_approvals
gate on uat→main merges. That gate is only satisfied by a Gitea Approve
click — the issue-thread QA/UAT-deploy/UAT-regression/security
approvals do not clear it. As a result the CTO is the human-in-the-loop
on every routine release-train PR (GRO-2358, GRO-2359 both hit it).

This change introduces an explicit "uat→main merge-gate policy" in
coding-standards: once the four pre-gates (QA, UAT deploy, UAT
regression, security) are green, the engineer self-merges. A CTO
Gitea Approve click is required only for three categories:

  1. Novel auth / session paths (login, OIDC, OOBE, session
     middleware, token issuance, MFA, new auth provider integrations).
  2. Infra / prod-affecting merges (deploys, manifests, secrets,
     GitOps overlays, CI/CD, main branch protection, prod-affecting
     routing/ingress). All Phase 5 infra overlay PRs in
     groombook/infra still require CTO Gitea Approve without
     exception.
  3. Risk-flagged merges (risk:cto-approve label, or explicit
     CTO/CEO sign-off request in the PR or issue thread).

Phase 4 in sdlc is updated to reflect the new flow: engineer
classifies the PR; CTO Approve happens only for the three categories
above; otherwise the engineer merges once the four pre-gates are
green. The pre-gates themselves do not change.

Refs: GRO-2377
Triggers: GRO-2358, GRO-2359
Source rule: GRO-2348 (merge-whitelist fix)
2026-06-12 01:30:45 +00:00
Chris Farhood 11fd2a4c34 Collapse sdlc Phase 5 to a redirect into the devops pipeline
Phase 5 is an infra PR against groombook/infra, which means it is governed
by the devops pipeline. Spelling out a separate (QA-only) review flow here
both duplicates devops and contradicted its QA+CTO requirement. Replaced
the step list with a one-paragraph hand-off.

Resolves the policy ambiguity flagged in the PR description.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-27 21:16:10 -04:00
Chris Farhood d6b13fa58d Split devops and sdlc skills by scope; dedupe shared content
devops/SKILL.md is now the canonical home for infrastructure lifecycle
(groombook/infra, single-branch main, Flux + OpenTofu controller, cluster
topology). sdlc/SKILL.md is scoped to application code (3-branch dev/uat/main,
Phases 1-5, Stage 1 CI image build, app-tool policy). Each skill cross-refs
the other and defers to coding-standards/safety for cross-cutting rules
rather than restating them.

Fixes in devops/SKILL.md:
- Rewrote frontmatter description (was a copy of sdlc, referenced phases
  and dev/uat/prod that do not apply).
- Hoisted "applies to groombook/infra" to a top-level scope statement.
- Renumbered the pipeline (was 1,2,3,4,4,5,4,5,5) and fixed --base dev
  -> --base main in the tea example.
- Closed an unterminated bold marker.
- Removed Authentication framework, Stage 1 image build, and the
  "never tofu / never kubectl apply" lines (now cited from sdlc / safety).
- Trimmed the tools list to infra-only operators and controllers.

Trims in sdlc/SKILL.md:
- Removed Infrastructure topology, IaC, Stage 2 GitOps detail, the Flux
  Image Automation DENIED policy, the "never tofu / never kubectl apply"
  lines, and the External communication section (cited from devops /
  safety / coding-standards instead).
- Trimmed the tools list to application-level dependency choices.
- Added a pointer from Phase 5 into the devops pipeline.

cc @cpfarhood

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-27 15:31:54 -04:00
Chris Farhood c756b16c7c more updates 2026-05-26 23:27:03 -04:00
Chris Farhood 743e913126 Update skills/sdlc/SKILL.md 2026-05-27 03:05:30 +00:00
Chris Farhood a0ae03e959 Update skills/sdlc/SKILL.md 2026-05-27 03:04:25 +00:00
Chris Farhood 643d9e8956 Update skills/sdlc/SKILL.md 2026-05-27 03:04:09 +00:00
Chris Farhood a51b28a315 minor tweaks 2026-05-26 23:03:17 -04:00
Chris Farhood 198ed88350 udpate sdlc 2026-05-26 23:01:12 -04:00
Chris Farhood c8d8cf562c chore: switch container registry references from ghcr.io to git.farh.net
GroomBook images live on the Gitea registry, not GitHub. Update SDLC,
coding-standards, and CLAUDE.md to match.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-26 09:45:20 -04:00
Chris Farhood bf5ecdc4dc chore(sdlc): align SDLC skill with cartsnitch/org structure
- CTO merges dev→uat (was QA); CEO Scrubs McBarkley merges uat→main (was Shedward)
- Simplify Gitea auth — GITEA_TOKEN is pre-set, drop tea login add
- Restore delegation model tier section
- Add Playwright MCP to canonical tools, CalVer tag detail, imagePullPolicy note
- Trim redundant UUIDs and the verbose pen-testing footnote

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-26 09:20:06 -04:00
Chris Farhood 60b9b41d4b chore: loosen SDLC to match Privileged Escalation pattern
- Engineer self-merges to dev after CI passes
- QA merges dev→uat (not CTO)
- UAT merges uat→main (not CEO)
- Remove Phase 0 product intake, delegation model, handoff protocol
- Remove explicit no-self-merge rule (covered by pipeline gates)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-24 15:33:56 -04:00
Chris Farhood 9f9fb356f4 Add CLAUDE.md and add agent UUIDs to SDLC skill
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 15:30:15 -04:00
Flea Flicker 4ad08fb09c Migrate SDLC skill from GitHub to Gitea 2026-05-19 23:12:24 +00:00
Chris Farhood 18f4ef2126 feat(sdlc): add delegation model tier policy
Set modelProfile cheap only for mechanical, bounded tasks. Leave unset
(judgment/reasoning/QA) for standard tier. When in doubt, leave unset.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-04 22:36:55 -04:00
Chris Farhood 93e70e6d66 feat(skills): align with cross-org review
- safety: drop tools section (moved to sdlc), add explicit kubectl-prod
  ban, add no-tofu-direct rule, drop the merge-gate cross-reference into
  a separate bullet
- sdlc: add Phase 0 product-analysis intake (CMPO Pawla as gate); add
  scheduled penetration testing program (Barkley owns); standardize
  authentication to Better-Auth + Google + Apple + Authentik; add
  canonical tools section (moved from safety) including ghcr.io/groombook
  registry standard; reorganize PR review sections to match the cross-org
  pattern (named SDLC pipeline phases)
2026-05-03 19:50:22 -04:00
Chris Farhood 4b32e84c03 feat(skills): add sdlc, safety, and coding-standards org skills
Mirrors the privilegedescalation/org pattern: extract company-wide
policy that was previously inlined in each agent's AGENTS.md into three
shared skills. Agents will reference these via one-line invocation
reminders in their Wake additions section.
2026-05-03 09:53:45 -04:00