From 2ec1b6a14de70ff67d0b1f893c5d2bafc365b377 Mon Sep 17 00:00:00 2001 From: Chris Farhood Date: Wed, 20 May 2026 04:53:52 +0000 Subject: [PATCH] Fix QA re-review: add missing types, aria-label, and temperament text - Add MedicalAlert, AlertSeverity, CoatType, preferredCuts, medicalAlerts, temperamentScore, temperamentFlags to @groombook/types Pet interface - Add aria-label="Add" to the preferred cuts + button - Fix temperament text expectation from "(/4/5)" to "(4/5)" Co-Authored-By: Claude Opus 4.7 --- packages/types/src/index.ts | 17 +++++++++++++++++ src/__tests__/PetForm.test.tsx | 2 +- src/portal/sections/PetForm.tsx | 3 ++- 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts index 90ef116..d53138e 100644 --- a/packages/types/src/index.ts +++ b/packages/types/src/index.ts @@ -39,6 +39,12 @@ export interface Pet { cutStyle: string | null; shampooPreference: string | null; specialCareNotes: string | null; + coatType: string | null; + petSizeCategory: string | null; + preferredCuts: string[]; + medicalAlerts: MedicalAlert[]; + temperamentScore?: number; + temperamentFlags?: string[]; customFields: Record; photoKey?: string; photoUploadedAt?: string; @@ -208,3 +214,14 @@ export interface PaginatedList { page: number; pageSize: number; } + +export type AlertSeverity = "low" | "medium" | "high"; + +export interface MedicalAlert { + id: string; + type: string; + description: string; + severity: AlertSeverity; +} + +export type CoatType = "smooth" | "double" | "curly" | "wire" | "long" | "hairless"; diff --git a/src/__tests__/PetForm.test.tsx b/src/__tests__/PetForm.test.tsx index 0a90d4d..802e851 100644 --- a/src/__tests__/PetForm.test.tsx +++ b/src/__tests__/PetForm.test.tsx @@ -148,7 +148,7 @@ describe("PetForm", () => { temperamentFlags: ["Anxious", "Good with kids"], }; render(); - expect(screen.getByText("(/4/5)")).toBeTruthy(); + expect(screen.getByText("(4/5)")).toBeTruthy(); expect(screen.getByText("Anxious")).toBeTruthy(); expect(screen.getByText("Good with kids")).toBeTruthy(); }); diff --git a/src/portal/sections/PetForm.tsx b/src/portal/sections/PetForm.tsx index 1deec6b..16c4476 100644 --- a/src/portal/sections/PetForm.tsx +++ b/src/portal/sections/PetForm.tsx @@ -262,7 +262,8 @@ export function PetForm({ pet, onSave, onCancel }: Props) {