From 344a32e3e421f4bcf8b92239693ec357321c100c Mon Sep 17 00:00:00 2001 From: Barcode Betty Date: Tue, 26 May 2026 12:00:55 +0000 Subject: [PATCH 01/15] feat(GRO-1792): add recovery paths to booking error and cancellation pages - Add "Start a new booking" button to BookingError linking to /admin/book - Add "Book again" button to BookingCancelled linking to /admin/book - Add business contact info section to BookingError (from BUSINESS_CONTACT_INFO constant) - Replace hardcoded colors with CSS variables (--color-error, --color-cancelled, etc.) - Add page-level string constants to eliminate hardcoded strings - Add unit tests for both pages (9 tests passing) Co-Authored-By: Paperclip --- src/__tests__/BookingCancelled.test.tsx | 27 +++++++++ src/__tests__/BookingError.test.tsx | 38 ++++++++++++ src/index.css | 13 +++++ src/lib/contact.ts | 7 +++ src/pages/BookingCancelled.tsx | 68 ++++++++++++++------- src/pages/BookingError.tsx | 78 ++++++++++++++++++------- 6 files changed, 187 insertions(+), 44 deletions(-) create mode 100644 src/__tests__/BookingCancelled.test.tsx create mode 100644 src/__tests__/BookingError.test.tsx create mode 100644 src/lib/contact.ts diff --git a/src/__tests__/BookingCancelled.test.tsx b/src/__tests__/BookingCancelled.test.tsx new file mode 100644 index 0000000..2d6ada1 --- /dev/null +++ b/src/__tests__/BookingCancelled.test.tsx @@ -0,0 +1,27 @@ +import { describe, it, expect } from "vitest"; +import { render, screen } from "@testing-library/react"; +import { BookingCancelledPage } from "../pages/BookingCancelled.tsx"; + +describe("BookingCancelledPage", () => { + it("renders the cancelled heading", () => { + render(); + expect(screen.getByRole("heading", { name: /Appointment Cancelled/i })).toBeInTheDocument(); + }); + + it("renders the cancelled body text", () => { + render(); + expect(screen.getByText(/Your appointment has been cancelled/i)).toBeInTheDocument(); + }); + + it("has a Book again link pointing to /admin/book", () => { + render(); + const link = screen.getByRole("link", { name: /Book again/i }); + expect(link).toHaveAttribute("href", "/admin/book"); + }); + + it("has a Back to Portal link pointing to /", () => { + render(); + const link = screen.getByRole("link", { name: /Back to Portal/i }); + expect(link).toHaveAttribute("href", "/"); + }); +}); diff --git a/src/__tests__/BookingError.test.tsx b/src/__tests__/BookingError.test.tsx new file mode 100644 index 0000000..0f30f6e --- /dev/null +++ b/src/__tests__/BookingError.test.tsx @@ -0,0 +1,38 @@ +import { describe, it, expect } from "vitest"; +import { render, screen } from "@testing-library/react"; +import { BookingErrorPage } from "../pages/BookingError.tsx"; +import { BUSINESS_CONTACT_INFO } from "../lib/contact.ts"; + +describe("BookingErrorPage", () => { + it("renders the error heading", () => { + render(); + expect(screen.getByRole("heading", { name: /Link Invalid or Expired/i })).toBeInTheDocument(); + }); + + it("renders the error body text", () => { + render(); + expect(screen.getByText(/This confirmation link is invalid/i)).toBeInTheDocument(); + }); + + it("has a Start a new booking link pointing to /admin/book", () => { + render(); + const link = screen.getByRole("link", { name: /Start a new booking/i }); + expect(link).toHaveAttribute("href", "/admin/book"); + }); + + it("has a Back to Portal link pointing to /", () => { + render(); + const link = screen.getByRole("link", { name: /Back to Portal/i }); + expect(link).toHaveAttribute("href", "/"); + }); + + it("displays business contact phone", () => { + render(); + expect(screen.getByText(BUSINESS_CONTACT_INFO.phone)).toBeInTheDocument(); + }); + + it("displays business contact email", () => { + render(); + expect(screen.getByText(BUSINESS_CONTACT_INFO.email)).toBeInTheDocument(); + }); +}); diff --git a/src/index.css b/src/index.css index 61c98ed..32b3b5e 100644 --- a/src/index.css +++ b/src/index.css @@ -8,6 +8,19 @@ --color-accent-dark: color-mix(in srgb, var(--color-accent) 78%, #000); --color-accent-light: color-mix(in srgb, var(--color-accent) 18%, #fff); --color-accent-lighter: color-mix(in srgb, var(--color-accent) 9%, #fff); + + /* Semantic / booking page tokens */ + --color-error: #dc2626; + --color-error-dark: #b91c1c; + --color-error-bg: #fef2f2; + --color-cancelled: #ea580c; + --color-cancelled-dark: #c2410c; + --color-cancelled-bg: #fff7ed; + --color-success: #16a34a; + --color-success-dark: #15803d; + --color-success-bg: #f0fdf4; + --color-text-secondary: #4b5563; + --color-surface: #fff; } *, *::before, *::after { diff --git a/src/lib/contact.ts b/src/lib/contact.ts new file mode 100644 index 0000000..d2908cf --- /dev/null +++ b/src/lib/contact.ts @@ -0,0 +1,7 @@ +// Business contact information — update values to reflect actual business details. +// Used on error/cancellation pages to help customers reach the business. +export const BUSINESS_CONTACT_INFO = { + phone: "(555) 000-1234", + email: "hello@groombook.example.com", + address: "123 Main St, Anytown, USA", +} as const; diff --git a/src/pages/BookingCancelled.tsx b/src/pages/BookingCancelled.tsx index 9b2ab4a..6ded7af 100644 --- a/src/pages/BookingCancelled.tsx +++ b/src/pages/BookingCancelled.tsx @@ -1,3 +1,10 @@ +const STRINGS = { + heading: "Appointment Cancelled", + body: "Your appointment has been cancelled. If this was a mistake or you'd like to rebook, please contact us.", + bookAgain: "Book again", + backToPortal: "Back to Portal", +} as const; + export function BookingCancelledPage() { return (
✗
-

- Appointment Cancelled +

+ {STRINGS.heading}

-

- Your appointment has been cancelled. If this was a mistake or you'd - like to rebook, please contact us. +

+ {STRINGS.body}

- - Back to Portal - + +
); diff --git a/src/pages/BookingError.tsx b/src/pages/BookingError.tsx index 62639d9..ba5d43d 100644 --- a/src/pages/BookingError.tsx +++ b/src/pages/BookingError.tsx @@ -1,3 +1,13 @@ +import { BUSINESS_CONTACT_INFO } from "../lib/contact"; + +const STRINGS = { + heading: "Link Invalid or Expired", + body: "This confirmation link is invalid, has already been used, or your appointment has already passed. Please contact us if you need help.", + newBooking: "Start a new booking", + backToPortal: "Back to Portal", + contactLabel: "Need help?", +} as const; + export function BookingErrorPage() { return (
⚠️
-

- Link Invalid or Expired +

+ {STRINGS.heading}

-

- This confirmation link is invalid, has already been used, or your - appointment has already passed. Please contact us if you need help. +

+ {STRINGS.body}

- - Back to Portal - + + + +
+

{STRINGS.contactLabel}

+

+ {BUSINESS_CONTACT_INFO.phone} · {BUSINESS_CONTACT_INFO.email} +

+
); From d78c859c2bf2e094ecc9783cf5b113a6d1b2745b Mon Sep 17 00:00:00 2001 From: Barcode Betty Date: Tue, 26 May 2026 12:23:29 +0000 Subject: [PATCH 02/15] Replace hardcoded time slots with dynamic API availability MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Both BookingFlow and RescheduleFlow in Appointments.tsx now fetch from /api/book/availability when a date is selected, matching the public booking wizard behavior. Loading and error states shown. - Removed hardcoded availableTimes arrays from both flows - Added useEffect that fetches availability on date change - Shows "Checking availability…" while loading - Shows error message on fetch failure - Shows "No available slots" when API returns empty Added tests for RescheduleFlow dynamic slot fetching covering: loading, fetched slots, error, empty, API params, and re-fetch on date change. Co-Authored-By: Paperclip --- src/__tests__/Appointments.test.tsx | 140 ++++++++++++++++++++++++++- src/portal/sections/Appointments.tsx | 70 ++++++++++---- 2 files changed, 189 insertions(+), 21 deletions(-) diff --git a/src/__tests__/Appointments.test.tsx b/src/__tests__/Appointments.test.tsx index bc42a07..d70f3d6 100644 --- a/src/__tests__/Appointments.test.tsx +++ b/src/__tests__/Appointments.test.tsx @@ -1,5 +1,5 @@ import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"; -import { render, screen, fireEvent, waitFor } from "@testing-library/react"; +import { render, screen, fireEvent, waitFor, act } from "@testing-library/react"; import { parseTimeTo24Hour, isUpcoming, CustomerNotesSection, ConfirmationSection } from "../portal/sections/Appointments.tsx"; const UPCOMING_APPT = { @@ -379,4 +379,142 @@ describe("ConfirmationSection", () => { expect(screen.getByText(/Confirmed!/i)).toBeInTheDocument(); }); }); +}); + +describe("RescheduleFlow dynamic time slots", () => { + beforeEach(() => { + vi.clearAllMocks(); + global.fetch = vi.fn(); + }); + + const RESCHEDULE_APPT = { + id: "appt-r1", + petId: "pet-1", + petName: "Buddy", + groomerId: "groomer-1", + groomerName: "Sarah", + services: ["Bath & Brush"], + serviceId: "service-1", + addOns: [], + date: "2027-01-01", + time: "10:00 AM", + duration: 60, + price: 50, + status: "confirmed" as const, + notes: "", + customerNotes: "", + confirmationStatus: "confirmed" as const, + }; + + it("shows loading state while fetching availability", async () => { + vi.mocked(global.fetch).mockReturnValue(new Promise(() => {})); // Never resolves + + const { RescheduleFlow } = await import("../portal/sections/Appointments.tsx"); + render( {}} sessionId="test-session-id" />); + + const dateInput = screen.getByLabelText(/date/i) || screen.getByRole("textbox", { name: /date/i }); + fireEvent.change(dateInput, { target: { value: "2027-01-15" } }); + + await waitFor(() => { + expect(screen.getByText(/Checking availability/i)).toBeInTheDocument(); + }); + }); + + it("displays fetched time slots from API", async () => { + vi.mocked(global.fetch).mockResolvedValue({ + ok: true, + json: async () => ["9:00 AM", "10:00 AM", "2:00 PM"], + } as Response); + + const { RescheduleFlow } = await import("../portal/sections/Appointments.tsx"); + render( {}} sessionId="test-session-id" />); + + const dateInput = screen.getByLabelText(/date/i) || screen.getByRole("textbox", { name: /date/i }); + fireEvent.change(dateInput, { target: { value: "2027-01-15" } }); + + await waitFor(() => { + expect(screen.getByText("9:00 AM")).toBeInTheDocument(); + expect(screen.getByText("10:00 AM")).toBeInTheDocument(); + expect(screen.getByText("2:00 PM")).toBeInTheDocument(); + }); + }); + + it("shows error state when availability fetch fails", async () => { + vi.mocked(global.fetch).mockRejectedValue(new Error("Network error")); + + const { RescheduleFlow } = await import("../portal/sections/Appointments.tsx"); + render( {}} sessionId="test-session-id" />); + + const dateInput = screen.getByLabelText(/date/i) || screen.getByRole("textbox", { name: /date/i }); + fireEvent.change(dateInput, { target: { value: "2027-01-15" } }); + + await waitFor(() => { + expect(screen.getByText(/Failed to load time slots/i)).toBeInTheDocument(); + }); + }); + + it("shows no slots message when API returns empty array", async () => { + vi.mocked(global.fetch).mockResolvedValue({ + ok: true, + json: async () => [] as string[], + } as Response); + + const { RescheduleFlow } = await import("../portal/sections/Appointments.tsx"); + render( {}} sessionId="test-session-id" />); + + const dateInput = screen.getByLabelText(/date/i) || screen.getByRole("textbox", { name: /date/i }); + fireEvent.change(dateInput, { target: { value: "2027-01-15" } }); + + await waitFor(() => { + expect(screen.getByText(/No available slots on this date/i)).toBeInTheDocument(); + }); + }); + + it("calls /api/book/availability with the selected date", async () => { + vi.mocked(global.fetch).mockResolvedValue({ + ok: true, + json: async () => ["9:00 AM"] as string[], + } as Response); + + const { RescheduleFlow } = await import("../portal/sections/Appointments.tsx"); + render( {}} sessionId="test-session-id" />); + + const dateInput = screen.getByLabelText(/date/i) || screen.getByRole("textbox", { name: /date/i }); + fireEvent.change(dateInput, { target: { value: "2027-02-20" } }); + + await waitFor(() => { + expect(global.fetch).toHaveBeenCalledWith( + "/api/book/availability?date=2027-02-20", + expect.objectContaining({ + headers: expect.objectContaining({ "X-Impersonation-Session-Id": "test-session-id" }), + }) + ); + }); + }); + + it("re-fetches slots when date changes", async () => { + vi.mocked(global.fetch) + .mockResolvedValueOnce({ + ok: true, + json: async () => ["9:00 AM"] as string[], + } as Response) + .mockResolvedValueOnce({ + ok: true, + json: async () => ["11:00 AM", "1:00 PM"] as string[], + } as Response); + + const { RescheduleFlow } = await import("../portal/sections/Appointments.tsx"); + render( {}} sessionId="test-session-id" />); + + const dateInput = screen.getByLabelText(/date/i) || screen.getByRole("textbox", { name: /date/i }); + + fireEvent.change(dateInput, { target: { value: "2027-01-10" } }); + await waitFor(() => expect(screen.getByText("9:00 AM")).toBeInTheDocument()); + + fireEvent.change(dateInput, { target: { value: "2027-01-15" } }); + await waitFor(() => { + expect(screen.getByText("11:00 AM")).toBeInTheDocument(); + expect(screen.getByText("1:00 PM")).toBeInTheDocument(); + }); + }); }); \ No newline at end of file diff --git a/src/portal/sections/Appointments.tsx b/src/portal/sections/Appointments.tsx index f5fad62..593ca8a 100644 --- a/src/portal/sections/Appointments.tsx +++ b/src/portal/sections/Appointments.tsx @@ -573,16 +573,26 @@ export function RescheduleFlow({ const [submitting, setSubmitting] = useState(false); const [error, setError] = useState(null); const [success, setSuccess] = useState(false); + const [slotsLoading, setSlotsLoading] = useState(false); + const [slotsError, setSlotsError] = useState(null); + const [availableTimes, setAvailableTimes] = useState([]); - const availableTimes = [ - '9:00 AM', - '10:00 AM', - '11:00 AM', - '1:00 PM', - '2:00 PM', - '3:00 PM', - '4:00 PM', - ]; + useEffect(() => { + if (!selectedDate || !sessionId) { + setAvailableTimes([]); + return; + } + const params = new URLSearchParams({ date: selectedDate }); + setSlotsLoading(true); + setSlotsError(null); + fetch(`/api/book/availability?${params.toString()}`, { + headers: { "X-Impersonation-Session-Id": sessionId ?? "" }, + }) + .then((r) => r.json() as Promise) + .then(setAvailableTimes) + .catch(() => setSlotsError('Failed to load time slots')) + .finally(() => setSlotsLoading(false)); + }, [selectedDate, sessionId]); async function handleSubmit() { if (!selectedDate || !selectedTime) return; @@ -661,7 +671,12 @@ export function RescheduleFlow({ /> {selectedDate && (
- {availableTimes.map((time) => ( + {slotsLoading &&

Checking availability…

} + {!slotsLoading && slotsError &&

{slotsError}

} + {!slotsLoading && availableTimes.length === 0 && !slotsError && ( +

No available slots on this date.

+ )} + {!slotsLoading && availableTimes.map((time) => (
- - {appt.status} - + {expanded ? ( ) : ( From 112c61ab1cc3f1a05b60020f983a506f12d09f8e Mon Sep 17 00:00:00 2001 From: Flea Flicker Date: Tue, 26 May 2026 13:06:07 +0000 Subject: [PATCH 09/15] fix: add non-null assertion on listener.mock.calls[0] (TS strict mode) Lines 28 and 40 access mock.calls[0] which is possibly undefined under strict TypeScript. Adding ! to satisfy TS2532. Co-Authored-By: Paperclip --- src/__tests__/analytics.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/__tests__/analytics.test.ts b/src/__tests__/analytics.test.ts index e8621b5..f24dd11 100644 --- a/src/__tests__/analytics.test.ts +++ b/src/__tests__/analytics.test.ts @@ -25,7 +25,7 @@ describe("analytics", () => { window.addEventListener(ANALYTICS_EVENTS.BOOKING_STEP_SERVICE, listener); fireAnalyticsEvent(ANALYTICS_EVENTS.BOOKING_STEP_SERVICE, { step: "service", flow: "public" }); expect(listener).toHaveBeenCalledTimes(1); - const event = listener.mock.calls[0][0] as CustomEvent; + const event = listener.mock.calls[0]![0] as CustomEvent; expect(event.type).toBe("booking_step_service"); expect(event.detail.step).toBe("service"); expect(event.detail.flow).toBe("public"); @@ -37,7 +37,7 @@ describe("analytics", () => { const listener = vi.fn(); window.addEventListener(ANALYTICS_EVENTS.BOOKING_CONFIRMED, listener); fireAnalyticsEvent(ANALYTICS_EVENTS.BOOKING_CONFIRMED, { step: "confirmed", flow: "public" }); - const event = listener.mock.calls[0][0] as CustomEvent; + const event = listener.mock.calls[0]![0] as CustomEvent; expect(event.detail.timestamp).toBeTruthy(); expect(new Date(event.detail.timestamp as string)).toBeInstanceOf(Date); window.removeEventListener(ANALYTICS_EVENTS.BOOKING_CONFIRMED, listener); From 65686c85637e6f5e86c165dfb24136ca50608c41 Mon Sep 17 00:00:00 2001 From: Flea Flicker Date: Tue, 26 May 2026 13:12:59 +0000 Subject: [PATCH 10/15] fix(GRO-1795): restore fireEvent and waitFor imports QA regression: PR #26 removed fireEvent and waitFor from the @testing-library/react import, breaking 21 test cases and typecheck. Co-Authored-By: Paperclip --- src/__tests__/Appointments.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/__tests__/Appointments.test.tsx b/src/__tests__/Appointments.test.tsx index afa0e69..0f6fd76 100644 --- a/src/__tests__/Appointments.test.tsx +++ b/src/__tests__/Appointments.test.tsx @@ -1,5 +1,5 @@ import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"; -import { render, screen } from "@testing-library/react"; +import { render, screen, fireEvent, waitFor } from "@testing-library/react"; import { parseTimeTo24Hour, isUpcoming, CustomerNotesSection, ConfirmationSection, StatusBadge } from "../portal/sections/Appointments.tsx"; const UPCOMING_APPT = { From 4e487db6f132b960c84db36becda79757f56b22d Mon Sep 17 00:00:00 2001 From: Flea Flicker Date: Wed, 27 May 2026 01:01:28 +0000 Subject: [PATCH 11/15] =?UTF-8?q?fix(GRO-1822):=20add=20role=20check=20bef?= =?UTF-8?q?ore=20/admin=20redirect=20=E2=80=94=20customers=20access=20port?= =?UTF-8?q?al?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit App.tsx lines 389-393 redirected ALL authenticated users to /admin, breaking customer portal access after SSO login. Now checks `session.user.role === "staff"` before redirecting. Customers (role !== "staff") can access the portal at /. Co-Authored-By: Paperclip --- src/App.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/App.tsx b/src/App.tsx index ea51314..30d2091 100644 --- a/src/App.tsx +++ b/src/App.tsx @@ -386,9 +386,10 @@ export function App() { return ; } - // Redirect authenticated users to /admin (but preserve impersonation flow via ?sessionId=) + // Redirect staff to /admin; allow customers to access portal (preserve impersonation via ?sessionId=) const searchParams = new URLSearchParams(location.search); - if (!authDisabled && session && !location.pathname.startsWith("/admin") && !searchParams.has("sessionId")) { + const isStaff = session?.user && (session.user as any).role === "staff"; + if (!authDisabled && session && !location.pathname.startsWith("/admin") && !searchParams.has("sessionId") && isStaff) { return ; } From ad9a178c89187257abdeb660812f844524450bbb Mon Sep 17 00:00:00 2001 From: Flea Flicker Date: Wed, 27 May 2026 02:20:41 +0000 Subject: [PATCH 12/15] fix: add skipWaiting/clientsClaim to VitePWA workbox config Root cause: SW remained in waiting phase after redeploy, serving stale precached assets. Without skipWaiting/clientsClaim the old SW persisted and controlled the page even after a new SW was installed. Fixes blank-page regression where React never mounted on login. --- vite.config.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vite.config.ts b/vite.config.ts index d73c18d..d2c7811 100644 --- a/vite.config.ts +++ b/vite.config.ts @@ -39,6 +39,8 @@ export default defineConfig({ ], }, workbox: { + skipWaiting: true, + clientsClaim: true, globPatterns: ["**/*.{js,css,html,ico,png,svg,woff2}"], navigateFallbackDenylist: [ /^\/api\/auth\//, From 198053fa31955a3a6bac3fbbc56952e75d8ab370 Mon Sep 17 00:00:00 2001 From: Flea Flicker <22+gb_flea@noreply.git.farh.net> Date: Mon, 1 Jun 2026 15:47:41 +0000 Subject: [PATCH 13/15] feat(GRO-1867): bridge Better Auth session to CustomerPortal (#34) --- UAT_PLAYBOOK.md | 24 +++++ src/__tests__/portal.test.tsx | 161 ++++++++++++++++++++++++++++++++++ src/portal/CustomerPortal.tsx | 106 ++++++++++++++++++++-- 3 files changed, 286 insertions(+), 5 deletions(-) diff --git a/UAT_PLAYBOOK.md b/UAT_PLAYBOOK.md index 3b009ae..e6dbc30 100644 --- a/UAT_PLAYBOOK.md +++ b/UAT_PLAYBOOK.md @@ -347,6 +347,30 @@ export const { signIn, signOut, useSession, changePassword } = authClient; | TC-WEB-5.24.12 | No PII in analytics payloads | Fire each event and inspect detail object | Payload contains only: step, flow, timestamp — no names, emails, phone numbers, or pet names | | TC-WEB-5.24.13 | No-op safe | Trigger analytics with window.dispatchEvent blocked (e.g. CSP) | No error thrown; booking flow completes normally | +### 5.25 Customer Portal — Better Auth SSO Bridge (GRO-1867) + +These cases cover the `CustomerPortal` initialisation path that bridges an Authentik / Better Auth session into a portal session via `POST /api/portal/session-from-auth`. The bridge runs after the URL-impersonation (`?sessionId=`) and dev-user paths have been ruled out. + +**Pre-conditions:** + +- UAT is configured with Authentik SSO and the `seed-uat-passwords` Secret in `groombook-uat` provides the seeded customer credentials (`uat-seed-password-source` memory). +- `POST /api/portal/session-from-auth` from [GRO-1866](https://paperclip.farhoodlabs.com/GRO/issues/GRO-1866) is deployed on UAT. +- Clear cookies and localStorage between cases unless otherwise noted. + +| # | Scenario | Steps | Expected | +|---|----------|-------|----------| +| TC-WEB-5.25.1 | Authenticated customer reaches portal dashboard | 1. From clean state, navigate to UAT `/login`. 2. Click "Sign in with SSO" and complete Authentik flow with a seeded **customer** identity. 3. After callback, land on `/`. | Portal dashboard renders. No redirect to `/login`. No impersonation banner. Top-right greeting reads "Hi, <FirstName>". | +| TC-WEB-5.25.2 | Bridge call sequence | Repeat TC-WEB-5.25.1 with DevTools → Network open and the **All** tab filtered to `/api/`. | In order: `GET /api/auth/get-session` → 200. `POST /api/portal/session-from-auth` → 201 with body `{ sessionId, clientId, clientName }`. | +| TC-WEB-5.25.3 | Subsequent portal calls use the bridged session ID | After TC-WEB-5.25.1 succeeds, navigate to **Appointments**, **My Pets**, **Billing**, **Settings**. Inspect any `/api/portal/*` request in DevTools → Network. | Each portal API call carries an `X-Impersonation-Session-Id` header whose value equals the `sessionId` returned by `session-from-auth` (not a URL-param value). Each call returns 200 (or 404 for genuinely empty collections), never 401. | +| TC-WEB-5.25.4 | No impersonation chrome for the customer's own session | After TC-WEB-5.25.1, scan the portal UI. | No amber border around the page. No "STAFF VIEW" watermark. No "End Impersonation" button in the sidebar. The customer is themselves; only impersonation sessions started via `?sessionId=` show the banner. | +| TC-WEB-5.25.5 | 404 fallback for authenticated user with no client record | 1. Sign in via SSO with an Authentik account whose email is **not** present in `clients`. 2. Land on `/`. | `POST /api/portal/session-from-auth` returns 404. The portal renders a centred card titled **"Portal access not configured"** with the message about contacting the groomer and a **Sign out** button. No redirect loop, no portal chrome. | +| TC-WEB-5.25.6 | 404 fallback Sign-out escape hatch | From TC-WEB-5.25.5 click **Sign out**. | `POST /api/auth/sign-out` fires; browser navigates to `/login`; the Authentik session cookie is cleared. Reloading `/` no longer hits 404 (will show the login page). | +| TC-WEB-5.25.7 | Bridge precedence — impersonation URL wins | 1. Sign in via SSO as a customer. 2. Open a new tab to `https://uat.groombook.dev/?sessionId=`. | The impersonation path runs; the amber banner appears for the impersonated client. The Better Auth bridge is **not** called on this load (`session-from-auth` absent in Network). | +| TC-WEB-5.25.8 | Bridge precedence — dev user wins | In dev mode (e.g. local) with `localStorage["dev-user"]` set to a client persona, navigate to `/`. | The dev-session path runs (`POST /api/portal/dev-session`). The Better Auth bridge is **not** called (`session-from-auth` absent in Network). Staff dev users still redirect to `/admin`. | +| TC-WEB-5.25.9 | Staff Better Auth session does not run the customer bridge | Sign in via SSO with a staff identity. Navigate to `/`. | `App.tsx` routing redirects to `/admin`. `POST /api/portal/session-from-auth` is **not** called. | +| TC-WEB-5.25.10 | Unauthenticated user is sent to login (no infinite loop) | Without signing in, navigate directly to `/`. | `App.tsx` renders the LoginPage. `CustomerPortal` does not render. No `session-from-auth` request is made. | +| TC-WEB-5.25.11 | Session persists across reload via Better Auth cookie | After TC-WEB-5.25.1 succeeds, reload the page. | Portal dashboard re-renders. A fresh `GET /api/auth/get-session` + `POST /api/portal/session-from-auth` pair runs and yields 200/201. Greeting still reads "Hi, <FirstName>". | + ## 6. Pass/Fail Criteria **Pass:** diff --git a/src/__tests__/portal.test.tsx b/src/__tests__/portal.test.tsx index 36f04af..5161aa1 100644 --- a/src/__tests__/portal.test.tsx +++ b/src/__tests__/portal.test.tsx @@ -313,3 +313,164 @@ describe("CustomerPortal session loading", () => { Object.defineProperty(window, "location", { value: originalLocation, writable: true }); }); }); + +// ─── CustomerPortal — Better Auth SSO bridge (GRO-1867) ──────────────────── + +describe("CustomerPortal SSO bridge", () => { + beforeEach(() => { + // Make sure no dev-user leaks across tests + window.localStorage.clear(); + }); + + const brandingResponse = { + ok: true, + json: async () => ({ + businessName: "GroomBook", + primaryColor: "#4f8a6f", + accentColor: "#8b7355", + logoBase64: null, + logoMimeType: null, + }), + } as Response; + + it("bridges Better Auth session via /api/portal/session-from-auth and uses returned sessionId", async () => { + global.fetch = vi.fn((input: RequestInfo, init?: RequestInit) => { + const url = typeof input === "string" ? input : input.toString(); + if (url === "/api/branding") return Promise.resolve(brandingResponse); + if (url === "/api/auth/get-session") { + return Promise.resolve({ + ok: true, + json: async () => ({ user: { email: "customer@example.com", role: "customer" } }), + } as Response); + } + if (url === "/api/portal/session-from-auth" && init?.method === "POST") { + return Promise.resolve({ + ok: true, + status: 201, + json: async () => ({ sessionId: "sso-sess-1", clientId: "client-1", clientName: "Jane Doe" }), + } as Response); + } + // Subsequent portal API calls — surface them so we can assert the header + return Promise.resolve({ ok: true, json: async () => ({}) } as Response); + }) as unknown as typeof fetch; + + const { CustomerPortal } = await import("../portal/CustomerPortal.js"); + render( + + + + ); + + await waitFor(() => { + expect(global.fetch).toHaveBeenCalledWith("/api/auth/get-session", expect.objectContaining({ credentials: "include" })); + }); + await waitFor(() => { + expect(global.fetch).toHaveBeenCalledWith( + "/api/portal/session-from-auth", + expect.objectContaining({ method: "POST", credentials: "include" }) + ); + }); + // Client greeting reflects the bridged customer name (proof the response was consumed) + await waitFor(() => { + expect(screen.getByText(/Hi, Jane/)).toBeInTheDocument(); + }); + // The impersonation banner must NOT appear — this is the customer themselves + expect(screen.queryByRole("button", { name: /End Session/i })).not.toBeInTheDocument(); + }); + + it("shows a friendly fallback when session-from-auth returns 404 (no client record)", async () => { + global.fetch = vi.fn((input: RequestInfo) => { + const url = typeof input === "string" ? input : input.toString(); + if (url === "/api/branding") return Promise.resolve(brandingResponse); + if (url === "/api/auth/get-session") { + return Promise.resolve({ + ok: true, + json: async () => ({ user: { email: "stranger@example.com", role: "customer" } }), + } as Response); + } + if (url === "/api/portal/session-from-auth") { + return Promise.resolve({ + ok: false, + status: 404, + json: async () => ({ error: "No client record found for this user" }), + } as Response); + } + return Promise.resolve({ ok: true, json: async () => ({}) } as Response); + }) as unknown as typeof fetch; + + const { CustomerPortal } = await import("../portal/CustomerPortal.js"); + render( + + + + ); + + await waitFor(() => { + expect(screen.getByText(/Portal access not configured/i)).toBeInTheDocument(); + }); + expect(screen.getByText(/not linked to a customer record/i)).toBeInTheDocument(); + // Sign-out escape hatch is present so the user is not stuck in a loop + expect(screen.getByRole("button", { name: /Sign out/i })).toBeInTheDocument(); + }); + + it("does not call session-from-auth when there is no Better Auth session", async () => { + global.fetch = vi.fn((input: RequestInfo) => { + const url = typeof input === "string" ? input : input.toString(); + if (url === "/api/branding") return Promise.resolve(brandingResponse); + if (url === "/api/auth/get-session") { + return Promise.resolve({ + ok: true, + json: async () => null, + } as Response); + } + return Promise.resolve({ ok: true, json: async () => ({}) } as Response); + }) as unknown as typeof fetch; + + const { CustomerPortal } = await import("../portal/CustomerPortal.js"); + render( + + + + ); + + await waitFor(() => { + expect(global.fetch).toHaveBeenCalledWith("/api/auth/get-session", expect.objectContaining({ credentials: "include" })); + }); + // Wait one tick to ensure no subsequent bridge call is queued + await new Promise((r) => setTimeout(r, 30)); + const bridgeCalls = vi.mocked(global.fetch).mock.calls.filter( + ([u]) => typeof u === "string" && u === "/api/portal/session-from-auth" + ); + expect(bridgeCalls).toHaveLength(0); + }); + + it("skips the bridge for staff Better Auth sessions", async () => { + global.fetch = vi.fn((input: RequestInfo) => { + const url = typeof input === "string" ? input : input.toString(); + if (url === "/api/branding") return Promise.resolve(brandingResponse); + if (url === "/api/auth/get-session") { + return Promise.resolve({ + ok: true, + json: async () => ({ user: { email: "staff@example.com", role: "staff" } }), + } as Response); + } + return Promise.resolve({ ok: true, json: async () => ({}) } as Response); + }) as unknown as typeof fetch; + + const { CustomerPortal } = await import("../portal/CustomerPortal.js"); + render( + + + + ); + + await waitFor(() => { + expect(global.fetch).toHaveBeenCalledWith("/api/auth/get-session", expect.objectContaining({ credentials: "include" })); + }); + await new Promise((r) => setTimeout(r, 30)); + const bridgeCalls = vi.mocked(global.fetch).mock.calls.filter( + ([u]) => typeof u === "string" && u === "/api/portal/session-from-auth" + ); + expect(bridgeCalls).toHaveLength(0); + }); +}); diff --git a/src/portal/CustomerPortal.tsx b/src/portal/CustomerPortal.tsx index a542cc0..db0dcbd 100644 --- a/src/portal/CustomerPortal.tsx +++ b/src/portal/CustomerPortal.tsx @@ -43,6 +43,15 @@ export function CustomerPortal() { // Track whether an impersonation session fetch from URL param is in-flight // Dashboard will not redirect while this is true, allowing the session to load const [isImpersonating, setIsImpersonating] = useState(false); + // Portal session ID for real SSO customers (GRO-1867). Populated by the + // Better Auth → /api/portal/session-from-auth bridge below. Carries the + // X-Impersonation-Session-Id header on subsequent portal API calls without + // triggering the impersonation banner (the customer is themselves). + const [portalSessionId, setPortalSessionId] = useState(null); + // User-facing message when the SSO bridge cannot resolve a client record + // (e.g. authenticated user with no matching client row). Rendered in place + // of the portal chrome instead of bouncing back to /login. + const [authError, setAuthError] = useState(null); const { branding } = useBranding(); const [searchParams, setSearchParams] = useSearchParams(); @@ -98,10 +107,64 @@ export function CustomerPortal() { } }) .finally(() => setInitComplete(true)); - } else { - // No valid session: staff dev users and unauthenticated users fall through here - setInitComplete(true); + return; } + + if (devUser && devUser.type === "staff") { + // Staff dev user — fall through; App.tsx redirects to /admin. + setInitComplete(true); + return; + } + + // Real SSO customer (GRO-1867): bridge a Better Auth session into a portal + // session via POST /api/portal/session-from-auth. The returned session ID + // is used in the X-Impersonation-Session-Id header for portal API calls. + (async () => { + try { + const sessionResp = await fetch("/api/auth/get-session", { credentials: "include" }); + if (!sessionResp.ok) { + setInitComplete(true); + return; + } + let sessionData: { user?: { email?: string; role?: string | null } } | null = null; + try { + sessionData = (await sessionResp.json()) as { user?: { email?: string; role?: string | null } } | null; + } catch { + // Better Auth returns an empty body when there is no session + } + if (!sessionData || !sessionData.user) { + setInitComplete(true); + return; + } + // Staff are routed to /admin by App.tsx; don't run the customer bridge. + if (sessionData.user.role === "staff") { + setInitComplete(true); + return; + } + + const bridgeResp = await fetch("/api/portal/session-from-auth", { + method: "POST", + credentials: "include", + }); + + if (bridgeResp.ok) { + const data = await bridgeResp.json() as { sessionId: string; clientId: string; clientName: string }; + setPortalSessionId(data.sessionId); + setClientName(data.clientName); + } else if (bridgeResp.status === 404) { + // Authenticated but no matching client row — show a friendly message + // instead of bouncing back to /login (which would loop indefinitely). + setAuthError( + "Your account is not linked to a customer record. Please contact your groomer to set up portal access." + ); + } + // 401/other: fall through; App.tsx render guard will redirect to /login. + } catch { + // Network error — fall through; the render guard will redirect to /login. + } finally { + setInitComplete(true); + } + })(); }, []); const handleEnd = useCallback(async () => { @@ -157,7 +220,7 @@ export function CustomerPortal() { const isReadOnly = session?.status === "active"; const renderSection = () => { - const sessionId = session?.id ?? null; + const sessionId = session?.id ?? portalSessionId; switch (activeSection) { case "dashboard": return ; @@ -183,7 +246,40 @@ export function CustomerPortal() { // For client dev users, we stay on the portal even if session is null — the dev-session // response may not have id set immediately, or there may be timing issues with the // session state. Dev users are verified via localStorage and the dev-session flow. - if (initComplete && !session) { + // SSO customers are recognised by portalSessionId (set by the Better Auth bridge). + if (initComplete && !session && !portalSessionId) { + if (authError) { + // GRO-1867: graceful 404 fallback — authenticated user has no client row. + return ( +
+
+
+ +
+

Portal access not configured

+

{authError}

+ +
+
+ ); + } const devUser = getDevUser(); if (devUser && devUser.type === "staff") { return ; From 3d7b247562065e5b21f1caad8d99a78d73b98daa Mon Sep 17 00:00:00 2001 From: Lint Roller <23+gb_lint@noreply.git.farh.net> Date: Mon, 1 Jun 2026 16:36:44 +0000 Subject: [PATCH 14/15] =?UTF-8?q?fix(GRO-2011):=20/login=20renders=20blank?= =?UTF-8?q?=20=E2=80=94=20always=20fetch=20setup/status=20for=20unauth=20u?= =?UTF-8?q?sers=20(#36)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Lint Roller <23+gb_lint@noreply.git.farh.net> Co-committed-by: Lint Roller <23+gb_lint@noreply.git.farh.net> --- UAT_PLAYBOOK.md | 1 + src/App.tsx | 11 +++++-- src/__tests__/App.test.tsx | 59 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 68 insertions(+), 3 deletions(-) diff --git a/UAT_PLAYBOOK.md b/UAT_PLAYBOOK.md index e6dbc30..271b295 100644 --- a/UAT_PLAYBOOK.md +++ b/UAT_PLAYBOOK.md @@ -53,6 +53,7 @@ export const { signIn, signOut, useSession, changePassword } = authClient; | TC-WEB-5.1.2 | OIDC redirect | Click OIDC login button | Redirected to OIDC provider, then back to app with session established | | TC-WEB-5.1.3 | Logout | Click logout button | Session cleared, redirected to login page | | TC-WEB-5.1.4 | Session indicator | After successful login | User info/initials visible in UI indicating active session | +| TC-WEB-5.1.5 | Unauthenticated `/login` renders the form (GRO-2011) | In a private/incognito window with no session cookie, navigate to UAT `/login` | React root mounts; the GroomBook sign-in card with the OIDC button is visible. Network tab shows `/api/auth/get-session` 200, `/api/setup/status` 200, and the login form is rendered (NOT a blank white viewport). | ### 5.2 Authentication — VITE_API_URL Set diff --git a/src/App.tsx b/src/App.tsx index 30d2091..1bbb17f 100644 --- a/src/App.tsx +++ b/src/App.tsx @@ -327,11 +327,16 @@ export function App() { .catch(() => setAuthDisabled(false)); }, []); - // After session is confirmed, check if setup is needed + // After session is confirmed, check if setup is needed. + // Always run the setup/status fetch as soon as the auth state is known — even for + // unauthenticated users, so the `needsSetup` value is in place if they sign in + // mid-session. The unauth branch in the render below is handled before + // `needsSetup` is consulted, so this is safe and avoids a stuck-`null` state. + // See GRO-2011. useEffect(() => { if (authDisabled === null || sessionLoading) return; - // Skip if no authenticated session (will redirect to login or dev selector) - if (!authDisabled && !session) return; + // In dev mode, only fetch when a dev user has been selected — otherwise the + // user is mid-redirect to the dev login selector and we don't need setup state. if (authDisabled && !getDevUser()) return; fetch("/api/setup/status") diff --git a/src/__tests__/App.test.tsx b/src/__tests__/App.test.tsx index ea5aea8..edddc4f 100644 --- a/src/__tests__/App.test.tsx +++ b/src/__tests__/App.test.tsx @@ -121,6 +121,65 @@ describe("App navigation", () => { }); }); +describe("GRO-2011 — setup/status fetch for unauthenticated users", () => { + it("calls /api/setup/status for unauthenticated users so needsSetup is never stuck null", async () => { + const setupStatusCalls: string[] = []; + + global.fetch = vi.fn((url: string) => { + if (url === "/api/dev/config") { + return Promise.resolve({ + ok: true, + json: async () => ({ authDisabled: false }), + } as Response); + } + if (url === "/api/auth/get-session") { + // Better Auth returns 200 with null session for unauthenticated users. + return Promise.resolve({ + ok: true, + json: async () => null, + } as unknown as Response); + } + if (url === "/api/setup/status") { + setupStatusCalls.push(url); + return Promise.resolve({ + ok: true, + json: async () => ({ needsSetup: false }), + } as Response); + } + if (url === "/api/branding") { + return Promise.resolve({ + ok: true, + json: async () => ({ + businessName: "GroomBook", + primaryColor: "#4f8a6f", + accentColor: "#8b7355", + logoBase64: null, + logoMimeType: null, + }), + } as Response); + } + return Promise.resolve({ ok: true, json: async () => [] } as Response); + }) as unknown as typeof fetch; + + render( + + + + ); + + // The login page should be rendered for the unauthenticated user. + await screen.findByText("Sign in to continue"); + + // Crucially, /api/setup/status must be called even when the user is unauthenticated — + // otherwise `needsSetup` stays null and a later code path can short-circuit to a + // blank page (GRO-2011). + await waitFor(() => { + expect(setupStatusCalls.length).toBeGreaterThanOrEqual(1); + }); + expect(setupStatusCalls[0]).toBe("/api/setup/status"); + }); +}); + describe("Dev login selector", () => { it("redirects to /login when auth is disabled and no user selected", async () => { global.fetch = vi.fn((url: string) => { From f29f1828c8aad98f54d03173e56cda29ac1f41b9 Mon Sep 17 00:00:00 2001 From: Flea Flicker <22+gb_flea@noreply.git.farh.net> Date: Mon, 1 Jun 2026 17:28:43 +0000 Subject: [PATCH 15/15] fix(GRO-2012): pass portalSessionId to RescheduleFlow for SSO bridge customers (#38) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fix(GRO-2012): pass portalSessionId to RescheduleFlow for SSO bridge customers (closes #38) - src/portal/CustomerPortal.tsx:329 - use portalSessionId fallback for RescheduleFlow - src/__tests__/portal.test.tsx - new regression test - UAT_PLAYBOOK.md §5.26 - new test cases cc @cpfarhood Co-Authored-By: Paperclip --- UAT_PLAYBOOK.md | 16 +++++++ src/__tests__/portal.test.tsx | 85 +++++++++++++++++++++++++++++++++++ src/portal/CustomerPortal.tsx | 2 +- 3 files changed, 102 insertions(+), 1 deletion(-) diff --git a/UAT_PLAYBOOK.md b/UAT_PLAYBOOK.md index 271b295..2a2faae 100644 --- a/UAT_PLAYBOOK.md +++ b/UAT_PLAYBOOK.md @@ -372,6 +372,22 @@ These cases cover the `CustomerPortal` initialisation path that bridges an Authe | TC-WEB-5.25.10 | Unauthenticated user is sent to login (no infinite loop) | Without signing in, navigate directly to `/`. | `App.tsx` renders the LoginPage. `CustomerPortal` does not render. No `session-from-auth` request is made. | | TC-WEB-5.25.11 | Session persists across reload via Better Auth cookie | After TC-WEB-5.25.1 succeeds, reload the page. | Portal dashboard re-renders. A fresh `GET /api/auth/get-session` + `POST /api/portal/session-from-auth` pair runs and yields 200/201. Greeting still reads "Hi, <FirstName>". | +### 5.26 Customer Portal — RescheduleFlow under SSO Bridge (GRO-2012) + +These cases guard against the regression where an SSO-bridge customer (no `?sessionId=` URL param, no impersonation session) could trigger the RescheduleFlow and have `RescheduleFlow` receive `sessionId={null}`, which caused the internal `/api/book/availability` call to send `X-Impersonation-Session-Id: ` (empty) and return 401. The fix: `CustomerPortal` now passes `sessionId={session?.id ?? portalSessionId}` to `` (matching the fallback `renderSection()` already used). + +**Pre-conditions:** + +- TC-WEB-5.25.1 — TC-WEB-5.25.3 must pass on the build under test. +- The seeded customer used has at least one upcoming, non-cancelled appointment with `status` ∈ {`pending`, `confirmed`}. + +| # | Scenario | Steps | Expected | +|---|----------|-------|----------| +| TC-WEB-5.26.1 | RescheduleFlow receives portalSessionId (no 401) | 1. Complete TC-WEB-5.25.1 (SSO sign-in as a customer). 2. From the dashboard, click **Reschedule** on the next-upcoming appointment. 3. In the RescheduleFlow modal, pick a future date. 4. Open DevTools → Network and filter to `/api/`. | The `GET /api/book/availability?date=` request includes an `X-Impersonation-Session-Id` header whose value equals the `sessionId` from `session-from-auth`. The request returns 200. The time-slot list populates. No 401. | +| TC-WEB-5.26.2 | RescheduleFlow submit succeeds | From TC-WEB-5.26.1, pick a time slot and confirm. | `POST /api/portal/appointments//reschedule` (or the equivalent) includes the same `X-Impersonation-Session-Id` value. Returns 200. The modal closes and the appointment card reflects the new time. | +| TC-WEB-5.26.3 | Impersonation flow reschedule is unchanged (no regression) | 1. With an active impersonation session (`?sessionId=`), load `/`. 2. Click **Reschedule** on an appointment. 3. Pick a date. | `GET /api/book/availability` includes `X-Impersonation-Session-Id` equal to the impersonation `sessionId` (not `portalSessionId`). Returns 200. Behaves identically to the pre-fix build. | +| TC-WEB-5.26.4 | No `X-Impersonation-Session-Id` is empty / null | From TC-WEB-5.26.1, inspect every `/api/portal/*` and `/api/book/*` request. | No request has an empty or `null` `X-Impersonation-Session-Id` header. | + ## 6. Pass/Fail Criteria **Pass:** diff --git a/src/__tests__/portal.test.tsx b/src/__tests__/portal.test.tsx index 5161aa1..96f1adf 100644 --- a/src/__tests__/portal.test.tsx +++ b/src/__tests__/portal.test.tsx @@ -5,6 +5,22 @@ import { ImpersonationBanner } from "../portal/ImpersonationBanner.js"; import { AuditLogViewer } from "../portal/AuditLogViewer.js"; import type { ImpersonationSession, ImpersonationAuditLog } from "@groombook/types"; +// Spy on the RescheduleFlow so we can assert the sessionId prop it receives +// from CustomerPortal without rendering the full flow UI. The real module is +// still loaded via importActual; only RescheduleFlow is swapped. +const rescheduleFlowSpy = vi.hoisted(() => + vi.fn((_props: { sessionId: string | null; appointment: { id: string } }) => null) +); +vi.mock("../portal/sections/Appointments.js", async () => { + const actual = await vi.importActual( + "../portal/sections/Appointments.js" + ); + return { + ...actual, + RescheduleFlow: rescheduleFlowSpy, + }; +}); + const SESSION: ImpersonationSession = { id: "sess-1", staffId: "staff-1", @@ -473,4 +489,73 @@ describe("CustomerPortal SSO bridge", () => { ); expect(bridgeCalls).toHaveLength(0); }); + + it("passes portalSessionId (not null) to RescheduleFlow for SSO bridge customers (GRO-2012)", async () => { + rescheduleFlowSpy.mockClear(); + + global.fetch = vi.fn((input: RequestInfo, init?: RequestInit) => { + const url = typeof input === "string" ? input : input.toString(); + if (url === "/api/branding") return Promise.resolve(brandingResponse); + if (url === "/api/auth/get-session") { + return Promise.resolve({ + ok: true, + json: async () => ({ user: { email: "customer@example.com", role: "customer" } }), + } as Response); + } + if (url === "/api/portal/session-from-auth" && init?.method === "POST") { + return Promise.resolve({ + ok: true, + status: 201, + json: async () => ({ sessionId: "sso-sess-1", clientId: "client-1", clientName: "Jane Doe" }), + } as Response); + } + // Dashboard data — return an upcoming appointment so the Reschedule + // button is rendered on the dashboard card. + if (url === "/api/portal/appointments") { + return Promise.resolve({ + ok: true, + json: async () => ({ + appointments: [ + { + id: "appt-1", + date: "2099-01-01", + time: "10:00", + petName: "Buddy", + serviceName: "Bath & Brush", + status: "confirmed", + }, + ], + }), + } as Response); + } + if (url === "/api/portal/pets") { + return Promise.resolve({ ok: true, json: async () => ({ pets: [] }) } as Response); + } + if (url === "/api/portal/invoices") { + return Promise.resolve({ ok: true, json: async () => ({ invoices: [] }) } as Response); + } + return Promise.resolve({ ok: true, json: async () => ({}) } as Response); + }) as unknown as typeof fetch; + + const { CustomerPortal } = await import("../portal/CustomerPortal.js"); + render( + + + + ); + + // Wait for the Reschedule button to appear on the dashboard card + const rescheduleBtn = await screen.findByRole("button", { name: /^Reschedule$/i }); + fireEvent.click(rescheduleBtn); + + // RescheduleFlow should have been invoked with the bridged portalSessionId, + // NOT null. Pre-fix, the call would be sessionId={null} for SSO customers. + await waitFor(() => { + expect(rescheduleFlowSpy).toHaveBeenCalled(); + }); + const lastProps = rescheduleFlowSpy.mock.lastCall?.[0]; + expect(lastProps).toBeDefined(); + expect(lastProps!.sessionId).toBe("sso-sess-1"); + expect(lastProps!.appointment.id).toBe("appt-1"); + }); }); diff --git a/src/portal/CustomerPortal.tsx b/src/portal/CustomerPortal.tsx index db0dcbd..3b284b7 100644 --- a/src/portal/CustomerPortal.tsx +++ b/src/portal/CustomerPortal.tsx @@ -326,7 +326,7 @@ export function CustomerPortal() { { setShowReschedule(false); setRescheduleAppointment(null); }} - sessionId={session?.id ?? null} + sessionId={session?.id ?? portalSessionId} /> )}