groombook/web
13
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

chore: promote dev → uat (GRO-1829 SW fix) #32

Merged
The Dogfather merged 4 commits from dev into uat 2026-05-27 02:27:32 +00:00
Conversation 0 Commits 4 Files Changed 2
+5 -2
The Dogfather commented 2026-05-27 02:26:50 +00:00
Member
Copy Link
Copy Source

Promotes the skipWaiting/clientsClaim ServiceWorker fix (PR #31) from dev to uat.

This fixes the blank-page regression so Shedward can resume UAT testing for SSO session persistence (GRO-1829).

Promotes the skipWaiting/clientsClaim ServiceWorker fix (PR #31) from dev to uat. This fixes the blank-page regression so Shedward can resume UAT testing for SSO session persistence (GRO-1829).
The Dogfather added 4 commits 2026-05-27 02:26:50 +00:00
fix(GRO-1822): add role check before /admin redirect — customers access portal
CI / Test (pull_request) Failing after 14s
Details
CI / Lint & Typecheck (pull_request) Failing after 17s
Details
CI / Build & Push Docker Image (pull_request) Has been skipped
Details
4e487db6f1 
App.tsx lines 389-393 redirected ALL authenticated users to /admin,
breaking customer portal access after SSO login.

Now checks `session.user.role === "staff"` before redirecting.
Customers (role !== "staff") can access the portal at /.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
Merge pull request 'fix(GRO-1822): add role check before /admin redirect — customers access portal' (#30) from fix/gro-1822-role-based-redirect into dev
CI / Test (push) Successful in 20s
Details
CI / Lint & Typecheck (push) Successful in 28s
Details
CI / Build & Push Docker Image (push) Successful in 34s
Details
9a3b5d88c8
fix: add skipWaiting/clientsClaim to VitePWA workbox config
CI / Test (pull_request) Successful in 15s
Details
CI / Lint & Typecheck (pull_request) Successful in 17s
Details
CI / Build & Push Docker Image (pull_request) Successful in 33s
Details
ad9a178c89 
Root cause: SW remained in waiting phase after redeploy, serving stale
precached assets. Without skipWaiting/clientsClaim the old SW persisted
and controlled the page even after a new SW was installed.

Fixes blank-page regression where React never mounted on login.
Merge pull request 'fix(GRO-1829): add skipWaiting/clientsClaim to VitePWA workbox config' (#31) from gro-1829-swpwa-fix into dev
CI / Lint & Typecheck (push) Successful in 17s
Details
CI / Test (push) Successful in 17s
Details
CI / Build & Push Docker Image (push) Successful in 31s
Details
CI / Test (pull_request) Successful in 14s
Details
CI / Lint & Typecheck (pull_request) Successful in 17s
Details
CI / Build & Push Docker Image (pull_request) Successful in 15s
Details
228a3d746c
The Dogfather merged commit 0e5e9d1f16 into uat 2026-05-27 02:27:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/web#32
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?