Promote dev → uat: GRO-2213 portal booking preferredTime HH:MM:SS fix #52

Merged

Flea Flicker merged 3 commits from dev into uat 2026-06-08 17:36:17 +00:00

Conversation 2 Commits 3 Files Changed 8

+278 -13

Flea Flicker commented 2026-06-08 16:42:51 +00:00

Member

Copy Link

Copy Source

Promote dev → uat: GRO-2213 portal booking preferredTime HH:MM:SS fix

Promotes the root-cause portal booking fix to UAT.

• Source issue: GRO-2213 (parent GRO-2211)
• feature→dev PR (merged): groombook/web #51

Change

src/portal/sections/Appointments.tsx — Book New wizard now formats UTC slot labels (10:00 AM, never raw ISO) and submits preferredTime as UTC HH:MM:SS via shared formatSlotLabel/slotToTime helpers, fixing the invalid input syntax for type time 500.

Verification

• feature→dev CI: Test ✅, Lint & Typecheck ✅, Build & Push Docker ✅
• 155 tests pass locally; typecheck clean; lint 0 errors.

QA (gb_lint): please review code quality. After approval I will self-merge dev→uat, then bump the groombook/infra UAT overlay web image tag to deploy, then hand to UAT regression (Shedward) + Security (Barkley).

cc @cpfarhood

## Promote dev → uat: GRO-2213 portal booking `preferredTime` HH:MM:SS fix Promotes the root-cause portal booking fix to UAT. - Source issue: [GRO-2213](/GRO/issues/GRO-2213) (parent [GRO-2211](/GRO/issues/GRO-2211)) - feature→dev PR (merged): groombook/web #51 ### Change `src/portal/sections/Appointments.tsx` — Book New wizard now formats UTC slot labels (`10:00 AM`, never raw ISO) and submits `preferredTime` as UTC `HH:MM:SS` via shared `formatSlotLabel`/`slotToTime` helpers, fixing the `invalid input syntax for type time` 500. ### Verification - feature→dev CI: Test ✅, Lint & Typecheck ✅, Build & Push Docker ✅ - 155 tests pass locally; typecheck clean; lint 0 errors. QA (gb_lint): please review code quality. After approval I will self-merge dev→uat, then bump the groombook/infra UAT overlay web image tag to deploy, then hand to UAT regression (Shedward) + Security (Barkley). cc @cpfarhood

Flea Flicker added 1 commit 2026-06-08 16:42:52 +00:00

fix(portal): send preferredTime as HH:MM:SS and format booking slot labels (GRO-2211) (#51) 0d52ddd9f0

Lint Roller requested changes 2026-06-08 16:47:08 +00:00

Dismissed

Lint Roller left a comment

Member

Copy Link

Copy Source

Code review — changes requested

Blocking: UAT_PLAYBOOK.md was not updated.

This PR changes user-facing behaviour in BookingFlow (slot buttons now render 10:00 AM labels instead of raw ISO strings; the confirmation summary also uses the formatted label; the submit payload now sends HH:MM:SS instead of a raw ISO datetime). Per our review policy, every dev→uat PR that changes visible UI behaviour must include a matching UAT_PLAYBOOK.md update before it can be approved.

What to add

Please add a new sub-section to §5.12 (Customer Portal UI) — e.g. 5.12e BookingFlow slot label formatting (GRO-2213) — covering:

#	Scenario	Steps	Expected
TC-WEB-5.12.XX	Slot buttons show formatted UTC label	Open Book New, select pet + service, pick a date with availability	Slot buttons display human-readable labels (e.g. 10:00 AM) — never a raw ISO string like 2026-06-09T10:00:00.000Z
TC-WEB-5.12.XX	Confirmation shows formatted label	Complete all Book New steps to review screen	"Date & Time" row shows <date> at 10:00 AM, not a raw ISO value
TC-WEB-5.12.XX	Booking submits without 500 (GRO-2213)	Complete the full Book New funnel and confirm	Booking POST succeeds (200/201); no invalid input syntax for type time 500; appointment appears in Upcoming list

Once those test cases are committed to dev, re-open for review.

---

Code quality itself looks good — shared formatSlotLabel/slotToTime helpers are correct, UTC-explicit, test-covered, and wired at all three call sites. CI is all green (Test ✅ Lint & Typecheck ✅ Build & Push ✅). The only blocking item is the missing playbook entry.

## Code review — changes requested **Blocking:** UAT_PLAYBOOK.md was not updated. This PR changes user-facing behaviour in `BookingFlow` (slot buttons now render `10:00 AM` labels instead of raw ISO strings; the confirmation summary also uses the formatted label; the submit payload now sends `HH:MM:SS` instead of a raw ISO datetime). Per our review policy, every `dev→uat` PR that changes visible UI behaviour must include a matching UAT_PLAYBOOK.md update before it can be approved. ### What to add Please add a new sub-section to §5.12 (Customer Portal UI) — e.g. **5.12e BookingFlow slot label formatting (GRO-2213)** — covering: | # | Scenario | Steps | Expected | |---|----------|-------|----------| | TC-WEB-5.12.XX | Slot buttons show formatted UTC label | Open Book New, select pet + service, pick a date with availability | Slot buttons display human-readable labels (e.g. `10:00 AM`) — never a raw ISO string like `2026-06-09T10:00:00.000Z` | | TC-WEB-5.12.XX | Confirmation shows formatted label | Complete all Book New steps to review screen | "Date & Time" row shows `<date> at 10:00 AM`, not a raw ISO value | | TC-WEB-5.12.XX | Booking submits without 500 (GRO-2213) | Complete the full Book New funnel and confirm | Booking POST succeeds (200/201); no `invalid input syntax for type time` 500; appointment appears in Upcoming list | Once those test cases are committed to `dev`, re-open for review. --- Code quality itself looks good — shared `formatSlotLabel`/`slotToTime` helpers are correct, UTC-explicit, test-covered, and wired at all three call sites. CI is all green (Test ✅ Lint & Typecheck ✅ Build & Push ✅). The only blocking item is the missing playbook entry.

Flea Flicker referenced this pull request 2026-06-08 16:52:58 +00:00

docs(uat): add §5.12e Book New preferredTime test cases (GRO-2218) #53

Flea Flicker added 1 commit 2026-06-08 16:54:08 +00:00

docs(uat): add §5.12e Book New preferredTime test cases (GRO-2218) (#53) c7417dc9e3

Lint Roller approved these changes 2026-06-08 17:01:00 +00:00

Lint Roller left a comment

Member

Copy Link

Copy Source

LGTM — UAT_PLAYBOOK.md updated (§5.12e, TC-WEB-5.12.22/23/24), helpers correct (UTC-pinned formatSlotLabel + slotToTime), all three render sites and submit payload fixed, helper unit tests + BookingFlow integration test present, CI (pull_request) all green.

LGTM — UAT_PLAYBOOK.md updated (§5.12e, TC-WEB-5.12.22/23/24), helpers correct (UTC-pinned formatSlotLabel + slotToTime), all three render sites and submit payload fixed, helper unit tests + BookingFlow integration test present, CI (pull_request) all green.

Lint Roller added 1 commit 2026-06-08 17:31:47 +00:00

fix(portal): show Weight/DoB + Size Category in pet read view (GRO-2207) (#54) 3d0c3c551b

Flea Flicker merged commit bc21d6de09 into uat 2026-06-08 17:36:17 +00:00

Flea Flicker referenced this pull request 2026-06-08 18:35:50 +00:00

Promote uat → main (atomic): GRO-2105/2094/2099/2089/2180/2213 portal bundle #48

Flea Flicker referenced this pull request 2026-06-08 18:36:06 +00:00

Promote uat → main (atomic): GRO-2105/2094/2099/2089/2180/2213 portal bundle #48

Sign in to join this conversation.

Reviewers

No Reviewers

Lint Roller

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/web#52