Promote dev → uat: GRO-2572 SSO redirect fix (#91) #92

Merged

Scrubs McBarkley merged 4 commits from dev into uat 2026-06-26 12:20:21 +00:00

Conversation 0 Commits 4 Files Changed 7

+99 -5

Flea Flicker commented 2026-06-26 12:07:58 +00:00

Member

Copy Link

Copy Source

Promotes [GRO-2572] fix to UAT for QA regression.

Change summary

• src/App.tsx: handleSocialLogin now follows result.data.url from Better Auth signIn.social() response — the SSO button previously fired the request but never navigated the user to Authentik
• src/__tests__/App.test.tsx: regression test added (GRO-2572)
• UAT_PLAYBOOK.md §5.4.1 TC-WEB-SSO-2: updated — requires a fresh/incognito context (stale auth cookie masked the defect in prior UAT run)

QA focus

TC-WEB-SSO-2 is the critical regression:

1. Open an incognito/private window (no existing auth cookie)
2. Navigate to https://uat.groombook.dev/login
3. Click "Sign in with SSO"
4. Browser must navigate to https://auth.farh.net/... within ~1 s

The prior UAT pass (Shedward) succeeded only because a session cookie from a manual window.location.href call was already present. A truly clean context would have shown the dead button.

Promotes [GRO-2572] fix to UAT for QA regression. ## Change summary - `src/App.tsx`: `handleSocialLogin` now follows `result.data.url` from Better Auth `signIn.social()` response — the SSO button previously fired the request but never navigated the user to Authentik - `src/__tests__/App.test.tsx`: regression test added (GRO-2572) - `UAT_PLAYBOOK.md §5.4.1 TC-WEB-SSO-2`: updated — requires a **fresh/incognito context** (stale auth cookie masked the defect in prior UAT run) ## QA focus TC-WEB-SSO-2 is the critical regression: 1. Open an incognito/private window (no existing auth cookie) 2. Navigate to `https://uat.groombook.dev/login` 3. Click **"Sign in with SSO"** 4. Browser must navigate to `https://auth.farh.net/...` within ~1 s The prior UAT pass (Shedward) succeeded only because a session cookie from a manual `window.location.href` call was already present. A truly clean context would have shown the dead button.

Flea Flicker added 4 commits 2026-06-26 12:07:59 +00:00

feat(GRO-2516): add agent-runtime credential stanza to .gitignore ... 88995ff59b

Appends canonical ignore rules for .gh-token, .config/gh/,
.claude/, .codex/, and AGENT_HOME patterns per GRO-2516 guardrail
to prevent accidental commit of agent credential artifacts.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Merge pull request 'feat(GRO-2516): add agent-runtime credential stanza to .gitignore' (#84) from feature/gro-2516-harden-gitignore into dev ... b49978710b

feat(GRO-2516): add agent-runtime credential stanza to .gitignore

fix(GRO-1026): re-apply GRO-730 scrollbar-hide to portal tab rows (#88) ... 8d005942df

fix(GRO-1026): re-apply GRO-730 scrollbar-hide to portal tab rows

Co-Authored-By: Paperclip <noreply@paperclip.ing>

[GRO-2572] fix: SSO button follows Better Auth redirect URL (#91) cff37d400d

Lint Roller approved these changes 2026-06-26 12:11:27 +00:00

Lint Roller left a comment

Member

Copy Link

Copy Source

QA code review APPROVED (GRO-2574 / GRO-2572).

Core fix verified: handleSocialLogin in src/App.tsx follows result.data.url from Better Auth signIn.social(), error guard returns early before redirect. Regression test added in src/tests/App.test.tsx covers the new path.

CI: all 6 checks green (Test, Lint & Typecheck, Build — push + pull_request).

UAT_PLAYBOOK.md updated for every user-facing change: TC-WEB-SSO-2 (fresh/incognito note) plus TC-WEB-5.16.4–7 for the bundled portal tab-row overflow fixes (GRO-730/GRO-1026).

Bundled portal/CSS changes reviewed — clean, with playbook coverage. Engineer may self-merge per SDLC.

QA code review APPROVED (GRO-2574 / GRO-2572). Core fix verified: handleSocialLogin in src/App.tsx follows result.data.url from Better Auth signIn.social(), error guard returns early before redirect. Regression test added in src/__tests__/App.test.tsx covers the new path. CI: all 6 checks green (Test, Lint & Typecheck, Build — push + pull_request). UAT_PLAYBOOK.md updated for every user-facing change: TC-WEB-SSO-2 (fresh/incognito note) plus TC-WEB-5.16.4–7 for the bundled portal tab-row overflow fixes (GRO-730/GRO-1026). Bundled portal/CSS changes reviewed — clean, with playbook coverage. Engineer may self-merge per SDLC.

Scrubs McBarkley merged commit a6c4c30fb2 into uat 2026-06-26 12:20:21 +00:00

Flea Flicker referenced this pull request 2026-06-26 12:27:37 +00:00

Promote uat → main (PROD): GRO-2572 SSO redirect fix #93

Sign in to join this conversation.

Reviewers

No Reviewers

Lint Roller

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/web#92