groombook/web
13
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-1829): add skipWaiting/clientsClaim to VitePWA workbox config #31

Merged
Scrubs McBarkley merged 1 commits from gro-1829-swpwa-fix into dev 2026-05-27 02:22:26 +00:00
Conversation 0 Commits 1 Files Changed 1
+2
Scrubs McBarkley commented 2026-05-27 02:22:13 +00:00
Owner
Copy Link
Copy Source

Summary

  • Add skipWaiting: true and clientsClaim: true to vite-plugin-pwa workbox config in vite.config.ts
  • Fixes blank-page regression where React never mounted on UAT

Root Cause

Without skipWaiting/clientsClaim, the old ServiceWorker stayed active after a new one was installed. The waiting-phase SW served stale precached HTML/JS/CSS, causing React to fail silently (blank login page).

Test plan

  • Build succeeds and dist/sw.js contains self.skipWaiting() and self.clients.claim()
  • Deploy to UAT — login page renders correctly (not blank)
  • Clear SW cache manually and reload — app loads fresh without blank screen

🤖 Generated with Claude Code

## Summary - Add `skipWaiting: true` and `clientsClaim: true` to `vite-plugin-pwa` workbox config in `vite.config.ts` - Fixes blank-page regression where React never mounted on UAT ## Root Cause Without `skipWaiting`/`clientsClaim`, the old ServiceWorker stayed active after a new one was installed. The waiting-phase SW served stale precached HTML/JS/CSS, causing React to fail silently (blank login page). ## Test plan - [ ] Build succeeds and `dist/sw.js` contains `self.skipWaiting()` and `self.clients.claim()` - [ ] Deploy to UAT — login page renders correctly (not blank) - [ ] Clear SW cache manually and reload — app loads fresh without blank screen 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Scrubs McBarkley added 1 commit 2026-05-27 02:22:13 +00:00
fix: add skipWaiting/clientsClaim to VitePWA workbox config
CI / Test (pull_request) Successful in 15s
Details
CI / Lint & Typecheck (pull_request) Successful in 17s
Details
CI / Build & Push Docker Image (pull_request) Successful in 33s
Details
ad9a178c89 
Root cause: SW remained in waiting phase after redeploy, serving stale
precached assets. Without skipWaiting/clientsClaim the old SW persisted
and controlled the page even after a new SW was installed.

Fixes blank-page regression where React never mounted on login.
Scrubs McBarkley merged commit 228a3d746c into dev 2026-05-27 02:22:26 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/web#31
Delete Branch "gro-1829-swpwa-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?