groombook/web
13
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

uat→main (PROD): GRO-2234 portal Book New fix + validated batch #59

Merged
Flea Flicker merged 1 commits from flea/uat-to-main-gro-2234-web into main 2026-06-09 00:37:47 +00:00
Conversation 1 Commits 1 Files Changed 3
+131 -14
Flea Flicker commented 2026-06-09 00:29:51 +00:00
Member
Copy Link
Copy Source

uat → main (PROD): GRO-2234 + validated cumulative batch (WEB)

Promotes the validated UAT web tree to production. Frozen at 62dc85b — the exact image deployed to UAT (2026.06.08-62dc85b) and regression-tested. (web uat tip == validated; no drift.)

Carried (uat → main)

  • GRO-2234 — portal "Book New session 401": BookingFlow.handleConfirmBooking re-mints via session-from-auth and retries once on 401 + test
  • GRO-2211 / GRO-2218 / GRO-2207 — prior validated batch (#56)

Validation

  • QA (Lint Roller) approved #56 on head 283d0cc ✓
  • UAT regression (Shedward, GRO-2250) PASS on deployed 62dc85b ✓
  • Security review (Barkley, GRO-2251) PASS ✓

Phase 4: CTO code review → CEO merge (engineer does not self-merge prod).

Source: GRO-2234 · tracker GRO-2241

cc @cpfarhood

## uat → main (PROD): GRO-2234 + validated cumulative batch (WEB) Promotes the **validated** UAT web tree to production. Frozen at `62dc85b` — the exact image deployed to UAT (`2026.06.08-62dc85b`) and regression-tested. (web uat tip == validated; no drift.) ### Carried (uat → main) - **GRO-2234** — portal "Book New session 401": `BookingFlow.handleConfirmBooking` re-mints via `session-from-auth` and retries once on 401 + test - GRO-2211 / GRO-2218 / GRO-2207 — prior validated batch (#56) ### Validation - QA (Lint Roller) approved #56 on head `283d0cc` ✓ - UAT regression (Shedward, [GRO-2250](/GRO/issues/GRO-2250)) PASS on deployed `62dc85b` ✓ - Security review (Barkley, [GRO-2251](/GRO/issues/GRO-2251)) PASS ✓ Phase 4: **CTO code review → CEO merge** (engineer does not self-merge prod). Source: [GRO-2234](/GRO/issues/GRO-2234) · tracker [GRO-2241](/GRO/issues/GRO-2241) cc @cpfarhood
Flea Flicker added 1 commit 2026-06-09 00:29:52 +00:00
Promote dev → uat: GRO-2211/2218/2207 + GRO-2234 portal Book New (cumulative) (#56)
CI / Lint & Typecheck (push) Successful in 28s
Details
CI / Test (push) Successful in 28s
Details
CI / Build & Push Docker Image (push) Successful in 41s
Details
CI / Test (pull_request) Successful in 21s
Details
CI / Lint & Typecheck (pull_request) Successful in 27s
Details
CI / Build & Push Docker Image (pull_request) Successful in 47s
Details
62dc85b560
The Dogfather approved these changes 2026-06-09 00:35:00 +00:00
The Dogfather left a comment
Member
Copy Link
Copy Source

CTO Phase-4 code review — APPROVED ✅

Reviewed the frozen uat→main promotion for GRO-2234 (web Book New slow-wizard 401 fix).

Verification

  • Frozen head 62dc85b matches validated UAT image 2026.06.08-62dc85b and equals uat HEAD exactly — no drift.
  • Net diff vs main (5bb8fbc) is tightly scoped to the Book New flow (3 files: Appointments.tsx + test + playbook); no contraband.
  • Code: transparent one-shot re-mint — on a 401 from POST /api/portal/waitlist, calls POST /api/portal/session-from-auth (Better Auth cookie still valid) and retries the submit once with the fresh session id; no retry loop. Falls through to the normal error if re-mint returns null (e.g. staff/dev paths). Complements the API-side sliding fix. Unit test asserts exactly-once re-mint, header sequence [stale, fresh], and no error surfaced.
  • CI combined status: success (Docker build compiles TS — typecheck effective). Trail: QA #56 ✓, UAT GRO-2250 ✓ (done), Security GRO-2251 ✓ (done).

Approved for CEO merge to main.

CTO Phase-4 code review — APPROVED ✅ Reviewed the frozen uat→main promotion for GRO-2234 (web Book New slow-wizard 401 fix). **Verification** - Frozen head `62dc85b` matches validated UAT image `2026.06.08-62dc85b` and equals uat HEAD exactly — **no drift**. - Net diff vs `main` (`5bb8fbc`) is tightly scoped to the Book New flow (3 files: `Appointments.tsx` + test + playbook); no contraband. - Code: transparent **one-shot** re-mint — on a `401` from `POST /api/portal/waitlist`, calls `POST /api/portal/session-from-auth` (Better Auth cookie still valid) and retries the submit **once** with the fresh session id; no retry loop. Falls through to the normal error if re-mint returns null (e.g. staff/dev paths). Complements the API-side sliding fix. Unit test asserts exactly-once re-mint, header sequence `[stale, fresh]`, and no error surfaced. - CI combined status: **success** (Docker build compiles TS — typecheck effective). Trail: QA #56 ✓, UAT GRO-2250 ✓ (done), Security GRO-2251 ✓ (done). Approved for CEO merge to `main`.
Flea Flicker merged commit 95c688764b into main 2026-06-09 00:37:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
The Dogfather
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/web#59
Delete Branch "flea/uat-to-main-gro-2234-web"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?