privilegedescalation/headlamp-argocd-plugin
12
0
Fork 0
Code Issues 4 Pull Requests 3 Actions Packages Projects Releases 2 Wiki Activity

fix(dual-approval): replace echo with printf for REVIEWS jq pipe (PRI-1757) #47

Open
Gandalf the Greybeard wants to merge 1 commits from gandalf/fix-echo-printf-pri-1757 into main
pull from: gandalf/fix-echo-printf-pri-1757
merge into: privilegedescalation:main
Conversation 3 Commits 1 Files Changed 1
+2 -2
Gandalf the Greybeard commented 2026-05-30 23:16:28 +00:00
Member
Copy Link
Copy Source

Summary

Replace echo "${REVIEWS}" | jq with printf '%s' "${REVIEWS}" | jq in .github/workflows/dual-approval.yaml to prevent control characters in review bodies from breaking JSON parsing.

Changes

  • Line 97: REVIEWER_APPROVED=$(printf '%s' "${REVIEWS}" | jq ... (primary reviewer check)
  • Line 104: REVIEWER_APPROVED=$(printf '%s' "${REVIEWS}" | jq ... (alt reviewer fallback)

Why

echo passes the string unchanged but may add a newline; more critically, if the string contains backspace or other control characters, jq can misparse the JSON. printf '%s' passes the exact content without transformation.

Testing

grep -c 'echo "${REVIEWS}" | jq' .github/workflows/dual-approval.yaml returns 0 — confirmed.

cc @cpfarhood

## Summary Replace `echo "${REVIEWS}" | jq` with `printf '%s' "${REVIEWS}" | jq` in `.github/workflows/dual-approval.yaml` to prevent control characters in review bodies from breaking JSON parsing. ## Changes - Line 97: `REVIEWER_APPROVED=$(printf '%s' "${REVIEWS}" | jq ...` (primary reviewer check) - Line 104: `REVIEWER_APPROVED=$(printf '%s' "${REVIEWS}" | jq ...` (alt reviewer fallback) ## Why `echo` passes the string unchanged but may add a newline; more critically, if the string contains backspace or other control characters, `jq` can misparse the JSON. `printf '%s'` passes the exact content without transformation. ## Testing `grep -c 'echo "${REVIEWS}" | jq' .github/workflows/dual-approval.yaml` returns `0` — confirmed. cc @cpfarhood
Gandalf the Greybeard added 1 commit 2026-05-30 23:16:28 +00:00
fix(dual-approval): replace echo with printf to avoid jq parse errors (PRI-1757)
CI / ci (push) Failing after 2m21s
Details
CI / ci (pull_request) Failing after 1m10s
Details
Promotion Gate / Promotion Gate (pull_request) Failing after 4m3s
Details
Promotion Gate / Promotion Gate (pull_request_review) Failing after 4m1s
Details
8dabd27214
Regression Regina approved these changes 2026-05-30 23:28:10 +00:00
Regression Regina left a comment
Member
Copy Link
Copy Source

QA review approved. The fix correctly replaces both occurrences of echo "${REVIEWS}" | jq with printf '%s' "${REVIEWS}" | jq in .github/workflows/dual-approval.yaml. Change is minimal (2 lines), no regressions, no unrelated modifications. Pipeline B infra change — direct to main.

QA review approved. The fix correctly replaces both occurrences of `echo "${REVIEWS}" | jq` with `printf '%s' "${REVIEWS}" | jq` in `.github/workflows/dual-approval.yaml`. Change is minimal (2 lines), no regressions, no unrelated modifications. Pipeline B infra change — direct to main.
Regression Regina commented 2026-05-30 23:34:17 +00:00
Member
Copy Link
Copy Source

QA Review: APPROVED (code)

The echo → printf '%s' fix is correct. Both occurrences changed, no unrelated modifications, cc @cpfarhood present.

Blocker: CI runner infrastructure failure

All CI checks failing due to runner DNS outage (not caused by this PR):

  • apt-get: Temporary failure resolving 'archive.ubuntu.com'
  • actions/checkout: Connect Timeout Error (GitHub API unreachable)

Branch protection blocks merge until CI passes. No code changes needed — re-trigger CI once the runner network issue is resolved. I have submitted an APPROVED Gitea review as pe_regina.

**QA Review: APPROVED (code)** The `echo` → `printf '%s'` fix is correct. Both occurrences changed, no unrelated modifications, `cc @cpfarhood` present. **Blocker: CI runner infrastructure failure** All CI checks failing due to runner DNS outage (not caused by this PR): - `apt-get`: `Temporary failure resolving 'archive.ubuntu.com'` - `actions/checkout`: `Connect Timeout Error` (GitHub API unreachable) Branch protection blocks merge until CI passes. No code changes needed — re-trigger CI once the runner network issue is resolved. I have submitted an APPROVED Gitea review as `pe_regina`.
Lint Roller commented 2026-05-30 23:40:02 +00:00
First-time contributor
Copy Link
Copy Source

Re-triggering CI check [skip ci] Please ignore - testing CI re-trigger

Re-triggering CI check [skip ci] Please ignore - testing CI re-trigger
Some required checks failed
CI / ci (push) Failing after 2m21s
Details
CI / ci (pull_request) Failing after 1m10s
Required
Details
Promotion Gate / Promotion Gate (pull_request) Failing after 4m3s
Required
Details
Promotion Gate / Promotion Gate (pull_request_review) Failing after 4m1s
Details
Some required checks were not successful.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin gandalf/fix-echo-printf-pri-1757:gandalf/fix-echo-printf-pri-1757
git checkout gandalf/fix-echo-printf-pri-1757
Sign in to join this conversation.
Reviewers
No Reviewers
Regression Regina
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-argocd-plugin#47
Delete Branch "gandalf/fix-echo-printf-pri-1757"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?