From 0c9e3e867233f170410b4b18b1104660b291abfa Mon Sep 17 00:00:00 2001 From: Chris Farhood Date: Sat, 30 May 2026 23:15:54 +0000 Subject: [PATCH] fix(dual-approval): replace echo with printf to avoid jq parse errors (PRI-1757) --- .github/workflows/dual-approval.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dual-approval.yaml b/.github/workflows/dual-approval.yaml index 2462cc9..fe36af8 100644 --- a/.github/workflows/dual-approval.yaml +++ b/.github/workflows/dual-approval.yaml @@ -94,14 +94,14 @@ jobs: exit 1 fi - REVIEWER_APPROVED=$(echo "${REVIEWS}" | jq -r --arg user "${REQUIRED_REVIEWER}" \ + REVIEWER_APPROVED=$(printf '%s' "${REVIEWS}" | jq -r --arg user "${REQUIRED_REVIEWER}" \ '[.[] | select(.user.login == $user)] | last | if .state then .state == "APPROVED" else false end') echo "${GATE_NAME} (${REQUIRED_REVIEWER}) approved: ${REVIEWER_APPROVED}" # Fallback: check if CTO approved as alternative for uat→main if [ "${REVIEWER_APPROVED}" != "true" ] && [ -n "${ALT_REVIEWER}" ]; then - REVIEWER_APPROVED=$(echo "${REVIEWS}" | jq -r --arg user "${ALT_REVIEWER}" \ + REVIEWER_APPROVED=$(printf '%s' "${REVIEWS}" | jq -r --arg user "${ALT_REVIEWER}" \ '[.[] | select(.user.login == $user)] | last | if .state then .state == "APPROVED" else false end') if [ "${REVIEWER_APPROVED}" = "true" ]; then echo "CTO (${ALT_REVIEWER}) approved as fallback for UAT gate."