From b58a2d87500ea34fddf049f9fbc4e1b0eb669403 Mon Sep 17 00:00:00 2001 From: Gandalf the Greybeard Date: Sat, 21 Mar 2026 07:50:03 +0000 Subject: [PATCH] style: run Prettier formatting and ESLint lint:fix on test files Addresses CI format:check failures and import-sort warning in MetricsPage.test.tsx flagged by QA on PR #17. Co-Authored-By: Claude Sonnet 4.6 --- src/components/DevicePluginsPage.test.tsx | 4 +--- src/components/MetricsPage.test.tsx | 2 +- src/components/NodeDetailSection.test.tsx | 8 ++------ src/components/OverviewPage.test.tsx | 5 ++++- src/components/PodDetailSection.test.tsx | 8 ++------ src/components/PodsPage.test.tsx | 12 +++--------- 6 files changed, 13 insertions(+), 26 deletions(-) diff --git a/src/components/DevicePluginsPage.test.tsx b/src/components/DevicePluginsPage.test.tsx index 7a77927..67e1f45 100644 --- a/src/components/DevicePluginsPage.test.tsx +++ b/src/components/DevicePluginsPage.test.tsx @@ -124,9 +124,7 @@ describe('DevicePluginsPage', () => { ); render(); expect(screen.getByText('CRD Not Available')).toBeInTheDocument(); - expect( - screen.getByText(/GpuDevicePlugin CRD.*is not installed/) - ).toBeInTheDocument(); + expect(screen.getByText(/GpuDevicePlugin CRD.*is not installed/)).toBeInTheDocument(); }); it('shows "No Device Plugins" section when crdAvailable=true but devicePlugins empty', () => { diff --git a/src/components/MetricsPage.test.tsx b/src/components/MetricsPage.test.tsx index bfad015..b92cae8 100644 --- a/src/components/MetricsPage.test.tsx +++ b/src/components/MetricsPage.test.tsx @@ -2,7 +2,7 @@ import { fireEvent, render, screen, waitFor } from '@testing-library/react'; import React from 'react'; import { describe, expect, it, vi } from 'vitest'; import { IntelGpuContextValue, useIntelGpuContext } from '../api/IntelGpuDataContext'; -import { GpuChipMetrics, GpuMetrics, fetchGpuMetrics } from '../api/metrics'; +import { fetchGpuMetrics, GpuChipMetrics, GpuMetrics } from '../api/metrics'; import MetricsPage from './MetricsPage'; vi.mock('@kinvolk/headlamp-plugin/lib/CommonComponents', () => ({ diff --git a/src/components/NodeDetailSection.test.tsx b/src/components/NodeDetailSection.test.tsx index 08fe04c..464214a 100644 --- a/src/components/NodeDetailSection.test.tsx +++ b/src/components/NodeDetailSection.test.tsx @@ -89,9 +89,7 @@ describe('NodeDetailSection', () => { it('renders nothing for a non-GPU node passed via jsonData wrapper', () => { vi.mocked(useIntelGpuContext).mockReturnValue(makeContext()); - const { container } = render( - - ); + const { container } = render(); expect(container).toBeEmptyDOMElement(); }); @@ -132,9 +130,7 @@ describe('NodeDetailSection', () => { metadata: { name: 'my-gpu-pod', namespace: 'default', uid: 'uid-pod-1' }, spec: { nodeName: 'gpu-node-1', - containers: [ - { name: 'main', resources: { requests: { 'gpu.intel.com/i915': '1' } } }, - ], + containers: [{ name: 'main', resources: { requests: { 'gpu.intel.com/i915': '1' } } }], }, status: { phase: 'Running' }, }; diff --git a/src/components/OverviewPage.test.tsx b/src/components/OverviewPage.test.tsx index 05fe420..01be3a4 100644 --- a/src/components/OverviewPage.test.tsx +++ b/src/components/OverviewPage.test.tsx @@ -109,7 +109,10 @@ describe('OverviewPage', () => { name: 'gpu-node-1', labels: { 'intel.feature.node.kubernetes.io/gpu': 'true' }, }, - status: { capacity: { 'gpu.intel.com/i915': '1' }, allocatable: { 'gpu.intel.com/i915': '1' } }, + status: { + capacity: { 'gpu.intel.com/i915': '1' }, + allocatable: { 'gpu.intel.com/i915': '1' }, + }, }; vi.mocked(useIntelGpuContext).mockReturnValue( makeContext({ loading: false, pluginInstalled: true, gpuNodes: [node] }) diff --git a/src/components/PodDetailSection.test.tsx b/src/components/PodDetailSection.test.tsx index ee3ffaa..9fa2af5 100644 --- a/src/components/PodDetailSection.test.tsx +++ b/src/components/PodDetailSection.test.tsx @@ -36,9 +36,7 @@ const nonGpuPodRaw = { kind: 'Pod', metadata: { name: 'plain-pod', namespace: 'default' }, spec: { - containers: [ - { name: 'main', resources: { requests: { cpu: '100m', memory: '128Mi' } } }, - ], + containers: [{ name: 'main', resources: { requests: { cpu: '100m', memory: '128Mi' } } }], }, status: { phase: 'Running' }, }; @@ -86,9 +84,7 @@ describe('PodDetailSection', () => { }); it('renders nothing for a non-GPU pod passed via jsonData', () => { - const { container } = render( - - ); + const { container } = render(); expect(container).toBeEmptyDOMElement(); }); diff --git a/src/components/PodsPage.test.tsx b/src/components/PodsPage.test.tsx index 340832c..e4415c6 100644 --- a/src/components/PodsPage.test.tsx +++ b/src/components/PodsPage.test.tsx @@ -135,9 +135,7 @@ describe('PodsPage', () => { it('shows summary section with total count when pods present', () => { const pods = [makeRunningPod('pod-1'), makeRunningPod('pod-2')]; - vi.mocked(useIntelGpuContext).mockReturnValue( - makeContext({ loading: false, gpuPods: pods }) - ); + vi.mocked(useIntelGpuContext).mockReturnValue(makeContext({ loading: false, gpuPods: pods })); render(); expect(screen.getByText('Summary')).toBeInTheDocument(); // 'Total GPU Pods' label is present; '2' appears in multiple places (row value + status label) @@ -147,9 +145,7 @@ describe('PodsPage', () => { it('shows "Attention: Pending GPU Pods" section when pending pods exist', () => { const pods = [makePendingPod('pending-pod-1')]; - vi.mocked(useIntelGpuContext).mockReturnValue( - makeContext({ loading: false, gpuPods: pods }) - ); + vi.mocked(useIntelGpuContext).mockReturnValue(makeContext({ loading: false, gpuPods: pods })); render(); expect(screen.getByText('Attention: Pending GPU Pods')).toBeInTheDocument(); // Pod name appears in both the main "All GPU Pods" table and the pending attention table @@ -166,9 +162,7 @@ describe('PodsPage', () => { it('shows "All GPU Pods" table with pod name when pods present', () => { const pods = [makeRunningPod('my-workload')]; - vi.mocked(useIntelGpuContext).mockReturnValue( - makeContext({ loading: false, gpuPods: pods }) - ); + vi.mocked(useIntelGpuContext).mockReturnValue(makeContext({ loading: false, gpuPods: pods })); render(); expect(screen.getByText('All GPU Pods')).toBeInTheDocument(); expect(screen.getByText('my-workload')).toBeInTheDocument();