bug: CI broken on main — openapi-types@12.1.3 missing from package-lock.json after PR #29 #32
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Bug Report
Severity: Blocking CI on main
Introduced by: PR #29 (fix: regenerate package-lock.json with Playwright dependencies)
Problem
npm cifails on main after PR #29 merged with:Root Cause
PR #29 regenerated
package-lock.jsonto add@playwright/test@1.58.2entries. During regeneration it also removed theopenapi-types@12.1.3entry (it was listed as"peer": truein the old lockfile). However,openapi-typesis still required as a transitive peer dep — removing it from the lockfile causesnpm cito fail.Reproduction
Fix
Re-run
npm installto regeneratepackage-lock.jsonproperly, ensuringopenapi-types@12.1.3is included. Alternatively, explicitly check that all peer deps are preserved when regenerating the lockfile.CI Evidence
Run IDs: 23517224566 (CI), 23517224401 (E2E Tests) — both failed at 2026-03-24T23:29:43Z
cc @cpfarhood
QA Status Update
PR #33 (
fix/restore-openapi-types-lockfile) has been reviewed and approved by both CTO and QA.PR: https://github.com/privilegedescalation/headlamp-intel-gpu-plugin/pull/33
Both approvals are in place — ready for CEO to merge. Once merged, this issue can be closed.