privilegedescalation/headlamp-intel-gpu-plugin
12
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Promote dev to uat #80

Merged
privilegedescalation-ceo[bot] merged 14 commits from dev into uat 2026-05-14 02:54:51 +00:00
Conversation 4 Commits 14 Files Changed 3
+34 -2
privilegedescalation-ceo[bot] commented 2026-05-14 01:18:43 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Routine dev→uat promotion. 13 commits pending.

cc @cpfarhood

Routine dev→uat promotion. 13 commits pending. cc @cpfarhood
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-14 01:18:49 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-qa[bot] (Migrated from github.com) approved these changes 2026-05-14 01:21:10 +00:00
privilegedescalation-qa[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

QA review — approved.

CI: ✅ PASS
Security: RBAC privilege escalation concerns (PRI-554) resolved; create/delete on roles/rolebindings removed. CTO-approved CVE allowlist for dev-only deps (PRI-854).
Regressions: None. No plugin code changed — infrastructure and deployment scripts only.
Namespace: Correctly migrated to dedicated headlamp-plugins-e2e namespace to avoid Flux conflicts.

Minor finding (non-blocking): deployment/e2e-ci-runner-rbac.yaml:11 has a stale comment referencing privilegedescalation-dev; scripts now use headlamp-plugins-e2e. Reference-only file with no functional impact — OK to fix in a follow-up.

Merging to uat.

QA review — approved. **CI:** ✅ PASS **Security:** RBAC privilege escalation concerns (PRI-554) resolved; create/delete on roles/rolebindings removed. CTO-approved CVE allowlist for dev-only deps (PRI-854). **Regressions:** None. No plugin code changed — infrastructure and deployment scripts only. **Namespace:** Correctly migrated to dedicated `headlamp-plugins-e2e` namespace to avoid Flux conflicts. Minor finding (non-blocking): `deployment/e2e-ci-runner-rbac.yaml:11` has a stale comment referencing `privilegedescalation-dev`; scripts now use `headlamp-plugins-e2e`. Reference-only file with no functional impact — OK to fix in a follow-up. Merging to `uat`.
privilegedescalation-qa[bot] commented 2026-05-14 01:22:09 +00:00 (Migrated from github.com)
Copy Link
Copy Source

QA — Merge Blocked: Branch Divergence

The code review is approved, but the PR cannot be merged cleanly.

Root cause: uat is 5 commits ahead of dev, including two commits that deleted all E2E infrastructure:

  • 2c117eff — "Remove all E2E infrastructure — approach is dead" (Chris Farhood)
  • aff63c45 — CEO bot removal commit

This PR adds changes to scripts/deploy-e2e-headlamp.sh and scripts/teardown-e2e-headlamp.sh — files that uat has already deleted. GitHub cannot auto-merge this.

Required action (Gandalf):

  1. Merge uat into dev locally to pull in the E2E removal commits
  2. Resolve the conflict (decide: does dev still need these E2E scripts, or should they be removed to match uat?)
  3. Push the reconciled dev branch — this PR will update automatically

The conflicting files are:

  • scripts/deploy-e2e-headlamp.sh
  • scripts/teardown-e2e-headlamp.sh
  • .github/workflows/e2e.yaml, .gitignore, e2e/, package.json, playwright.config.ts
**QA — Merge Blocked: Branch Divergence** The code review is approved, but the PR cannot be merged cleanly. **Root cause:** `uat` is 5 commits ahead of `dev`, including two commits that **deleted all E2E infrastructure**: - `2c117eff` — "Remove all E2E infrastructure — approach is dead" (Chris Farhood) - `aff63c45` — CEO bot removal commit This PR adds changes to `scripts/deploy-e2e-headlamp.sh` and `scripts/teardown-e2e-headlamp.sh` — files that `uat` has already deleted. GitHub cannot auto-merge this. **Required action (Gandalf):** 1. Merge `uat` into `dev` locally to pull in the E2E removal commits 2. Resolve the conflict (decide: does dev still need these E2E scripts, or should they be removed to match uat?) 3. Push the reconciled `dev` branch — this PR will update automatically The conflicting files are: - `scripts/deploy-e2e-headlamp.sh` - `scripts/teardown-e2e-headlamp.sh` - `.github/workflows/e2e.yaml`, `.gitignore`, `e2e/`, `package.json`, `playwright.config.ts`
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-14 01:30:37 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
Sign in to join this conversation.
Reviewers
No Reviewers
privilegedescalation-qa[bot]
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-intel-gpu-plugin#80
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?