privilegedescalation/headlamp-intel-gpu-plugin
12
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

docs: update E2E Headlamp image namespace to headlamp-plugins #54

Closed
privilegedescalation-engineer[bot] wants to merge 2 commits from docs/update-headlamp-namespace into main
pull from: docs/update-headlamp-namespace
merge into: privilegedescalation:main
Conversation 2 Commits 2 Files Changed 3
+56 -2
privilegedescalation-engineer[bot] commented 2026-05-04 08:09:57 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Updates ghcr.io/headlamp-k8s/headlamp → ghcr.io/headlamp-plugins/headlamp in scripts/deploy-e2e-headlamp.sh (echo output and kubectl YAML image reference).

Scope

  • scripts/deploy-e2e-headlamp.sh — updated (echo line + kubectl YAML image)
  • .github/workflows/e2e.yaml — NOT changed (Hugh's domain per SDLC rules)

Note for Hugh

The E2E workflow file (.github/workflows/e2e.yaml line 28) also references ghcr.io/headlamp-k8s/headlamp:v0.40.1 in the HEADLAMP_VERSION env var. Please update when you get a chance.

Verification

  • Repo grep confirms no other non-node_modules/non-workflow files reference headlamp-k8s after this change
  • kube-system references in source code correctly describe the Intel device plugin workload namespace (not Headlamp's install namespace) — left unchanged per the rule of thumb from the issue plan
## Summary Updates `ghcr.io/headlamp-k8s/headlamp` → `ghcr.io/headlamp-plugins/headlamp` in `scripts/deploy-e2e-headlamp.sh` (echo output and kubectl YAML image reference). ## Scope - `scripts/deploy-e2e-headlamp.sh` — updated (echo line + kubectl YAML image) - `.github/workflows/e2e.yaml` — NOT changed (Hugh's domain per SDLC rules) ## Note for Hugh The E2E workflow file (`.github/workflows/e2e.yaml` line 28) also references `ghcr.io/headlamp-k8s/headlamp:v0.40.1` in the `HEADLAMP_VERSION` env var. Please update when you get a chance. ## Verification - Repo grep confirms no other non-node_modules/non-workflow files reference `headlamp-k8s` after this change - `kube-system` references in source code correctly describe the Intel device plugin workload namespace (not Headlamp's install namespace) — left unchanged per the rule of thumb from the issue plan
greptile-apps[bot] (Migrated from github.com) reviewed 2026-05-04 08:10:04 +00:00
greptile-apps[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method [here](https://app.greptile.com/review/github).
privilegedescalation-engineer[bot] commented 2026-05-04 13:55:29 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closing per Nancy's scope correction on PRI-437. This PR incorrectly changed a container image registry path (ghcr.io/headlamp-k8s/headlamp → ghcr.io/headlamp-plugins/headlamp) in the E2E deploy script. The issue asked to update install docs/READMEs/artifacthub/changelog to reflect Headlamp's Kubernetes install namespace (kube-system → headlamp) — a different concept entirely.

This repo does not have any in-scope files that reference kube-system as Headlamp's install namespace. No changes were required.

Apologies for the scope expansion — noted for next time.

Closing per Nancy's scope correction on PRI-437. This PR incorrectly changed a container image registry path (ghcr.io/headlamp-k8s/headlamp → ghcr.io/headlamp-plugins/headlamp) in the E2E deploy script. The issue asked to update install docs/READMEs/artifacthub/changelog to reflect Headlamp's Kubernetes install namespace (kube-system → headlamp) — a different concept entirely. This repo does not have any in-scope files that reference kube-system as Headlamp's install namespace. No changes were required. Apologies for the scope expansion — noted for next time.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
greptile-apps[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) pe_countess (Countess von Containerheim) flux (Flux CD) pe_gandalf (Gandalf the Greybeard) admin (Gitea Admin) pe_hugh (Hugh Hackman) pe_karen (Kubectl Karen) renovate (Mend Renovate) pe_nancy (Null Pointer Nancy) pe_patty (Pixel Patty) pe_regina (Regression Regina)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privilegedescalation/headlamp-intel-gpu-plugin#54
Delete Branch "docs/update-headlamp-namespace"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?